[PATCH] IPv6: fix Mobile IPv6 regression

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Brian Haley
Date: Friday, May 28, 2010 - 11:17 am

Commit f4f914b5 (net: ipv6 bind to device issue) caused
a regression with Mobile IPv6 when it changed the meaning
of fl->oif to become a strict requirement of the route
lookup.  Instead, only force strict mode when
sk->sk_bound_dev_if is set on the calling socket, getting
the intended behavior and fixing the regression.

Tested-by: Arnaud Ebalard <arno@natisbad.org>
Signed-off-by: Brian Haley <brian.haley@hp.com>

diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index 294cbe8..252d761 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -814,7 +814,7 @@ struct dst_entry * ip6_route_output(struct net *net, struct sock *sk,
 {
 	int flags = 0;
 
-	if (fl->oif || rt6_need_strict(&fl->fl6_dst))
+	if ((sk && sk->sk_bound_dev_if) || rt6_need_strict(&fl->fl6_dst))
 		flags |= RT6_LOOKUP_F_IFACE;
 
 	if (!ipv6_addr_any(&fl->fl6_src))
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[REGRESSION,BISECTED] MIPv6 support broken by f4f914b58019f0, Arnaud Ebalard, (Wed May 26, 10:01 am)
Re: [REGRESSION,BISECTED] MIPv6 support broken by f4f914b5 ..., YOSHIFUJI Hideaki, (Thu May 27, 10:39 am)
[PATCH] IPv6: fix Mobile IPv6 regression, Brian Haley, (Fri May 28, 11:17 am)
Re: [REGRESSION,BISECTED] MIPv6 support broken by f4f914b5 ..., YOSHIFUJI Hideaki, (Fri May 28, 11:40 am)
Re: [PATCH] IPv6: fix Mobile IPv6 regression, David Miller, (Fri May 28, 11:03 pm)
Re: [PATCH] IPv6: fix Mobile IPv6 regression, Jiri Olsa, (Mon May 31, 1:46 am)
Re: [PATCH] IPv6: fix Mobile IPv6 regression, Jiri Olsa, (Mon May 31, 5:49 am)