Re: [PATCH v4 4/7] tcp: input header length, prediction, and timestamp bugs

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: William Allen Simpson

Subject: Re: [PATCH v4 4/7] tcp: input header length, prediction, and timestamp bugs

Date: Monday, February 15, 2010 - 2:24 pm

Andi Kleen wrote:
quoted text> On Mon, Feb 15, 2010 at 02:03:34PM -0500, William Allen Simpson wrote:
>> Andi Kleen wrote:
>>> Is this a bug fix? 
>>>
>> Yes.  One of many, all inter-related.
>>
> It's useful to distingush bug fixes from cleanups from optimizations etc.
> ...

The bug fixes depend on the cleanups.
  * 1/7 has the new functions.
  * 2/7 has bug fixes that require the new functions.
  * 3/7 fixes (and optimizes) the incoming code path, so that
  * 4/7 can fix the bugs.
  * 5/7 is needed to test the code from part 1.
  * 6/7 is the cleanup of parsing (also fixes some bugs introduced by
    davem's patch in December), so that
  * 7/7 can fix the bugs.

I originally tried submitting these as separate individual pairs of
patches (in November, December, January), but nobody paid any attention.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH 0/7] tcp: bugs and cleanup updated to 2.6.33-rc8 (a ..., William Allen Simpson, (Mon Feb 15, 5:23 am)

[PATCH v3 1/7] net: tcp_header_len_th and tcp_option_len_th, William Allen Simpson, (Mon Feb 15, 5:25 am)

[PATCH v3 2/7] net: remove old tcp_optlen function, William Allen Simpson, (Mon Feb 15, 5:27 am)

[PATCH v5 3/7] tcp: harmonize tcp_vx_rcv header length ass ..., William Allen Simpson, (Mon Feb 15, 5:28 am)

[PATCH v4 4/7] tcp: input header length, prediction, and t ..., William Allen Simpson, (Mon Feb 15, 5:31 am)

[PATCH v3 5/7] TCPCT part 2e: accept SYNACK data, William Allen Simpson, (Mon Feb 15, 5:34 am)

[PATCH v5 6/7] TCPCT part 2f: cleanup tcp_parse_options, William Allen Simpson, (Mon Feb 15, 5:41 am)

[PATCH v7 7/7] TCPCT part 2g: parse cookie pair and 64-bit ..., William Allen Simpson, (Mon Feb 15, 5:45 am)

Re: [PATCH v5 3/7] tcp: harmonize tcp_vx_rcv header length ..., Andi Kleen, (Mon Feb 15, 5:48 am)

Re: [PATCH v5 3/7] tcp: harmonize tcp_vx_rcv header length ..., William Allen Simpson, (Mon Feb 15, 5:59 am)

Re: [PATCH v4 4/7] tcp: input header length, prediction, a ..., Andi Kleen, (Mon Feb 15, 8:10 am)

Re: [PATCH v4 4/7] tcp: input header length, prediction, a ..., William Allen Simpson, (Mon Feb 15, 12:03 pm)

Re: [PATCH v4 4/7] tcp: input header length, prediction, a ..., Andi Kleen, (Mon Feb 15, 12:15 pm)