[PATCH 1/3] f_phonet: dev_kfree_skb instead of dev_kfree_skb_any in TX callback

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Rémi Denis-Courmont
Date: Monday, June 1, 2009 - 4:18 am

From: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>

Network device TX is never run in IRQ context, and skb is freed outside
of the IRQ-disabling spin lock. So checking for IRQ was a waste of time
here.

Signed-off-by: Rémi Denis-Courmont <remi.denis-courmont@nokia.com>
Signed-off-by: Felipe Balbi <felipe.balbi@nokia.com>
---
 drivers/usb/gadget/f_phonet.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/usb/gadget/f_phonet.c b/drivers/usb/gadget/f_phonet.c
index c1abeb8..54451ee 100644
--- a/drivers/usb/gadget/f_phonet.c
+++ b/drivers/usb/gadget/f_phonet.c
@@ -255,7 +255,7 @@ out_unlock:
 	spin_unlock_irqrestore(&port->lock, flags);
 out:
 	if (unlikely(skb)) {
-		dev_kfree_skb_any(skb);
+		dev_kfree_skb(skb);
 		dev->stats.tx_dropped++;
 	}
 	return 0;
-- 
1.6.0.4

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 1/3] f_phonet: dev_kfree_skb instead of dev_kfree_s ..., Rémi Denis-Courmont, (Mon Jun 1, 4:18 am)
[PATCH 2/3] f_phonet: no need to check for carrier - sched ..., Rémi Denis-Courmont, (Mon Jun 1, 4:18 am)
[PATCH 3/3] usb: gadget: f_phonet: fix memory allocation sizes, Rémi Denis-Courmont, (Mon Jun 1, 4:18 am)