On Thu, Jul 24, 2008 at 04:34:31PM +0300, Octavian Purdila wrote:
quoted text
>
> > What about the other callers of copy_skb_header, like pskb_copy?
> 
> From what I understand, the shinfo remains shared, thus there is no need to do 
> the copy here.

No pskb_copy does a full copy on the head portion of the packet
which is where your cmsg is.

quoted text
> > Also what about pskb_expand_head?
> >
> 
> I think this is only touching the skb header, not the shinfo. Thus we should 
> be safe?

But you're freeing the cmsg in skb_release_data which is called
by pskb_expand_head.  This can't possibly work.

quoted text
> BTW: I have a dilemma with regard to fully copied skbs: should we copy the 
> cmsg queue as well, or should we just prune it in the copy? I don't see a 
> real usecase for doing the copy at this point, but since these is at core 
> level, maybe it is a good idea to be conservative and do the copying?

Do we need to make it so generic? If we do then can you please
come up with other uses for it too.  For example, find out what
existing fields can be better suited by storing them as a cmsg.
Only then can we design this properly.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html