Re: [RFC PATCH 2/2] [TCP] MTUprobe: Cleanup send queue check (no need to loop)

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Herbert Xu

Subject: Re: [RFC PATCH 2/2] [TCP] MTUprobe: Cleanup send queue check (no need to loop)

Date: Thursday, November 22, 2007 - 4:00 am

On Wed, Nov 21, 2007 at 06:01:28PM +0200, Ilpo Järvinen wrote:
quoted text> The original code has striking complexity to perform a query
> which can be reduced to a very simple compare.
> 
> FIN seqno may be included to write_seq but it should not make
> any significant difference here compared to skb->len which was
> used previously. One won't end up there with SYN still queued.
> 
> Use of write_seq check guarantees that there's a valid skb in
> send_head so I removed the extra check.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>

OK, this one looks pretty straightforward.  I'll put it in once
we resolve the other patch.

Thanks,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[RFC PATCH 0/2]: TCP MTUprobe fixes , Ilpo Järvinen, (Wed Nov 21, 9:01 am)

[RFC PATCH 1/2] [TCP]: MTUprobe: receiver window & data av ..., Ilpo Järvinen, (Wed Nov 21, 9:01 am)

[RFC PATCH 2/2] [TCP] MTUprobe: Cleanup send queue check ( ..., Ilpo Järvinen, (Wed Nov 21, 9:01 am)

Re: [RFC PATCH 2/2] [TCP] MTUprobe: Cleanup send queue che ..., John Heffner, (Wed Nov 21, 9:25 am)

Re: [RFC PATCH 1/2] [TCP]: MTUprobe: receiver window & dat ..., John Heffner, (Wed Nov 21, 9:25 am)

Re: [RFC PATCH 1/2] [TCP]: MTUprobe: receiver window & dat ..., Herbert Xu, (Thu Nov 22, 2:27 am)

Re: [RFC PATCH 2/2] [TCP] MTUprobe: Cleanup send queue che ..., Herbert Xu, (Thu Nov 22, 4:00 am)

Re: [RFC PATCH 1/2] [TCP]: MTUprobe: receiver window & dat ..., Ilpo Järvinen, (Thu Nov 22, 6:11 am)

Re: [RFC PATCH 1/2] [TCP]: MTUprobe: receiver window & dat ..., Herbert Xu, (Thu Nov 22, 8:16 am)