Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Benjamin Herrenschmidt
Date: Wednesday, October 17, 2007 - 2:08 am

> Btw., since, because of this patch, I've had a one more look at phy.c

 .../...

While there... is somebody interested in making the whole PHY lib
operate a task level and use mutexes instead of spinlock ? I need that
for drivers like EMAC (who use their own PHY layer for now), and I might
even give a go at adapting phylib myself, but I'd like to take the
temperature about it first.

Basically, there is nothing in phylib that is performance critical or
such that requires it to run at irq time and/or use locks. On the other
hand, it complicates things in various areas. The most obvious one being
that it prevents the network driver mii access callbacks from sleeping
which can be annoying as MDIO can be slow, and some drivers have fancy
muxes in there that are better off mutexed than spinlocked.

Ben.
 

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH] PHYLIB: IRQ event workqueue handling fixes, Maciej W. Rozycki, (Wed Sep 19, 7:38 am)
Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes, Andrew Morton, (Thu Sep 20, 4:53 pm)
Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes, Maciej W. Rozycki, (Fri Sep 21, 5:51 am)
Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes, Andrew Morton, (Fri Sep 21, 11:42 am)
Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes, Jarek Poplawski, (Mon Oct 15, 5:53 am)
Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes, Maciej W. Rozycki, (Mon Oct 15, 10:03 am)
Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes, Jarek Poplawski, (Mon Oct 15, 11:21 pm)
Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes, Maciej W. Rozycki, (Tue Oct 16, 10:19 am)
Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes, Jarek Poplawski, (Wed Oct 17, 1:58 am)
Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes, Benjamin Herrenschmidt, (Wed Oct 17, 2:08 am)
Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes, Jarek Poplawski, (Wed Oct 17, 2:09 am)
Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes, Jarek Poplawski, (Wed Oct 17, 11:31 pm)
Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes, Maciej W. Rozycki, (Thu Oct 18, 4:30 am)
Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes, Maciej W. Rozycki, (Thu Oct 18, 4:37 am)
Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes, Jarek Poplawski, (Thu Oct 18, 7:37 am)
Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes, Maciej W. Rozycki, (Thu Oct 18, 8:31 am)
Re: [PATCH] flush_work_sync vs. flush_scheduled_work Re: [ ..., Maciej W. Rozycki, (Thu Oct 18, 8:58 am)
Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes, Jarek Poplawski, (Fri Oct 19, 1:17 am)
Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes, Maciej W. Rozycki, (Fri Oct 19, 4:38 am)
Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes, Maciej W. Rozycki, (Fri Oct 19, 5:57 am)
Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes, Jarek Poplawski, (Fri Oct 19, 7:39 am)
Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes, Maciej W. Rozycki, (Fri Oct 19, 10:58 am)
Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes, Benjamin Herrenschmidt, (Fri Oct 19, 2:46 pm)