Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages | KernelTrap

Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages

view
thread

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Minchan Kim

Subject: Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages

Date: Wednesday, April 21, 2010 - 10:06 am

On Wed, Apr 21, 2010 at 11:15 PM, Christoph Lameter
<cl@linux-foundation.org> wrote:
quoted text> On Tue, 20 Apr 2010, Mel Gorman wrote:
>
>> alloc_pages_exact_node() avoids a branch in a hot path that is checking for
>> something the caller already knows. That's the reason it exists.
>
> We can avoid alloc_pages_exact_node() by making all callers of
> alloc_pages_node() never use -1. -1 is ambiguous and only rarely will a
> caller pass that to alloc_pages_node().

That's very reasonable to me.
Then, we can remove alloc_pages_exact_node and nid < 0 check in
alloc_pages_node at the same time.

Mel. Could you agree?

Firstly Tejun suggested this but I didn't got the point.
Sorry for bothering you.

Okay. I will dive into this approach.
Thanks for careful review, All.


quoted text> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
>



-- 
Kind regards,
Minchan Kim
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH 1/6] Remove node's validity check in alloc_pages, Minchan Kim, (Tue Apr 13, 8:24 am)

[PATCH 2/6] change alloc function in pcpu_alloc_pages, Minchan Kim, (Tue Apr 13, 8:24 am)

[PATCH 3/6] change alloc function in alloc_slab_page, Minchan Kim, (Tue Apr 13, 8:25 am)

[PATCH 4/6] change alloc function in vmemmap_alloc_block, Minchan Kim, (Tue Apr 13, 8:25 am)

[PATCH 5/6] change alloc function in __vmalloc_area_node, Minchan Kim, (Tue Apr 13, 8:25 am)

[PATCH 6/6] Add comment in alloc_pages_exact_node, Minchan Kim, (Tue Apr 13, 8:25 am)

Re: [PATCH 1/6] Remove node's validity check in alloc_pages, Mel Gorman, (Tue Apr 13, 8:32 am)

Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Mel Gorman, (Tue Apr 13, 8:48 am)

Re: [PATCH 3/6] change alloc function in alloc_slab_page, Mel Gorman, (Tue Apr 13, 8:52 am)

Re: [PATCH 4/6] change alloc function in vmemmap_alloc_block, Mel Gorman, (Tue Apr 13, 8:59 am)

Re: [PATCH 3/6] change alloc function in alloc_slab_page, Minchan Kim, (Tue Apr 13, 9:01 am)

Re: [PATCH 5/6] change alloc function in __vmalloc_area_node, Mel Gorman, (Tue Apr 13, 9:02 am)

Re: [PATCH 6/6] Add comment in alloc_pages_exact_node, Mel Gorman, (Tue Apr 13, 9:13 am)

Re: [PATCH 3/6] change alloc function in alloc_slab_page, Mel Gorman, (Tue Apr 13, 9:14 am)

Re: [PATCH 6/6] Add comment in alloc_pages_exact_node, Minchan Kim, (Tue Apr 13, 9:20 am)

Re: [PATCH 3/6] change alloc function in alloc_slab_page, David Rientjes, (Tue Apr 13, 2:37 pm)

Re: [PATCH 3/6] change alloc function in alloc_slab_page, Minchan Kim, (Tue Apr 13, 4:40 pm)

Re: [PATCH 3/6] change alloc function in alloc_slab_page, David Rientjes, (Tue Apr 13, 4:55 pm)

Re: [PATCH 3/6] change alloc function in alloc_slab_page, Minchan Kim, (Tue Apr 13, 5:02 pm)

Re: [PATCH 1/6] Remove node's validity check in alloc_pages, KAMEZAWA Hiroyuki, (Tue Apr 13, 5:04 pm)

Re: [PATCH 3/6] change alloc function in alloc_slab_page, KAMEZAWA Hiroyuki, (Tue Apr 13, 5:18 pm)

Re: [PATCH 4/6] change alloc function in vmemmap_alloc_block, KAMEZAWA Hiroyuki, (Tue Apr 13, 5:19 pm)

Re: [PATCH 5/6] change alloc function in __vmalloc_area_node, KAMEZAWA Hiroyuki, (Tue Apr 13, 5:22 pm)

Re: [PATCH 5/6] change alloc function in __vmalloc_area_node, Minchan Kim, (Tue Apr 13, 5:33 pm)

Re: [PATCH 3/6] change alloc function in alloc_slab_page, Pekka Enberg, (Wed Apr 14, 5:23 am)

Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Tejun Heo, (Wed Apr 14, 4:39 pm)

Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Minchan Kim, (Wed Apr 14, 6:31 pm)

Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Tejun Heo, (Thu Apr 15, 12:21 am)

Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Minchan Kim, (Thu Apr 15, 1:00 am)

Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Tejun Heo, (Thu Apr 15, 1:15 am)

Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Minchan Kim, (Thu Apr 15, 2:40 am)

Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Tejun Heo, (Thu Apr 15, 3:08 am)

Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Minchan Kim, (Thu Apr 15, 3:21 am)

Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Minchan Kim, (Thu Apr 15, 3:33 am)

Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Tejun Heo, (Thu Apr 15, 4:43 am)

Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Minchan Kim, (Thu Apr 15, 4:49 am)

Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Christoph Lameter, (Fri Apr 16, 9:07 am)

Re: [PATCH 3/6] change alloc function in alloc_slab_page, Christoph Lameter, (Fri Apr 16, 9:10 am)

Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Lee Schermerhorn, (Fri Apr 16, 12:13 pm)

Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Minchan Kim, (Sun Apr 18, 8:54 am)

Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Minchan Kim, (Sun Apr 18, 8:55 am)

Re: [PATCH 3/6] change alloc function in alloc_slab_page, Pekka Enberg, (Sun Apr 18, 11:49 am)

Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Tejun Heo, (Sun Apr 18, 2:22 pm)

Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Minchan Kim, (Sun Apr 18, 5:03 pm)

Re: [PATCH 3/6] change alloc function in alloc_slab_page, Mel Gorman, (Mon Apr 19, 2:05 am)

Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Christoph Lameter, (Mon Apr 19, 10:38 am)

Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Christoph Lameter, (Mon Apr 19, 10:45 am)

Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Tejun Heo, (Mon Apr 19, 3:27 pm)

Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Minchan Kim, (Mon Apr 19, 5:20 pm)

Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Mel Gorman, (Tue Apr 20, 8:05 am)

Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Tejun Heo, (Wed Apr 21, 3:48 am)

Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Christoph Lameter, (Wed Apr 21, 7:15 am)

Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Minchan Kim, (Wed Apr 21, 10:06 am)

Re: [PATCH 2/6] change alloc function in pcpu_alloc_pages, Minchan Kim, (Thu Apr 22, 3:15 am)