Home » Mailing list archives » linux-kernel » 2010 » April » 15

Re: [PATCH 1/4] vmscan: simplify shrink_inactive_list()

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Andi Kleen
Subject: Re: [PATCH 1/4] vmscan: simplify shrink_inactive_list()
Date: Thursday, April 15, 2010 - 8:01 am

Mel Gorman <mel@csn.ul.ie> writes:

And the next time someone adds a new feature to these code paths or
the compiler inlines differently these 72 bytes are easily there
again. It's not really a long term solution. Code is tending to get
more complicated all the time. I consider it unlikely this trend will
stop any time soon.

So just doing some stack micro optimizations doesn't really help 
all that much.

-Andi

-- 
ak@linux.intel.com -- Speaking for myself only.
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[PATCH] mm: disallow direct reclaim page writeback, Dave Chinner, (Mon Apr 12, 5:17 pm)
Re: [PATCH] mm: disallow direct reclaim page writeback, KOSAKI Motohiro, (Tue Apr 13, 1:31 am)
Re: [PATCH] mm: disallow direct reclaim page writeback, Mel Gorman, (Tue Apr 13, 2:58 am)
Re: [PATCH] mm: disallow direct reclaim page writeback, Dave Chinner, (Tue Apr 13, 3:29 am)
Re: [PATCH] mm: disallow direct reclaim page writeback, Dave Chinner, (Tue Apr 13, 4:19 am)
Re: [PATCH] mm: disallow direct reclaim page writeback, KOSAKI Motohiro, (Tue Apr 13, 4:39 am)
Re: [PATCH] mm: disallow direct reclaim page writeback, Dave Chinner, (Tue Apr 13, 7:36 am)
Re: [PATCH] mm: disallow direct reclaim page writeback, Mel Gorman, (Tue Apr 13, 12:34 pm)
Re: [PATCH] mm: disallow direct reclaim page writeback, Chris Mason, (Tue Apr 13, 1:20 pm)
Re: [PATCH] mm: disallow direct reclaim page writeback, Minchan Kim, (Tue Apr 13, 5:24 pm)
Re: [PATCH] mm: disallow direct reclaim page writeback, Dave Chinner, (Tue Apr 13, 6:40 pm)
Re: [PATCH] mm: disallow direct reclaim page writeback, Dave Chinner, (Tue Apr 13, 8:12 pm)
Re: [PATCH] mm: disallow direct reclaim page writeback, Dave Chinner, (Tue Apr 13, 9:44 pm)
Re: [PATCH] mm: disallow direct reclaim page writeback, KAMEZAWA Hiroyuki, (Tue Apr 13, 9:59 pm)
Re: [PATCH] mm: disallow direct reclaim page writeback, Dave Chinner, (Tue Apr 13, 10:41 pm)
Re: [PATCH] mm: disallow direct reclaim page writeback, KOSAKI Motohiro, (Tue Apr 13, 10:54 pm)
Re: [PATCH] mm: disallow direct reclaim page writeback, Minchan Kim, (Tue Apr 13, 11:13 pm)
Re: [PATCH] mm: disallow direct reclaim page writeback, KOSAKI Motohiro, (Tue Apr 13, 11:52 pm)
Re: [PATCH] mm: disallow direct reclaim page writeback, KOSAKI Motohiro, (Tue Apr 13, 11:52 pm)
Re: [PATCH] mm: disallow direct reclaim page writeback, KOSAKI Motohiro, (Tue Apr 13, 11:52 pm)
Re: [PATCH] mm: disallow direct reclaim page writeback, KOSAKI Motohiro, (Tue Apr 13, 11:52 pm)
Re: [PATCH] mm: disallow direct reclaim page writeback, Dave Chinner, (Wed Apr 14, 12:06 am)
Re: [PATCH] mm: disallow direct reclaim page writeback, Minchan Kim, (Wed Apr 14, 12:19 am)
Re: [PATCH] mm: disallow direct reclaim page writeback, Dave Chinner, (Wed Apr 14, 12:28 am)
Re: [PATCH] mm: disallow direct reclaim page writeback, Dave Chinner, (Wed Apr 14, 12:36 am)
Re: [PATCH] mm: disallow direct reclaim page writeback, Minchan Kim, (Wed Apr 14, 12:54 am)
Re: [PATCH] mm: disallow direct reclaim page writeback, Mel Gorman, (Wed Apr 14, 1:51 am)
Re: [PATCH] mm: disallow direct reclaim page writeback, KAMEZAWA Hiroyuki, (Wed Apr 14, 2:42 am)
Re: [PATCH] mm: disallow direct reclaim page writeback, Minchan Kim, (Wed Apr 14, 3:01 am)
Re: [PATCH] mm: disallow direct reclaim page writeback, Andi Kleen, (Wed Apr 14, 3:06 am)
Re: [PATCH] mm: disallow direct reclaim page writeback, Mel Gorman, (Wed Apr 14, 3:07 am)
Re: [PATCH] mm: disallow direct reclaim page writeback, Minchan Kim, (Wed Apr 14, 3:16 am)
Re: [PATCH] mm: disallow direct reclaim page writeback, Chris Mason, (Wed Apr 14, 4:20 am)
Re: [PATCH] mm: disallow direct reclaim page writeback, Alan Cox, (Wed Apr 14, 5:32 am)
Re: [PATCH] mm: disallow direct reclaim page writeback, Andi Kleen, (Wed Apr 14, 5:34 am)
Re: [PATCH] mm: disallow direct reclaim page writeback, Mel Gorman, (Wed Apr 14, 6:23 am)
Re: [PATCH] mm: disallow direct reclaim page writeback, Chris Mason, (Wed Apr 14, 7:07 am)
Re: [PATCH] mm: disallow direct reclaim page writeback, Dave Chinner, (Wed Apr 14, 6:34 pm)
Re: [PATCH] mm: disallow direct reclaim page writeback, Dave Chinner, (Wed Apr 14, 6:56 pm)
Re: [PATCH] mm: disallow direct reclaim page writeback, Johannes Weiner, (Wed Apr 14, 7:37 pm)
Re: [PATCH] mm: disallow direct reclaim page writeback, KOSAKI Motohiro, (Wed Apr 14, 7:43 pm)
Re: [PATCH] mm: disallow direct reclaim page writeback, KOSAKI Motohiro, (Wed Apr 14, 9:09 pm)
[PATCH 1/4] vmscan: delegate pageout io to flusher thread ..., KOSAKI Motohiro, (Wed Apr 14, 9:11 pm)
[PATCH 2/4] vmscan: kill prev_priority completely, KOSAKI Motohiro, (Wed Apr 14, 9:13 pm)
[PATCH 3/4] vmscan: move priority variable into scan_control, KOSAKI Motohiro, (Wed Apr 14, 9:14 pm)
[PATCH 4/4] vmscan: delegate page cleaning io to flusher t ..., KOSAKI Motohiro, (Wed Apr 14, 9:15 pm)
Re: [PATCH] mm: disallow direct reclaim page writeback, KOSAKI Motohiro, (Wed Apr 14, 9:35 pm)
Re: [PATCH] mm: disallow direct reclaim page writeback, Dave Chinner, (Wed Apr 14, 11:20 pm)
Re: [PATCH] mm: disallow direct reclaim page writeback, Dave Chinner, (Wed Apr 14, 11:32 pm)
Re: [PATCH] mm: disallow direct reclaim page writeback, Dave Chinner, (Wed Apr 14, 11:58 pm)
Re: [PATCH 1/4] vmscan: delegate pageout io to flusher thr ..., Suleiman Souhlal, (Thu Apr 15, 1:05 am)
Re: [PATCH 1/4] vmscan: delegate pageout io to flusher thr ..., KOSAKI Motohiro, (Thu Apr 15, 1:17 am)
Re: [PATCH 1/4] vmscan: delegate pageout io to flusher thr ..., KOSAKI Motohiro, (Thu Apr 15, 1:18 am)
Re: [PATCH 1/4] vmscan: delegate pageout io to flusher thr ..., KOSAKI Motohiro, (Thu Apr 15, 1:26 am)
Re: [PATCH] mm: disallow direct reclaim page writeback, Dave Chinner, (Thu Apr 15, 1:54 am)
Re: [PATCH 1/4] vmscan: delegate pageout io to flusher thr ..., Dave Chinner, (Thu Apr 15, 2:32 am)
Re: [PATCH 1/4] vmscan: delegate pageout io to flusher thr ..., KOSAKI Motohiro, (Thu Apr 15, 2:41 am)
Re: [PATCH] mm: disallow direct reclaim page writeback, KOSAKI Motohiro, (Thu Apr 15, 3:21 am)
[PATCH 1/4] vmscan: simplify shrink_inactive_list(), KOSAKI Motohiro, (Thu Apr 15, 3:23 am)
[PATCH 2/4] [cleanup] mm: introduce free_pages_prepare, KOSAKI Motohiro, (Thu Apr 15, 3:24 am)
[PATCH 4/4] vmscan: replace the pagevec in shrink_inactive ..., KOSAKI Motohiro, (Thu Apr 15, 3:26 am)
Re: [PATCH] mm: disallow direct reclaim page writeback, Mel Gorman, (Thu Apr 15, 3:28 am)
Re: [PATCH 1/4] vmscan: delegate pageout io to flusher thr ..., Johannes Weiner, (Thu Apr 15, 3:30 am)
Re: [PATCH 1/4] vmscan: delegate pageout io to flusher thr ..., Mel Gorman, (Thu Apr 15, 3:31 am)
Re: [PATCH 1/4] vmscan: delegate pageout io to flusher thr ..., KOSAKI Motohiro, (Thu Apr 15, 4:26 am)
Re: [PATCH 1/4] vmscan: simplify shrink_inactive_list(), Mel Gorman, (Thu Apr 15, 6:15 am)
Re: [PATCH 2/4] [cleanup] mm: introduce free_pages_prepare, Mel Gorman, (Thu Apr 15, 6:33 am)
Re: [PATCH] mm: disallow direct reclaim page writeback, Chris Mason, (Thu Apr 15, 6:42 am)
Re: [PATCH 3/4] mm: introduce free_pages_bulk, Mel Gorman, (Thu Apr 15, 6:46 am)
Re: [PATCH] mm: disallow direct reclaim page writeback, Andi Kleen, (Thu Apr 15, 7:57 am)
Re: [PATCH 1/4] vmscan: simplify shrink_inactive_list(), Andi Kleen, (Thu Apr 15, 8:01 am)
Re: [PATCH 1/4] vmscan: simplify shrink_inactive_list(), Mel Gorman, (Thu Apr 15, 8:44 am)
Re: [PATCH 1/4] vmscan: simplify shrink_inactive_list(), Andi Kleen, (Thu Apr 15, 9:54 am)
Re: [PATCH 1/4] vmscan: delegate pageout io to flusher thr ..., Suleiman Souhlal, (Thu Apr 15, 10:24 am)
Re: [PATCH 1/4] vmscan: delegate pageout io to flusher thr ..., Suleiman Souhlal, (Thu Apr 15, 10:27 am)
Re: [PATCH] mm: disallow direct reclaim page writeback, tytso, (Thu Apr 15, 10:50 am)
Re: [PATCH 1/4] vmscan: simplify shrink_inactive_list(), Valdis.Kletnieks, (Thu Apr 15, 11:22 am)
Re: [PATCH 1/4] vmscan: delegate pageout io to flusher thr ..., Dave Chinner, (Thu Apr 15, 4:33 pm)
Re: [PATCH 1/4] vmscan: simplify shrink_inactive_list(), Dave Chinner, (Thu Apr 15, 4:40 pm)
Re: [PATCH 1/4] vmscan: delegate pageout io to flusher thr ..., Suleiman Souhlal, (Thu Apr 15, 4:41 pm)
Re: [PATCH] mm: disallow direct reclaim page writeback, KAMEZAWA Hiroyuki, (Thu Apr 15, 6:13 pm)
Re: [PATCH] mm: disallow direct reclaim page writeback, Dave Chinner, (Thu Apr 15, 9:14 pm)
Re: [PATCH] mm: disallow direct reclaim page writeback, KAMEZAWA Hiroyuki, (Thu Apr 15, 9:18 pm)
Re: [PATCH 1/4] vmscan: simplify shrink_inactive_list(), Andi Kleen, (Fri Apr 16, 12:13 am)
Re: [PATCH 1/4] vmscan: simplify shrink_inactive_list(), Mel Gorman, (Fri Apr 16, 2:39 am)
Re: [PATCH 1/4] vmscan: delegate pageout io to flusher thr ..., Alan Cox, (Fri Apr 16, 2:50 am)
Re: [PATCH 1/4] vmscan: simplify shrink_inactive_list(), Mel Gorman, (Fri Apr 16, 7:55 am)
Re: [PATCH 1/4] vmscan: simplify shrink_inactive_list(), Mel Gorman, (Fri Apr 16, 7:57 am)
Re: [PATCH] mm: disallow direct reclaim page writeback, Mel Gorman, (Fri Apr 16, 8:05 am)
Re: [PATCH] mm: disallow direct reclaim page writeback, Mel Gorman, (Fri Apr 16, 8:14 am)
Re: [PATCH] mm: disallow direct reclaim page writeback, Johannes Weiner, (Fri Apr 16, 4:56 pm)
Re: [PATCH 1/4] vmscan: simplify shrink_inactive_list(), Dave Chinner, (Fri Apr 16, 7:37 pm)
Re: [PATCH 1/4] vmscan: delegate pageout io to flusher thr ..., Dave Chinner, (Fri Apr 16, 8:06 pm)
Re: [PATCH] mm: disallow direct reclaim page writeback, Andrew Morton, (Sat Apr 17, 5:32 pm)
Re: [PATCH] mm: disallow direct reclaim page writeback, Andrew Morton, (Sun Apr 18, 9:31 am)
Re: [PATCH] mm: disallow direct reclaim page writeback, Christoph Hellwig, (Sun Apr 18, 12:05 pm)
Re: [PATCH] mm: disallow direct reclaim page writeback, Sorin Faibish, (Sun Apr 18, 12:10 pm)
Re: [PATCH] mm: disallow direct reclaim page writeback, Sorin Faibish, (Sun Apr 18, 12:11 pm)
Re: [PATCH] mm: disallow direct reclaim page writeback, Christoph Hellwig, (Sun Apr 18, 12:35 pm)
Re: [PATCH] mm: disallow direct reclaim page writeback, Sorin Faibish, (Sun Apr 18, 4:34 pm)
Re: [PATCH] mm: disallow direct reclaim page writeback, Dave Chinner, (Sun Apr 18, 5:35 pm)
Re: [PATCH] mm: disallow direct reclaim page writeback, Arjan van de Ven, (Sun Apr 18, 5:49 pm)
Re: [PATCH] mm: disallow direct reclaim page writeback, Dave Chinner, (Sun Apr 18, 6:08 pm)
Re: [PATCH] mm: disallow direct reclaim page writeback, tytso, (Sun Apr 18, 8:08 pm)
Re: [PATCH] mm: disallow direct reclaim page writeback, Arjan van de Ven, (Sun Apr 18, 9:32 pm)
Re: [PATCH] mm: disallow direct reclaim page writeback, Mel Gorman, (Mon Apr 19, 8:15 am)
Re: [PATCH] mm: disallow direct reclaim page writeback, Mel Gorman, (Mon Apr 19, 8:20 am)
Re: [PATCH 1/4] vmscan: delegate pageout io to flusher thr ..., Ying Han, (Mon Apr 19, 7:56 pm)
Re: [PATCH] mm: disallow direct reclaim page writeback, Dave Chinner, (Thu Apr 22, 6:06 pm)
Re: [PATCH] mm: disallow direct reclaim page writeback, Mel Gorman, (Fri Apr 23, 3:50 am)