Re: [PATCH v2] xtables: make XT_ALIGN() usable in exported headers by exporting __ALIGN_KERNEL()

view
thread

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Patrick McHardy

Subject: Re: [PATCH v2] xtables: make XT_ALIGN() usable in exported headers by exporting __ALIGN_KERNEL()

Date: Tuesday, April 13, 2010 - 4:08 am

Alexey Dobriyan wrote:
quoted text> XT_ALIGN() was rewritten through ALIGN() by commit 42107f5009da223daa800d6da6904d77297ae829
> "netfilter: xtables: symmetric COMPAT_XT_ALIGN definition".
> ALIGN() is not exported in userspace headers, which created compile problem for tc(8)
> and will create problem for iptables(8).
> 
> We can't export generic looking name ALIGN() but we can export less generic
> __ALIGN_KERNEL() (suggested by Ben Hutchings).
> Google knows nothing about __ALIGN_KERNEL().
> 
> COMPAT_XT_ALIGN() changed for symmetry.

I've already pushed your change out, could you send me an incremental
fix please?

master.kernel.org:/pub/scm/linux/kernel/git/kaber/nf-next-2.6.git
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH] xtables: make XT_ALIGN() usable in exported header ..., Alexey Dobriyan, (Wed Apr 7, 9:22 am)

Re: [PATCH] xtables: make XT_ALIGN() usable in exported he ..., Patrick McHardy, (Tue Apr 13, 2:22 am)

Re: [PATCH] xtables: make XT_ALIGN() usable in exported he ..., Patrick McHardy, (Tue Apr 13, 3:01 am)

Re: [PATCH v2] xtables: make XT_ALIGN() usable in exported ..., Patrick McHardy, (Tue Apr 13, 4:08 am)

Re: [PATCH v2] xtables: make XT_ALIGN() usable in exported ..., Patrick McHardy, (Tue Apr 13, 5:10 am)

[PATCH v2] xtables: make XT_ALIGN() usable in exported hea ..., Alexey Dobriyan, (Wed Apr 14, 5:07 am)

Re: [PATCH v2] xtables: make XT_ALIGN() usable in exported ..., Alexey Dobriyan, (Wed Apr 14, 5:50 am)

Navigation

Popular discussions


linux-kernel:
Greg KH	Og dreams of kernels
Jens Axboe	[PATCH 31/33] Fusion: sg chaining support
Arnd Bergmann	Re: finding your own dead "CONFIG_" variables
Mark Brown	[PATCH 2/2] Subject: natsemi: Allow users to disable workaround for DspCfg reset
Tony Breeds	[LGUEST] Look in object dir for .config
git:
Brian Downing	Re: Git in a Nutshell guide
John Benes	Re: master has some toys
Matthias Lederhofer	[PATCH 4/7] introduce GIT_WORK_TREE to specify the work tree
Alexander Sulfrian	[RFC/PATCH] RE: git calls SSH_ASKPASS even if DISPLAY is not set
Junio C Hamano	Re: Rss produced by git is not valid xml?
git-commits-head:
Linux Kernel Mailing List	iSeries: fix section mismatch in iseries_veth
Linux Kernel Mailing List	ixbge: remove TX lock and redo TX accounting.
Linux Kernel Mailing List	ixgbe: fix several counter register errata
Linux Kernel Mailing List	b43: fix build with CONFIG_SSB_PCIHOST=n
Linux Kernel Mailing List	9p: block-based virtio client
linux-netdev:
Michael Breuer	Re: [PATCH] af_packet: Don't use skb after dev_queue_xmit()
Michael Breuer