login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2010
»
April
»
12
Re: [v3 Patch 2/3] bridge: make bridge support netpoll
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Eric Dumazet
Subject:
Re: [v3 Patch 2/3] bridge: make bridge support netpoll
Date: Monday, April 12, 2010 - 3:38 am
Le lundi 12 avril 2010 à 18:37 +0800, Cong Wang a écrit :
quoted text
> Stephen Hemminger wrote: > > There is no protection on dev->priv_flags for SMP access. > > It would better bit value in dev->state if you are using it as control flag. > > > > Then you could use > > if (unlikely(test_and_clear_bit(__IN_NETPOLL, &skb->dev->state))) > > netpoll_send_skb(...) > > > > > > Hmm, I think we can't use ->state here, it is not for this kind of purpose, > according to its comments. > > Also, I find other usages of IFF_XXX flags of ->priv_flags are also using > &, | to set or clear the flags. So there must be some other things preventing > the race...
Yes, its RTNL that protects priv_flags changes, hopefully... --
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[v3 Patch 1/3] netpoll: add generic support for bridge and ...
, Amerigo Wang
, (Wed Apr 7, 11:18 pm)
[v3 Patch 2/3] bridge: make bridge support netpoll
, Amerigo Wang
, (Wed Apr 7, 11:18 pm)
[v3 Patch 3/3] bonding: make bonding support netpoll
, Amerigo Wang
, (Wed Apr 7, 11:19 pm)
Re: [v3 Patch 2/3] bridge: make bridge support netpoll
, Stephen Hemminger
, (Thu Apr 8, 8:37 am)
Re: [v3 Patch 2/3] bridge: make bridge support netpoll
, Cong Wang
, (Thu Apr 8, 10:43 pm)
Re: [v3 Patch 2/3] bridge: make bridge support netpoll
, Cong Wang
, (Mon Apr 12, 3:37 am)
Re: [v3 Patch 2/3] bridge: make bridge support netpoll
, Eric Dumazet
, (Mon Apr 12, 3:38 am)
Re: [Bonding-devel] [v3 Patch 2/3] bridge: make bridge sup ...
, Stephen Hemminger
, (Mon Apr 12, 8:38 am)
Re: [Bonding-devel] [v3 Patch 2/3] bridge: make bridge sup ...
, Cong Wang
, (Tue Apr 13, 1:57 am)
Re: [Bonding-devel] [v3 Patch 2/3] bridge: make bridge sup ...
, Jay Vosburgh
, (Tue Apr 13, 9:52 am)
Re: [Bonding-devel] [v3 Patch 2/3] bridge: make bridge sup ...
, Stephen Hemminger
, (Tue Apr 13, 10:33 am)
Re: [Bonding-devel] [v3 Patch 2/3] bridge: make bridge sup ...
, Cong Wang
, (Wed Apr 14, 1:11 am)
Re: [Bonding-devel] [v3 Patch 2/3] bridge: make bridge sup ...
, Cong Wang
, (Wed Apr 14, 1:16 am)
Navigation
Mailing list archives
Recent posts