Re: [git pull] x86 fixes

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linus Torvalds
Date: Monday, September 8, 2008 - 11:04 am

On Mon, 8 Sep 2008, H. Peter Anvin wrote:

Ok, so after having realized that this seems to be more about a bug with 
gcc, I'm really not as convinced any more.

As far as I can tell, there are three issues:

 - "-mtune=core/core2/pentium4/.." is buggy in some gas/gcc versions on 
   x86-32, and makes architectural choices.

   Any actual _released_ versions? Maybe it's just a current SVN issue?

   Workaround: don't use it. And yes, X86_GENERIC=y will do that, although 
   quite frankly that seems to be dubious in itself. But quite frankly, 
   it's a gcc bug, and we should see it as such.

   The better workaround may well be "-Wa,-mtune=generic" as you pointed 
   out.

 - We do the CONFIG_P6_NOPL thing ourselves, and we should just stop 
   doing that on 32-bit. There simply isn't a good enough reason to do so. 
   I already posteed the Kconfig.cpu patch to just stop doing it.

 - X86_GENERIC means _other_ things too, like doing a 128-bit cacheline 
   just so that it won't suck horribly on P4's even if it's otherwise 
   tuned for a good microarchitecture.

And they really do seem to be _separate_ issues. Do we really want to tie 
these things together under X86_GENERIC? 

		Linus
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[git pull] x86 fixes, H. Peter Anvin, (Mon Sep 8, 10:52 am)
Re: [git pull] x86 fixes, Linus Torvalds, (Mon Sep 8, 11:04 am)
Re: [git pull] x86 fixes, Linus Torvalds, (Mon Sep 8, 11:17 am)
Re: [git pull] x86 fixes, H. Peter Anvin, (Mon Sep 8, 11:22 am)
Re: [git pull] x86 fixes, Arjan van de Ven, (Mon Sep 8, 11:42 am)
Re: [git pull] x86 fixes, Arjan van de Ven, (Mon Sep 8, 11:46 am)
Re: [git pull] x86 fixes, H. Peter Anvin, (Mon Sep 8, 11:51 am)
Re: [git pull] x86 fixes, Ingo Molnar, (Mon Sep 8, 12:02 pm)
Re: [git pull] x86 fixes, Linus Torvalds, (Mon Sep 8, 12:30 pm)
Re: [git pull] x86 fixes, Arjan van de Ven, (Mon Sep 8, 12:55 pm)
Re: [git pull] x86 fixes, H. Peter Anvin, (Mon Sep 8, 1:14 pm)
Re: [git pull] x86 fixes, Valdis.Kletnieks, (Mon Sep 8, 1:25 pm)
Re: [git pull] x86 fixes, Andi Kleen, (Mon Sep 8, 3:42 pm)
Re: [git pull] x86 fixes, Andi Kleen, (Mon Sep 8, 3:43 pm)
Re: [git pull] x86 fixes, Krzysztof Halasa, (Mon Sep 8, 4:17 pm)
Re: [git pull] x86 fixes, Ingo Molnar, (Tue Sep 9, 12:27 am)
Re: [git pull] x86 fixes, Andi Kleen, (Tue Sep 9, 3:24 am)
Re: [git pull] x86 fixes, Linus Torvalds, (Tue Sep 9, 7:54 am)
Re: [git pull] x86 fixes, Adrian Bunk, (Tue Sep 9, 9:05 am)
Re: [git pull] x86 fixes, Linus Torvalds, (Tue Sep 9, 9:15 am)
Re: [git pull] x86 fixes, Adrian Bunk, (Tue Sep 9, 9:57 am)
Re: [git pull] x86 fixes, H. Peter Anvin, (Tue Sep 9, 10:01 am)
Re: [git pull] x86 fixes, H. Peter Anvin, (Tue Sep 9, 10:03 am)
Re: [git pull] x86 fixes, Mark Lord, (Tue Sep 9, 10:17 am)
Re: [git pull] x86 fixes, H. Peter Anvin, (Tue Sep 9, 10:19 am)
Re: [git pull] x86 fixes, Adrian Bunk, (Tue Sep 9, 10:43 am)
Re: [git pull] x86 fixes, Mark Lord, (Tue Sep 9, 10:48 am)
Re: [git pull] x86 fixes, H. Peter Anvin, (Tue Sep 9, 11:12 am)
Re: [git pull] x86 fixes, Andi Kleen, (Tue Sep 9, 11:40 am)