Re: unprivileged mounts git tree

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Serge E. Hallyn
Date: Friday, September 5, 2008 - 8:31 am

Quoting Miklos Szeredi (miklos@szeredi.hu):

Ok I should take the time to properly add these to ltp, but for now here
is the result of 15-minutes of playing around with shell scripts to do
some basic testing.

Run usermounts_root.sh as root first, then usermounts_user as a user.
Cleanup for the usermounts_root.sh side-effects is not done.

Miklos, do you have better-thought-out or more complete testcases?

-serge

=====================================================================
FILE usermounts_root.sh
=====================================================================
#!/bin/sh
MMOUNTDIR=/usr/src/mmount-0.3
MOUNT=${MMOUNTDIR}/mmount
UMOUNT=${MMOUNTIDR}/ummount

mkdir -p /mnt/shared /mnt/slave /mnt/private
mkdir /mnt/shared/d /mnt/slave/d /mnt/private/d

touch /mnt/shared/a
touch /mnt/slave/b
touch /mnt/private/c

mount --bind /mnt/shared /mnt/shared
mount --make-rshared /mnt/shared
mount --bind /mnt/shared /mnt/slave
mount --make-rslave /mnt/slave
=====================================================================


=====================================================================
FILE usermounts_user.sh
=====================================================================
#!/bin/sh
MMOUNTDIR=/usr/src/mmount-0.3
MOUNT=${MMOUNTDIR}/mmount
UMOUNT=${MMOUNTDIR}/ummount

mkdir t1

# user bind a root shared mount.  Should fail -EPERM.

$MOUNT --bind /mnt/shared t1
rc=$?
if [ $rc -eq 0 ]; then
	echo "FAIL: succeeded in user-binding a root-shared dir"
	exit 1
fi
echo "PASS: first test passed (refused to user-bind a root-shared dir"

# user bind a root shared mount, then bind into there.  Make sure
# that the two binds work, and the second is not propagated to the
# first

$MOUNT --bind /mnt/slave t1
$MOUNT --bind /mnt/private t1/d
if [ ! -f t1/d/c ]; then
	echo "failed mounting private under slave/d"
	exit 1
fi
if [ -f /mnt/slave/d/c ]; then
	echo "user mount of private under slave/d was propagated to /mnt/slave!"
	exit 1
fi
if [ -f /mnt/shared/d/c ]; then
	echo "user mount of private under slave/d was propagated to /mnt/shared!"
	exit 1
fi

ret=0
$UMOUNT t1/d || ret=1
$UMOUNT t1 || ret=1
if [ $ret -eq 1 ]; then
	echo "user umount refused in second test"
	exit 1
fi
if [ -f t1/a ]; then
	echo "user umount failed in second test"
	exit 1
fi

rmdir t1

echo "PASS: second test passed (user-mounts of root-slave and root-private dirs)"

# bind mount /etc/shadow.  First make sure that we cannot read
# /etc/shadow and can read the target.  Then make sure that we
# can no longer read the target after the bind mount.

cat /etc/shadow >> /dev/null
rc=$?
if [ $rc -eq 0 ]; then
	echo "test 3: Oh no, I'm able to read /etc/shadow!"
	exit 1
fi
echo ab > t1
cat t1 >> /dev/null
rc=$?
if [ $rc -ne 0 ]; then
	echo "test 3: Odd, couldn't read my own file."
	exit 1
fi
$MOUNT --bind /etc/shadow t1
cat t1 >> /dev/null
rc=$?
if [ $rc -eq 0 ]; then
	echo "test 3: bind mount of /etc/shadow gave me read access!"
	exit 1
fi
$UMOUNT t1
rm t1

echo "PASS: third test passed (user mount of file)"

echo "all tests succeeded"
exit 0
=====================================================================
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
unprivileged mounts git tree, Miklos Szeredi, (Wed May 7, 5:05 am)
Re: unprivileged mounts git tree, Serge E. Hallyn, (Thu Aug 7, 3:27 pm)
Re: unprivileged mounts git tree, Eric W. Biederman, (Thu Aug 7, 5:07 pm)
Re: unprivileged mounts git tree, Serge E. Hallyn, (Thu Aug 7, 5:25 pm)
Re: unprivileged mounts git tree, Miklos Szeredi, (Mon Aug 25, 4:01 am)
Re: unprivileged mounts git tree, Serge E. Hallyn, (Wed Aug 27, 8:36 am)
Re: unprivileged mounts git tree, Miklos Szeredi, (Wed Aug 27, 8:55 am)
Re: unprivileged mounts git tree, Serge E. Hallyn, (Wed Aug 27, 11:46 am)
Re: unprivileged mounts git tree, Miklos Szeredi, (Wed Sep 3, 11:45 am)
Re: unprivileged mounts git tree, Serge E. Hallyn, (Wed Sep 3, 2:54 pm)
Re: unprivileged mounts git tree, Serge E. Hallyn, (Wed Sep 3, 3:02 pm)
Re: unprivileged mounts git tree, Miklos Szeredi, (Wed Sep 3, 3:25 pm)
Re: unprivileged mounts git tree, Serge E. Hallyn, (Wed Sep 3, 3:43 pm)
Re: unprivileged mounts git tree, Miklos Szeredi, (Wed Sep 3, 11:42 pm)
Re: unprivileged mounts git tree, Serge E. Hallyn, (Thu Sep 4, 6:28 am)
Re: unprivileged mounts git tree, Miklos Szeredi, (Thu Sep 4, 7:06 am)
Re: unprivileged mounts git tree, Miklos Szeredi, (Thu Sep 4, 8:40 am)
Re: unprivileged mounts git tree, Serge E. Hallyn, (Thu Sep 4, 9:17 am)
Re: unprivileged mounts git tree, Miklos Szeredi, (Thu Sep 4, 10:42 am)
Re: unprivileged mounts git tree, Serge E. Hallyn, (Thu Sep 4, 10:48 am)
Re: unprivileged mounts git tree, Miklos Szeredi, (Thu Sep 4, 11:03 am)
Re: unprivileged mounts git tree, Serge E. Hallyn, (Thu Sep 4, 11:49 am)
Re: unprivileged mounts git tree, Miklos Szeredi, (Thu Sep 4, 3:26 pm)
Re: unprivileged mounts git tree, Serge E. Hallyn, (Thu Sep 4, 4:32 pm)
Re: unprivileged mounts git tree, Serge E. Hallyn, (Fri Sep 5, 8:31 am)
Re: unprivileged mounts git tree, Miklos Szeredi, (Tue Sep 9, 6:34 am)
Re: unprivileged mounts git tree, Eric W. Biederman, (Thu Sep 11, 3:37 am)
Re: unprivileged mounts git tree, Miklos Szeredi, (Thu Sep 11, 7:43 am)
Re: unprivileged mounts git tree, Serge E. Hallyn, (Thu Sep 11, 8:20 am)
Re: unprivileged mounts git tree, Miklos Szeredi, (Thu Sep 11, 8:44 am)
Re: unprivileged mounts git tree, Eric W. Biederman, (Thu Sep 11, 11:54 am)
Re: unprivileged mounts git tree, Eric W. Biederman, (Thu Sep 11, 12:04 pm)
Re: unprivileged mounts git tree, Eric W. Biederman, (Thu Sep 11, 12:58 pm)
Re: unprivileged mounts git tree, Serge E. Hallyn, (Fri Sep 12, 3:08 pm)
Re: unprivileged mounts git tree, Eric W. Biederman, (Fri Sep 12, 8:12 pm)
Re: unprivileged mounts git tree, Serge E. Hallyn, (Sat Sep 13, 6:56 pm)
Re: unprivileged mounts git tree, Eric W. Biederman, (Sat Sep 13, 8:06 pm)
Re: unprivileged mounts git tree, Serge E. Hallyn, (Tue Sep 30, 12:39 pm)
Re: unprivileged mounts git tree, Miklos Szeredi, (Mon Oct 6, 4:05 am)