Re: [PATCH] rfkill: update LEDs for all state changes

view
thread

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Larry Finger

Subject: Re: [PATCH] rfkill: update LEDs for all state changes

Date: Thursday, September 18, 2008 - 6:09 am

Henrique de Moraes Holschuh wrote:
quoted text> 
> Curious.  My patch to rfkill WAS tested, and it DOES fix the same issue you
> reported (hardware state changes to HARD_BLOCKED do not update the LEDs) in
> thinkpad-acpi.  It is also an "obviously correct" patch.
> 
> What this probably means is that b43 would need a little more rfkill surgery
> than what Matthew's patch already did.  I will look over Matthew's patch,
> but my guess is that Michael's comments about the need to add some extra
> code to b43 to actually synthesize the rfkill state from the separate HW and
> SW rfkill input lines are a strong hint of where the problem might be.

You must have missed my mail that shows the corrected patch for b43.
See http://marc.info/?l=linux-wireless&m=122171448920267&w=2.

Larry


--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

Regression in 2.6.27-rcX caused by commit bc19d6e0b74ef03a ..., Larry Finger, (Tue Sep 16, 7:18 am)

Re: Regression in 2.6.27-rcX caused by commit bc19d6e0b74e ..., Michael Buesch, (Tue Sep 16, 8:42 am)

Re: Regression in 2.6.27-rcX caused by commit bc19d6e0b74e ..., Larry Finger, (Tue Sep 16, 10:08 am)

Re: Regression in 2.6.27-rcX caused by commit bc19d6e0b74e ..., Carlos Corbacho, (Tue Sep 16, 12:18 pm)

Re: Regression in 2.6.27-rcX caused by commit bc19d6e0b74e ..., Michael Buesch, (Tue Sep 16, 12:25 pm)

Re: Regression in 2.6.27-rcX caused by commit bc19d6e0b74e ..., Larry Finger, (Tue Sep 16, 12:30 pm)

Re: Regression in 2.6.27-rcX caused by commit bc19d6e0b74e ..., Matthew Garrett, (Tue Sep 16, 12:51 pm)

Re: Regression in 2.6.27-rcX caused by commit bc19d6e0b74e ..., Larry Finger, (Tue Sep 16, 1:34 pm)

Re: Regression in 2.6.27-rcX caused by commit bc19d6e ..., Carlos Corbacho, (Tue Sep 16, 1:44 pm)

Re: Regression in 2.6.27-rcX caused by commit bc19d6e ..., Larry Finger, (Tue Sep 16, 2:07 pm)

Re: Regression in 2.6.27-rcX caused by commit bc19d6e0b74e ..., Matthew Garrett, (Tue Sep 16, 2:09 pm)

Re: Regression in 2.6.27-rcX caused by commit bc19d6e0b74e ..., Henrique de Moraes H ..., (Tue Sep 16, 3:37 pm)

Re: Regression in 2.6.27-rcX caused by commit bc19d6e0b74e ..., Henrique de Moraes H ..., (Tue Sep 16, 3:40 pm)

Re: Regression in 2.6.27-rcX caused by commit bc19d6e0b74e ..., Matthew Garrett, (Tue Sep 16, 4:32 pm)

Re: Regression in 2.6.27-rcX caused by commit bc19d6e0b74e ..., Henrique de Moraes H ..., (Tue Sep 16, 7:33 pm)

Re: Regression in 2.6.27-rcX caused by commit bc19d6e0b74e ..., Larry Finger, (Tue Sep 16, 7:52 pm)

Re: Regression in 2.6.27-rcX caused by commit bc19d6e0b74e ..., John W. Linville, (Wed Sep 17, 6:23 am)

Re: Regression in 2.6.27-rcX caused by commit bc19d6e0b74e ..., Michael Buesch, (Wed Sep 17, 7:19 am)

Re: Regression in 2.6.27-rcX caused by commit bc19d6e0b74e ..., Michael Buesch, (Wed Sep 17, 7:22 am)

Re: Regression in 2.6.27-rcX caused by commit bc19d6e0b74e ..., Michael Buesch, (Wed Sep 17, 7:26 am)

Re: Regression in 2.6.27-rcX caused by commit bc19d6e0b74e ..., John W. Linville, (Wed Sep 17, 7:29 am)

Re: Regression in 2.6.27-rcX caused by commit bc19d6e0b74e ..., Michael Buesch, (Wed Sep 17, 7:33 am)

Re: Regression in 2.6.27-rcX caused by commit bc19d6e0b74e ..., Henrique de Moraes H ..., (Wed Sep 17, 7:50 am)

Re: Regression in 2.6.27-rcX caused by commit bc19d6e0b74e ..., Henrique de Moraes H ..., (Wed Sep 17, 8:18 am)

Re: Regression in 2.6.27-rcX caused by commit bc19d6e0b74e ..., Larry Finger, (Wed Sep 17, 8:28 am)

Re: Regression in 2.6.27-rcX caused by commit bc19d6e0b74e ..., Henrique de Moraes H ..., (Wed Sep 17, 8:36 am)

Re: Regression in 2.6.27-rcX caused by commit bc19d6e0b74e ..., Larry Finger, (Wed Sep 17, 8:47 am)

Re: Regression in 2.6.27-rcX caused by commit bc19d6e0b74e ..., Michael Buesch, (Wed Sep 17, 8:59 am)

[PATCH] rfkill: update LEDs for all state changes, Henrique de Moraes H ..., (Wed Sep 17, 1:07 pm)

Re: [PATCH] rfkill: update LEDs for all state changes, Larry Finger, (Wed Sep 17, 1:55 pm)

Re: [PATCH] rfkill: update LEDs for all state changes, Henrique de Moraes H ..., (Thu Sep 18, 5:43 am)

Re: [PATCH] rfkill: update LEDs for all state changes, Ivo van Doorn, (Thu Sep 18, 5:49 am)

Re: [PATCH] rfkill: update LEDs for all state changes, Larry Finger, (Thu Sep 18, 6:09 am)

Re: [PATCH] rfkill: update LEDs for all state changes, Henrique de Moraes H ..., (Thu Sep 18, 6:18 am)