[PATCHv2 12/28] aic94xx: treat firmware data as const

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: David Woodhouse
Date: Sunday, May 25, 2008 - 3:23 am

Signed-off-by: David Woodhouse <dwmw2@infradead.org>
---
 drivers/scsi/aic94xx/aic94xx_sds.c |   12 ++++++------
 drivers/scsi/aic94xx/aic94xx_sds.h |    4 ++--
 drivers/scsi/aic94xx/aic94xx_seq.c |    7 ++++---
 3 files changed, 12 insertions(+), 11 deletions(-)

diff --git a/drivers/scsi/aic94xx/aic94xx_sds.c b/drivers/scsi/aic94xx/aic94xx_sds.c
index 4446e3d..8630a75 100644
--- a/drivers/scsi/aic94xx/aic94xx_sds.c
+++ b/drivers/scsi/aic94xx/aic94xx_sds.c
@@ -1093,9 +1093,9 @@ out:
  * @bytes_to_verify: total bytes to verify
  */
 int asd_verify_flash_seg(struct asd_ha_struct *asd_ha,
-		void *src, u32 dest_offset, u32 bytes_to_verify)
+			 const void *src, u32 dest_offset, u32 bytes_to_verify)
 {
-	u8 *src_buf;
+	const u8 *src_buf;
 	u8 flash_char;
 	int err;
 	u32 nv_offset, reg, i;
@@ -1105,7 +1105,7 @@ int asd_verify_flash_seg(struct asd_ha_struct *asd_ha,
 
 	err = FLASH_OK;
 	nv_offset = dest_offset;
-	src_buf = (u8 *)src;
+	src_buf = (const u8 *)src;
 	for (i = 0; i < bytes_to_verify; i++) {
 		flash_char = asd_read_reg_byte(asd_ha, reg + nv_offset + i);
 		if (flash_char != src_buf[i]) {
@@ -1124,9 +1124,9 @@ int asd_verify_flash_seg(struct asd_ha_struct *asd_ha,
  * @bytes_to_write: total bytes to write
  */
 int asd_write_flash_seg(struct asd_ha_struct *asd_ha,
-		void *src, u32 dest_offset, u32 bytes_to_write)
+			const void *src, u32 dest_offset, u32 bytes_to_write)
 {
-	u8 *src_buf;
+	const u8 *src_buf;
 	u32 nv_offset, reg, i;
 	int err;
 
@@ -1153,7 +1153,7 @@ int asd_write_flash_seg(struct asd_ha_struct *asd_ha,
 		return err;
 	}
 
-	src_buf = (u8 *)src;
+	src_buf = (const u8 *)src;
 	for (i = 0; i < bytes_to_write; i++) {
 		/* Setup program command sequence */
 		switch (asd_ha->hw_prof.flash.method) {
diff --git a/drivers/scsi/aic94xx/aic94xx_sds.h b/drivers/scsi/aic94xx/aic94xx_sds.h
index bb9795a..a06dc01 100644
--- a/drivers/scsi/aic94xx/aic94xx_sds.h
+++ b/drivers/scsi/aic94xx/aic94xx_sds.h
@@ -110,9 +110,9 @@ struct bios_file_header {
 };
 
 int asd_verify_flash_seg(struct asd_ha_struct *asd_ha,
-		void *src, u32 dest_offset, u32 bytes_to_verify);
+		const void *src, u32 dest_offset, u32 bytes_to_verify);
 int asd_write_flash_seg(struct asd_ha_struct *asd_ha,
-		void *src, u32 dest_offset, u32 bytes_to_write);
+		const void *src, u32 dest_offset, u32 bytes_to_write);
 int asd_chk_write_status(struct asd_ha_struct *asd_ha,
 		u32 sector_addr, u8 erase_flag);
 int asd_check_flash_type(struct asd_ha_struct *asd_ha);
diff --git a/drivers/scsi/aic94xx/aic94xx_seq.c b/drivers/scsi/aic94xx/aic94xx_seq.c
index f4272ac..8f98e33 100644
--- a/drivers/scsi/aic94xx/aic94xx_seq.c
+++ b/drivers/scsi/aic94xx/aic94xx_seq.c
@@ -46,7 +46,7 @@
 static const struct firmware *sequencer_fw;
 static u16 cseq_vecs[CSEQ_NUM_VECS], lseq_vecs[LSEQ_NUM_VECS], mode2_task,
 	cseq_idle_loop, lseq_idle_loop;
-static u8 *cseq_code, *lseq_code;
+static const u8 *cseq_code, *lseq_code;
 static u32 cseq_code_size, lseq_code_size;
 
 static u16 first_scb_site_no = 0xFFFF;
@@ -1235,7 +1235,8 @@ int asd_release_firmware(void)
 static int asd_request_firmware(struct asd_ha_struct *asd_ha)
 {
 	int err, i;
-	struct sequencer_file_header header, *hdr_ptr;
+	struct sequencer_file_header header;
+	const struct sequencer_file_header *hdr_ptr;
 	u32 csum = 0;
 	u16 *ptr_cseq_vecs, *ptr_lseq_vecs;
 
@@ -1249,7 +1250,7 @@ static int asd_request_firmware(struct asd_ha_struct *asd_ha)
 	if (err)
 		return err;
 
-	hdr_ptr = (struct sequencer_file_header *)sequencer_fw->data;
+	hdr_ptr = (const struct sequencer_file_header *)sequencer_fw->data;
 
 	header.csum = le32_to_cpu(hdr_ptr->csum);
 	header.major = le32_to_cpu(hdr_ptr->major);
-- 
1.5.4.5

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCHv2 01/28] libertas: treat firmware data as const, David Woodhouse, (Sun May 25, 3:23 am)
[PATCHv2 02/28] bluetooth: treat firmware data as const, David Woodhouse, (Sun May 25, 3:23 am)
[PATCHv2 03/28] cyclades: treat firmware data as const, David Woodhouse, (Sun May 25, 3:23 am)
[PATCHv2 04/28] cx25840: treat firmware data as const, David Woodhouse, (Sun May 25, 3:23 am)
[PATCHv2 05/28] myri10ge: treat firmware data as const, David Woodhouse, (Sun May 25, 3:23 am)
[PATCHv2 06/28] vx222: treat firmware data as const, David Woodhouse, (Sun May 25, 3:23 am)
[PATCHv2 07/28] riptide: treat firmware data as const, David Woodhouse, (Sun May 25, 3:23 am)
[PATCHv2 08/28] pcxhr: treat firmware data as const, David Woodhouse, (Sun May 25, 3:23 am)
[PATCHv2 09/28] vx: treat firmware data as const, David Woodhouse, (Sun May 25, 3:23 am)
[PATCHv2 10/28] ueagle-atm: treat firmware data as const, David Woodhouse, (Sun May 25, 3:23 am)
[PATCHv2 11/28] cxacru: treat firmware data as const, David Woodhouse, (Sun May 25, 3:23 am)
[PATCHv2 12/28] aic94xx: treat firmware data as const, David Woodhouse, (Sun May 25, 3:23 am)
[PATCHv2 13/28] zd1201: treat firmware data as const, David Woodhouse, (Sun May 25, 3:23 am)
[PATCHv2 14/28] rt2x00: treat firmware data as const, David Woodhouse, (Sun May 25, 3:23 am)
[PATCHv2 15/28] p54: treat firmware data as const, David Woodhouse, (Sun May 25, 3:23 am)
[PATCHv2 16/28] atmel: treat firmware data as const, David Woodhouse, (Sun May 25, 3:23 am)
[PATCHv2 17/28] irda-usb: treat firmware data as const, David Woodhouse, (Sun May 25, 3:23 am)
[PATCHv2 18/28] cxgb3: treat firmware data as const, David Woodhouse, (Sun May 25, 3:23 am)
[PATCHv2 19/28] bt8xx: treat firmware data as const, David Woodhouse, (Sun May 25, 3:23 am)
[PATCHv2 20/28] ttusb-dec: treat firmware data as const, David Woodhouse, (Sun May 25, 3:23 am)
[PATCHv2 21/28] dvb frontends: treat firmware data as const, David Woodhouse, (Sun May 25, 3:23 am)
[PATCHv2 22/28] cxusb: treat firmware data as const, David Woodhouse, (Sun May 25, 3:23 am)
[PATCHv2 23/28] gp8psk: treat firmware data as const, David Woodhouse, (Sun May 25, 3:23 am)
[PATCHv2 24/28] tuners: treat firmware data as const, David Woodhouse, (Sun May 25, 3:23 am)
[PATCHv2 25/28] firmware: make fw-&gt;data const, David Woodhouse, (Sun May 25, 3:23 am)
[PATCHv2 27/28] firmware: Add CONFIG_BUILTIN_FIRMWARE option, David Woodhouse, (Sun May 25, 3:23 am)
Re: [PATCHv2 22/28] cxusb: treat firmware data as const, Michael Krufky, (Sun May 25, 7:14 am)
Re: [PATCHv2 22/28] cxusb: treat firmware data as const, David Woodhouse, (Sun May 25, 7:27 am)
Re: [PATCHv2 04/28] cx25840: treat firmware data as const, David Woodhouse, (Sun May 25, 7:36 am)
Re: [PATCHv2 04/28] cx25840: treat firmware data as const, David Woodhouse, (Sun May 25, 7:56 am)
Re: [PATCHv2 22/28] cxusb: treat firmware data as const, David Woodhouse, (Sun May 25, 8:02 am)
Re: [PATCHv2 04/28] cx25840: treat firmware data as const, Tyler Trafford, (Sun May 25, 9:16 am)
[PATCHv3 27/28] firmware: Add CONFIG_BUILTIN_FIRMWARE option, David Woodhouse, (Sun May 25, 10:00 am)
[PATCH 29/28] firmware: Add 'firmware_install' make target, David Woodhouse, (Thu May 29, 1:29 am)
[PATCHv2 #ERROR!/28] maestro3: treat firmware data as const, David Woodhouse, (Thu May 29, 2:09 am)
[PATCH N/28] ymfpci: treat firmware data as const, David Woodhouse, (Thu May 29, 5:21 am)
[PATCH] smctr: use request_firmware(), David Woodhouse, (Thu May 29, 6:47 am)
[PATCH] kaweth: use request_firmware(), David Woodhouse, (Thu May 29, 7:20 am)
[PATCH] ttusb-budget: use request_firmware(), David Woodhouse, (Thu May 29, 10:49 am)
Re: [PATCH] smctr: use request_firmware(), maximilian attems, (Thu May 29, 12:30 pm)
Re: [PATCH] smctr: use request_firmware(), David Woodhouse, (Thu May 29, 2:02 pm)
[PATCH] keyspan: use request_firmware(), David Woodhouse, (Fri May 30, 4:45 am)
[PATCH] keyspan_pda: use request_firmware(), David Woodhouse, (Fri May 30, 5:19 am)
Re: [PATCH] keyspan: use request_firmware(), Hugh Blemings, (Fri May 30, 6:54 am)
Re: [PATCH] kaweth: use request_firmware(), Oliver Neukum, (Fri May 30, 6:55 am)
Re: [PATCH] kaweth: use request_firmware(), David Woodhouse, (Fri May 30, 8:16 am)
Re: [PATCH] kaweth: use request_firmware(), Marcel Holtmann, (Fri May 30, 8:26 am)
Re: [PATCH] kaweth: use request_firmware(), Alan Cox, (Fri May 30, 8:48 am)
Re: [PATCH] kaweth: use request_firmware(), Oliver Neukum, (Fri May 30, 2:02 pm)
Re: [PATCH] kaweth: use request_firmware(), Alexandre Oliva, (Fri May 30, 5:00 pm)
Re: [PATCH] kaweth: use request_firmware(), Marcel Holtmann, (Fri May 30, 11:51 pm)
Re: [PATCH] kaweth: use request_firmware(), Alan Cox, (Sat May 31, 5:35 am)
Re: [PATCH] ttusb-budget: use request_firmware(), Mauro Carvalho Chehab, (Fri Jun 13, 12:23 pm)