Re: [PATCH] xfs: remove unused params from functions in xfs/quota/* | KernelTrap

Re: [PATCH] xfs: remove unused params from functions in xfs/quota/*

view
thread

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: David Chinner

Subject: Re: [PATCH] xfs: remove unused params from functions in xfs/quota/*

Date: Tuesday, April 22, 2008 - 4:08 pm

On Tue, Apr 22, 2008 at 03:40:12PM +0200, Denys Vlasenko wrote:
quoted text> Hi David,
> 
> This patch deals with remaining cases of unused parameters in fs/xfs/quota/*
> as far as I can see so far. The rest of unused parameters
> in fs/xfs/quota/* cannot be easily eliminated due to addresses
> of functions being taken.

I'd just kill the parameters to xfs_qm_hold_quotafs_ref and
xfs_qm_rele_quotafs_ref and I wouldn't worry about removingthe debug-only
id parameter to xfs_qm_dqread as it's not in a stack critical path.

Cheers,

Dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group
--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

Re: x86: 4kstacks default, Andrew Morton, (Fri Apr 18, 2:29 pm)

Re: x86: 4kstacks default, Ingo Molnar, (Sat Apr 19, 7:23 am)

Re: x86: 4kstacks default, Oliver Pinter, (Sat Apr 19, 7:35 am)

Re: x86: 4kstacks default, Shawn Bohrer, (Sat Apr 19, 7:59 am)

Re: x86: 4kstacks default, Adrian Bunk, (Sat Apr 19, 8:19 am)

Re: x86: 4kstacks default, Oliver Pinter, (Sat Apr 19, 8:42 am)

Re: x86: 4kstacks default, Andrew Morton, (Sat Apr 19, 10:49 am)

Re: x86: 4kstacks default, Arjan van de Ven, (Sat Apr 19, 11:00 am)

Re: x86: 4kstacks default, Ingo Molnar, (Sat Apr 19, 11:33 am)

Re: x86: 4kstacks default, Stefan Richter, (Sat Apr 19, 12:10 pm)

Re: x86: 4kstacks default, Eric Sandeen, (Sat Apr 19, 6:56 pm)

Re: x86: 4kstacks default, Eric Sandeen, (Sat Apr 19, 7:36 pm)

Re: x86: 4kstacks default, Eric Sandeen, (Sat Apr 19, 8:29 pm)

Re: x86: 4kstacks default, Arjan van de Ven, (Sat Apr 19, 11:11 pm)

Re: x86: 4kstacks default, Adrian Bunk, (Sun Apr 20, 12:42 am)

Re: x86: 4kstacks default, Alan Cox, (Sun Apr 20, 1:06 am)

Re: x86: 4kstacks default, Adrian Bunk, (Sun Apr 20, 1:09 am)

Re: x86: 4kstacks default, Adrian Bunk, (Sun Apr 20, 1:51 am)

Re: x86: 4kstacks default, Alan Cox, (Sun Apr 20, 2:36 am)

Re: x86: 4kstacks default, Adrian Bunk, (Sun Apr 20, 3:44 am)

Re: x86: 4kstacks default, Alan Cox, (Sun Apr 20, 4:02 am)

Re: x86: 4kstacks default, Alan Cox, (Sun Apr 20, 4:37 am)

Re: x86: 4kstacks default, Adrian Bunk, (Sun Apr 20, 4:54 am)

Re: x86: 4kstacks default, Adrian Bunk, (Sun Apr 20, 5:18 am)

Re: x86: 4kstacks default, Andi Kleen, (Sun Apr 20, 5:27 am)

Re: x86: 4kstacks default, Adrian Bunk, (Sun Apr 20, 5:32 am)

Re: x86: 4kstacks default, Andi Kleen, (Sun Apr 20, 5:36 am)

Re: x86: 4kstacks default, Andi Kleen, (Sun Apr 20, 5:37 am)

Re: x86: 4kstacks default, Willy Tarreau, (Sun Apr 20, 5:47 am)

Re: x86: 4kstacks default, Andi Kleen, (Sun Apr 20, 6:06 am)

Re: x86: 4kstacks default, Adrian Bunk, (Sun Apr 20, 6:21 am)

Re: x86: 4kstacks default, Mark Lord, (Sun Apr 20, 6:22 am)

Re: x86: 4kstacks default, Mark Lord, (Sun Apr 20, 6:27 am)

Re: x86: 4kstacks default, Adrian Bunk, (Sun Apr 20, 6:30 am)

Re: x86: 4kstacks default, Willy Tarreau, (Sun Apr 20, 6:34 am)

Re: x86: 4kstacks default, Willy Tarreau, (Sun Apr 20, 6:38 am)

Re: x86: 4kstacks default, Adrian Bunk, (Sun Apr 20, 7:04 am)

Re: x86: 4kstacks default, Eric Sandeen, (Sun Apr 20, 7:05 am)

Re: x86: 4kstacks default, Eric Sandeen, (Sun Apr 20, 7:09 am)

Re: x86: 4kstacks default, Andi Kleen, (Sun Apr 20, 7:19 am)

Re: x86: 4kstacks default, Willy Tarreau, (Sun Apr 20, 7:20 am)

Re: x86: 4kstacks default, Adrian Bunk, (Sun Apr 20, 7:21 am)

Re: x86: 4kstacks default, Eric Sandeen, (Sun Apr 20, 7:40 am)

Re: x86: 4kstacks default, Eric Sandeen, (Sun Apr 20, 7:56 am)

Re: x86: 4kstacks default, Arjan van de Ven, (Sun Apr 20, 8:41 am)

Re: x86: 4kstacks default, Daniel Hazelton, (Sun Apr 20, 8:44 am)

Re: x86: 4kstacks default, Adrian Bunk, (Sun Apr 20, 9:03 am)

Re: x86: 4kstacks default, Jörn, (Sun Apr 20, 9:41 am)

Re: x86: 4kstacks default, Chris Wedgwood, (Sun Apr 20, 9:59 am)

Re: x86: 4kstacks default, Andi Kleen, (Sun Apr 20, 10:19 am)

Re: x86: 4kstacks default, Andi Kleen, (Sun Apr 20, 10:26 am)

Re: x86: 4kstacks default, Jörn, (Sun Apr 20, 10:43 am)

Re: x86: 4kstacks default, Andi Kleen, (Sun Apr 20, 11:19 am)

Re: x86: 4kstacks default, Arjan van de Ven, (Sun Apr 20, 11:48 am)

Re: x86: 4kstacks default, Arjan van de Ven, (Sun Apr 20, 11:50 am)

Re: x86: 4kstacks default, Andi Kleen, (Sun Apr 20, 1:01 pm)

Re: x86: 4kstacks default, Andi Kleen, (Sun Apr 20, 1:09 pm)

Re: x86: 4kstacks default, Jörn, (Sun Apr 20, 1:32 pm)

Re: x86: 4kstacks default, Jörn, (Sun Apr 20, 1:35 pm)

Re: x86: 4kstacks default, Daniel Hazelton, (Sun Apr 20, 1:43 pm)

Re: x86: 4kstacks default, Andi Kleen, (Sun Apr 20, 2:40 pm)

Re: x86: 4kstacks default, Andrew Morton, (Sun Apr 20, 2:45 pm)

Re: x86: 4kstacks default, Andrew Morton, (Sun Apr 20, 2:50 pm)

Re: x86: 4kstacks default, Andi Kleen, (Sun Apr 20, 2:51 pm)

Re: x86: 4kstacks default, Andi Kleen, (Sun Apr 20, 2:55 pm)

Re: x86: 4kstacks default, Bernd Eckenfels, (Sun Apr 20, 3:17 pm)

Re: x86: 4kstacks default, Arjan van de Ven, (Sun Apr 20, 3:33 pm)

Re: x86: 4kstacks default, Arjan van de Ven, (Sun Apr 20, 3:33 pm)

Re: x86: 4kstacks default, David Chinner, (Sun Apr 20, 3:53 pm)

Re: x86: 4kstacks default, Andi Kleen, (Sun Apr 20, 4:16 pm)

Re: x86: 4kstacks default, Avi Kivity, (Sun Apr 20, 4:48 pm)

Re: x86: 4kstacks default, Daniel Hazelton, (Sun Apr 20, 6:45 pm)

Re: x86: 4kstacks default, Eric Sandeen, (Sun Apr 20, 8:06 pm)

Re: x86: 4kstacks default, Alexander E. Patrakov, (Sun Apr 20, 8:30 pm)

Re: x86: 4kstacks default, Arjan van de Ven, (Sun Apr 20, 10:53 pm)

Re: x86: 4kstacks default, Denys Vlasenko, (Mon Apr 21, 12:45 am)

Re: x86: 4kstacks default, Andi Kleen, (Mon Apr 21, 12:51 am)

Re: x86: 4kstacks default, Andi Kleen, (Mon Apr 21, 2:55 am)

Re: x86: 4kstacks default, Eric Sandeen, (Mon Apr 21, 6:29 am)

Re: x86: 4kstacks default, Ingo Molnar, (Mon Apr 21, 7:29 am)

Re: x86: 4kstacks default, Ingo Molnar, (Mon Apr 21, 7:31 am)

Re: x86: 4kstacks default, Daniel Hazelton, (Mon Apr 21, 10:34 am)

Re: x86: 4kstacks default, Denys Vlasenko, (Mon Apr 21, 12:51 pm)

Re: x86: 4kstacks default, Denys Vlasenko, (Mon Apr 21, 1:28 pm)

Re: x86: 4kstacks default, David Chinner, (Mon Apr 21, 6:28 pm)

[PATCH] xfs: do not pass size into kmem_free, it's unused, Denys Vlasenko, (Mon Apr 21, 7:33 pm)

[PATCH] xfs: do not pass unused params to xfs_flush_pages, Denys Vlasenko, (Mon Apr 21, 8:03 pm)

Re: [PATCH] xfs: do not pass size into kmem_free, it's unused, Eric Sandeen, (Mon Apr 21, 8:09 pm)

[PATCH] xfs: use smaller int param in call to xfs_flush_pages, Denys Vlasenko, (Mon Apr 21, 8:14 pm)

Re: [PATCH] xfs: do not pass unused params to xfs_flush_pages, Eric Sandeen, (Mon Apr 21, 8:15 pm)

Re: [PATCH] xfs: use smaller int param in call to xfs_flus ..., Eric Sandeen, (Mon Apr 21, 8:18 pm)

Re: [PATCH] xfs: do not pass size into kmem_free, it's unused, Eric Sandeen, (Mon Apr 21, 8:35 pm)

Re: [PATCH] xfs: use smaller int param in call to xfs_flus ..., David Chinner, (Mon Apr 21, 9:10 pm)

Re: [PATCH] xfs: do not pass unused params to xfs_flush_pages, Denys Vlasenko, (Tue Apr 22, 1:57 am)

[PATCH] xfs: remove unused parameter of xfs_qm_dqpurge, Denys Vlasenko, (Tue Apr 22, 2:42 am)

Re: [PATCH] xfs: do not pass unused params to xfs_flush_pages, Jakub Jelinek, (Tue Apr 22, 2:56 am)

[PATCH] xfs: remove unused parameter of xfs_iomap_write_al ..., Denys Vlasenko, (Tue Apr 22, 3:16 am)

Re: [PATCH] xfs: do not pass unused params to xfs_flush_pages, Denys Vlasenko, (Tue Apr 22, 3:33 am)

Re: [PATCH] xfs: #define out unused parameters of xfs_bmap ..., Denys Vlasenko, (Tue Apr 22, 4:20 am)

[PATCH] xfs: #define out unused parameters for seven funct ..., Denys Vlasenko, (Tue Apr 22, 4:48 am)

[PATCH] xfs: #define out unused parameters for seven funct ..., Denys Vlasenko, (Tue Apr 22, 4:51 am)

Re: x86: 4kstacks default, Denys Vlasenko, (Tue Apr 22, 5:48 am)

Re: [PATCH] xfs: do not pass unused params to xfs_flush_pages, Eric Sandeen, (Tue Apr 22, 5:51 am)

Re: x86: 4kstacks default, Adrian Bunk, (Tue Apr 22, 6:01 am)

[PATCH] xfs: remove unused params from functions in xfs_di ..., Denys Vlasenko, (Tue Apr 22, 6:32 am)

[PATCH] xfs: remove unused params from functions in xfs/qu ..., Denys Vlasenko, (Tue Apr 22, 6:40 am)

[PATCH] xfs: expose no-op xfs_put_perag(), Denys Vlasenko, (Tue Apr 22, 6:46 am)

Re: x86: 4kstacks default, Denys Vlasenko, (Tue Apr 22, 6:51 am)

Re: [PATCH] xfs: expose no-op xfs_put_perag(), Eric Sandeen, (Tue Apr 22, 7:08 am)

Re: [PATCH] xfs: #define out unused parameters of xfs_bmap ..., Adrian Bunk, (Tue Apr 22, 7:28 am)

Re: [PATCH] xfs: #define out unused parameters of xfs_bmap ..., Denys Vlasenko, (Tue Apr 22, 9:17 am)

Re: [PATCH] xfs: #define out unused parameters of xfs_bmap ..., Adrian Bunk, (Tue Apr 22, 10:21 am)

Re: [PATCH] xfs: #define out unused parameters of xfs_bmap ..., Eric Sandeen, (Tue Apr 22, 10:26 am)

Re: [PATCH] xfs: #define out unused parameters , Denys Vlasenko, (Tue Apr 22, 10:50 am)

Re: x86: 4kstacks default, Romano Giannetti, (Tue Apr 22, 11:20 am)

Re: [PATCH] xfs: #define out unused parameters of?xfs_bmap ..., Adrian Bunk, (Tue Apr 22, 11:28 am)

Re: [PATCH] xfs: #define out unused parameters of?xfs_bmap ..., Denys Vlasenko, (Tue Apr 22, 12:32 pm)

Re: [PATCH] xfs: #define out unused parameters , Denys Vlasenko, (Tue Apr 22, 1:46 pm)

Re: [PATCH] xfs: do not pass size into kmem_free, it's unused, David Chinner, (Tue Apr 22, 3:02 pm)

Re: [PATCH] xfs: do not pass unused params to xfs_flush_pages, David Chinner, (Tue Apr 22, 3:07 pm)

Re: [PATCH] xfs: use smaller int param in call to xfs_flus ..., David Chinner, (Tue Apr 22, 3:08 pm)

Re: [PATCH] xfs: remove unused parameter of xfs_qm_dqpurge, David Chinner, (Tue Apr 22, 3:11 pm)

Re: [PATCH] xfs: remove unused parameter of xfs_iomap_writ ..., David Chinner, (Tue Apr 22, 3:33 pm)

Re: [PATCH] xfs: #define out unused parameters of xfs_bmap ..., David Chinner, (Tue Apr 22, 3:43 pm)

Re: [PATCH] xfs: #define out unused parameters for seven f ..., David Chinner, (Tue Apr 22, 3:47 pm)

Re: [PATCH] xfs: remove unused params from functions in xf ..., David Chinner, (Tue Apr 22, 4:08 pm)

Re: [PATCH] xfs: expose no-op xfs_put_perag(), David Chinner, (Tue Apr 22, 4:16 pm)

Re: [PATCH] xfs: #define out unused parameters of?xfs_bmap ..., Adrian Bunk, (Tue Apr 22, 4:53 pm)

Re: x86: 4kstacks default, Denys Vlasenko, (Tue Apr 22, 10:03 pm)

Re: x86: 4kstacks default, Daniel Hazelton, (Tue Apr 22, 10:21 pm)

Re: x86: 4kstacks default, david, (Tue Apr 22, 10:25 pm)

Re: x86: 4kstacks default, Benjamin Herrenschmidt, (Tue Apr 22, 10:27 pm)

Re: x86: 4kstacks default, Daniel Hazelton, (Tue Apr 22, 10:41 pm)

Re: x86: 4kstacks default, Romano Giannetti, (Wed Apr 23, 12:46 am)

Re: [PATCH] xfs: remove unused parameter of xfs_qm_dqpurge, Christoph Hellwig, (Wed Apr 23, 1:18 am)

Re: x86: 4kstacks default, Helge Hafting, (Wed Apr 23, 1:57 am)

Re: x86: 4kstacks default, Helge Hafting, (Wed Apr 23, 2:13 am)

Re: x86: 4kstacks default, Stefan Richter, (Wed Apr 23, 4:24 am)

Re: x86: 4kstacks default, Romano Giannetti, (Wed Apr 23, 5:15 am)

Re: x86: 4kstacks default, Lennart Sorensen, (Wed Apr 23, 8:59 am)

Re: x86: 4kstacks default, David Chinner, (Wed Apr 23, 4:29 pm)

Re: x86: 4kstacks default, David Chinner, (Wed Apr 23, 4:36 pm)

Re: x86: 4kstacks default, Arjan van de Ven, (Wed Apr 23, 5:45 pm)

Re: x86: 4kstacks default, Benjamin Herrenschmidt, (Wed Apr 23, 5:56 pm)

Re: x86: 4kstacks default, Christoph Hellwig, (Thu Apr 24, 2:52 am)

Re: x86: 4kstacks default, Peter Zijlstra, (Thu Apr 24, 5:25 am)

Re: x86: 4kstacks default, Chris Mason, (Thu Apr 24, 8:41 am)

Re: x86: 4kstacks default, Eric Sandeen, (Thu Apr 24, 8:46 am)

Re: x86: 4kstacks default, Alexander van Heukelum, (Thu Apr 24, 11:30 am)

Re: x86: 4kstacks default, Jörn, (Sun Apr 27, 12:27 pm)

Re: x86: 4kstacks default, Denys Vlasenko, (Sun Apr 27, 4:02 pm)

Re: x86: 4kstacks default, Eric Sandeen, (Sun Apr 27, 4:08 pm)

Re: x86: 4kstacks default, Denys Vlasenko, (Sun Apr 27, 5:00 pm)

Re: x86: 4kstacks default, Bill Davidsen, (Mon Apr 28, 10:56 am)

Re: x86: 4kstacks default, Bill Davidsen, (Mon Apr 28, 11:38 am)