[PATCH 24/36] Driver core: make device_is_registered() work for class devices

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Greg Kroah-Hartman
Date: Sunday, April 20, 2008 - 3:45 am

device_is_registered() can use the kobject value for this, so it will
now work with devices that are associated with only a class, not a bus
and a driver.

Cc: Kay Sievers <kay.sievers@vrfy.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
 drivers/base/bus.c     |    9 ++-------
 include/linux/device.h |    3 +--
 2 files changed, 3 insertions(+), 9 deletions(-)

diff --git a/drivers/base/bus.c b/drivers/base/bus.c
index 2d207ad..450942a 100644
--- a/drivers/base/bus.c
+++ b/drivers/base/bus.c
@@ -505,14 +505,11 @@ void bus_attach_device(struct device *dev)
 	int ret = 0;
 
 	if (bus) {
-		dev->is_registered = 1;
 		if (bus->p->drivers_autoprobe)
 			ret = device_attach(dev);
 		WARN_ON(ret < 0);
 		if (ret >= 0)
 			klist_add_tail(&dev->knode_bus, &bus->p->klist_devices);
-		else
-			dev->is_registered = 0;
 	}
 }
 
@@ -533,10 +530,8 @@ void bus_remove_device(struct device *dev)
 		sysfs_remove_link(&dev->bus->p->devices_kset->kobj,
 				  dev->bus_id);
 		device_remove_attrs(dev->bus, dev);
-		if (dev->is_registered) {
-			dev->is_registered = 0;
-			klist_del(&dev->knode_bus);
-		}
+		klist_del(&dev->knode_bus);
+
 		pr_debug("bus: '%s': remove device %s\n",
 			 dev->bus->name, dev->bus_id);
 		device_release_driver(dev);
diff --git a/include/linux/device.h b/include/linux/device.h
index d7a1ae0..441461f 100644
--- a/include/linux/device.h
+++ b/include/linux/device.h
@@ -429,7 +429,6 @@ struct device {
 	struct kobject kobj;
 	char	bus_id[BUS_ID_SIZE];	/* position on parent bus */
 	struct device_type	*type;
-	unsigned		is_registered:1;
 	unsigned		uevent_suppress:1;
 
 	struct semaphore	sem;	/* semaphore to synchronize calls to
@@ -509,7 +508,7 @@ static inline void dev_set_drvdata(struct device *dev, void *data)
 
 static inline int device_is_registered(struct device *dev)
 {
-	return dev->is_registered;
+	return dev->kobj.state_in_sysfs;
 }
 
 void driver_init(void);
-- 
1.5.4.5

--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 01/36] kobject: catch kobjects that are not initialized, Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 02/36] uio: Kconfig improvements, Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 03/36] uio: mark pci_device_id hilscher_pci_ids[] _ ..., Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 04/36] UIO: arch/arm/Kconfig: Make UIO available on ..., Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 05/36] UIO: Remove needless PCI_DEVICE_ID definitio ..., Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 06/36] UIO: Implement a UIO interface for the SMX C ..., Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 07/36] UIO: hold a reference to the device's owner ..., Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 08/36] driver core: memory: semaphore to mutex, Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 09/36] driver core: register_memory/unregister_memo ..., Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 10/36] driver core: Convert debug functions declare ..., Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 11/36] sysfs: small header file cleanup for SYSFS=n, Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 12/36] firmware: move firmware_class from Documenta ..., Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 13/36] firmware: clean up samples for coding style ..., Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 14/36] PNP: add all PNP card device id's as individ ..., Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 15/36] power_state: remove it from driver core, Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 16/36] driver core: cpu: fix section mismatch in cp ..., Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 17/36] sysdev: detect multiple driver registrations, Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 19/36] PM: Handle device registrations during suspe ..., Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 20/36] Driver core: Call device_pm_add() after bus_ ..., Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 21/36] PM: Fix misuse of wakeup flag accessors in s ..., Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 22/36] PM: Make wakeup flags available whenever CON ..., Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 23/36] PM: Convert wakeup flag accessors to inline ..., Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 24/36] Driver core: make device_is_registered() wor ..., Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 25/36] SYSFS: Explicitly include required header fi ..., Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 26/36] Kobject: Replace list_for_each() with list_f ..., Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 27/36] PM: Remove legacy PM (fix), Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 28/36] Firmware: add iSCSI iBFT Support, Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 29/36] PM: Remove destroy_suspended_device(), Greg Kroah-Hartman, (Sun Apr 20, 3:45 am)
[PATCH 30/36] sysfs: refill attribute buffer when reading ..., Greg Kroah-Hartman, (Sun Apr 20, 3:46 am)
[PATCH 31/36] driver core: replace remaining __FUNCTION__ ..., Greg Kroah-Hartman, (Sun Apr 20, 3:46 am)
[PATCH 32/36] memstick: convert struct class_device to str ..., Greg Kroah-Hartman, (Sun Apr 20, 3:46 am)
[PATCH 33/36] IB: convert struct class_device to struct device, Greg Kroah-Hartman, (Sun Apr 20, 3:46 am)
[PATCH 35/36] DRM: remove unused dev_class, Greg Kroah-Hartman, (Sun Apr 20, 3:46 am)
[PATCH 36/36] SCSI: convert struct class_device to struct ..., Greg Kroah-Hartman, (Sun Apr 20, 3:46 am)