Re: [patch] mm: sparsemem memory_present() memory corruption fix

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Ingo Molnar
Date: Tuesday, April 15, 2008 - 5:18 pm

* Ingo Molnar <mingo@elte.hu> wrote:


i re-checked the original SLAB config too and that boots fine as well 
now - so i'm confident that the regression has been sufficiently cured.

it's getting quite late here (or rather, it's getting early :-/ ) so it 
would be nice if others could double-check this calculation (with an eye 
on all possible architectures):

+       unsigned long max_arch_pfn = 1ULL << (MAX_PHYSMEM_BITS-PAGE_SHIFT);

and also check my analysis whether it is correct and whether it matches 
the reported bug patterns. But otherwise the fix looks like a safe fix 
for v2.6.25-final to me - it only filters out values from sparsemem 
input that are nonsensical in the sparsemem framework anyway.

	Ingo
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Ingo Molnar, (Mon Apr 14, 11:25 pm)
Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Pekka Enberg, (Mon Apr 14, 11:41 pm)
Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Ingo Molnar, (Tue Apr 15, 12:08 am)
Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Yinghai Lu, (Tue Apr 15, 1:31 am)
Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Ingo Molnar, (Tue Apr 15, 1:46 am)
Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Ingo Molnar, (Tue Apr 15, 2:11 am)
Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Linus Torvalds, (Tue Apr 15, 9:02 am)
Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Ingo Molnar, (Tue Apr 15, 9:15 am)
Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Linus Torvalds, (Tue Apr 15, 10:23 am)
Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Ingo Molnar, (Tue Apr 15, 12:35 pm)
Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Christoph Lameter, (Tue Apr 15, 12:39 pm)
Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Ingo Molnar, (Tue Apr 15, 12:41 pm)
Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Ingo Molnar, (Tue Apr 15, 12:54 pm)
Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Christoph Lameter, (Tue Apr 15, 1:03 pm)
Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Ingo Molnar, (Tue Apr 15, 1:17 pm)
Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Ingo Molnar, (Tue Apr 15, 1:23 pm)
Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Ingo Molnar, (Tue Apr 15, 1:28 pm)
Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Ingo Molnar, (Tue Apr 15, 1:34 pm)
Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Pekka Enberg, (Tue Apr 15, 1:34 pm)
Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Ingo Molnar, (Tue Apr 15, 1:40 pm)
Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Ingo Molnar, (Tue Apr 15, 1:42 pm)
Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Christoph Lameter, (Tue Apr 15, 1:50 pm)
Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Christoph Lameter, (Tue Apr 15, 1:54 pm)
Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Ingo Molnar, (Tue Apr 15, 1:58 pm)
Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Ingo Molnar, (Tue Apr 15, 1:58 pm)
Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Linus Torvalds, (Tue Apr 15, 2:06 pm)
Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Christoph Lameter, (Tue Apr 15, 2:08 pm)
Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Ingo Molnar, (Tue Apr 15, 2:08 pm)
Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Ingo Molnar, (Tue Apr 15, 2:13 pm)
Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Mike Travis, (Tue Apr 15, 2:16 pm)
Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Ingo Molnar, (Tue Apr 15, 2:19 pm)
Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Christoph Lameter, (Tue Apr 15, 2:21 pm)
Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Ingo Molnar, (Tue Apr 15, 2:23 pm)
Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Ingo Molnar, (Tue Apr 15, 2:24 pm)
Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Christoph Lameter, (Tue Apr 15, 2:24 pm)
Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Mike Travis, (Tue Apr 15, 2:27 pm)
Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Ingo Molnar, (Tue Apr 15, 2:28 pm)
Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Christoph Lameter, (Tue Apr 15, 2:33 pm)
Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Christoph Lameter, (Tue Apr 15, 2:42 pm)
Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Mike Travis, (Tue Apr 15, 2:43 pm)
Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Ingo Molnar, (Tue Apr 15, 2:55 pm)
Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Christoph Lameter, (Tue Apr 15, 3:06 pm)
Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Ingo Molnar, (Tue Apr 15, 3:07 pm)
Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Ingo Molnar, (Tue Apr 15, 3:13 pm)
Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Christoph Lameter, (Tue Apr 15, 3:27 pm)
Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Ingo Molnar, (Tue Apr 15, 3:32 pm)
Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Yinghai Lu, (Tue Apr 15, 4:18 pm)
Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Christoph Lameter, (Tue Apr 15, 4:22 pm)
Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Ingo Molnar, (Tue Apr 15, 4:27 pm)
Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Christoph Lameter, (Tue Apr 15, 4:32 pm)
Re: [bug] SLUB + mm/slab.c boot crash in -rc9, Christoph Lameter, (Tue Apr 15, 5:04 pm)
Re: [patch] mm: sparsemem memory_present() memory corrupti ..., Christoph Lameter, (Tue Apr 15, 5:10 pm)
Re: [patch] mm: sparsemem memory_present() memory corrupti ..., Ingo Molnar, (Tue Apr 15, 5:18 pm)
Re: [patch] mm: sparsemem memory_present() memory corrupti ..., Christoph Lameter, (Tue Apr 15, 5:19 pm)
Re: [patch] mm: sparsemem memory_present() memory corrupti ..., Christoph Lameter, (Tue Apr 15, 5:45 pm)
Re: [patch] mm: sparsemem memory_present() memory corrupti ..., Christoph Lameter, (Tue Apr 15, 5:46 pm)
Re: [patch] mm: sparsemem memory_present() memory corrupti ..., KAMEZAWA Hiroyuki, (Tue Apr 15, 6:48 pm)
Re: [patch] mm: sparsemem memory_present() memory corrupti ..., KAMEZAWA Hiroyuki, (Tue Apr 15, 7:20 pm)