Re: [patch] e1000=y && e1000e=m regression fix

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Ingo Molnar
Date: Thursday, April 10, 2008 - 12:27 pm

* Kok, Auke <auke-jan.h.kok@intel.com> wrote:


why you want to cripple an existing, rather well working and popular 
Linux driver is beyond me.

You have a wide array of measures if you want to migrate users to the 
new and shiny e1000e driver: you can stop adding _new_ IDs to the old 
driver, you can unsupport it, you can claim that it wont work in certain 
situations, you can print out messages to the user in the dmesg (if 
those messages are true), you can even remove IDs from it if the user 
has the new driver enabled.

But what you cannot do is to intentionally cripple a popular driver. 
It's plain stupid. It does not matter how many times you've announced 
it, it's still madness. Unless your goal is to reduce the Linux userbase 
as quickly as possible that is ... ;-)

And please understand: _you_ are the maintainer of this code so 
_please_, if you wish to do so, solve the problem differently, but dont 
just stand there _talking_. I gave you ample feedback about what the 
problem is (which you initially denied to even exist) and i even wrote a 
patch. You might never use e1000=y && e1000e=m or e1000=y && e1000e=n 
but i do. Guys, the ball is in your court now.


huh? How can you claim that?? It definitely solved my problem. Did you 
miss that aspect of my patch?


... and not changing existing behavior for a perfectly well working 
system is exactly what compatibility and smooth migration is about. New 
drivers need several kernel releases to be fully known, to be fully 
trusted and to be fully accepted and integrated - and not the least, to 
be fully tested ...

These are all well-known principles. It's nothing new at all and there's 
nothing special about it: dont break existing drivers and setups and 
dont create silent side-effects between drivers.

	Ingo
--
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
RE: [regression] e1000e broke e1000 (was: Re: [ANNOUNCE] e ..., Brandeburg, Jesse, (Tue Apr 8, 12:43 pm)
Re: [regression] e1000e broke e1000, Jeff Garzik, (Tue Apr 8, 12:56 pm)
Re: [regression] e1000e broke e1000, Ingo Molnar, (Tue Apr 8, 1:06 pm)
Re: [regression] e1000e broke e1000, Dan Noe, (Tue Apr 8, 1:12 pm)
showing which hardware is unclaimed, Rick Jones, (Tue Apr 8, 1:13 pm)
Re: [regression] e1000e broke e1000, Jeff Garzik, (Tue Apr 8, 1:19 pm)
Re: [regression] e1000e broke e1000, Matthew Wilcox, (Tue Apr 8, 1:20 pm)
Re: [regression] e1000e broke e1000, Kok, Auke, (Tue Apr 8, 1:31 pm)
Re: [regression] e1000e broke e1000, Ingo Molnar, (Tue Apr 8, 1:33 pm)
Re: [regression] e1000e broke e1000, Ingo Molnar, (Tue Apr 8, 1:35 pm)
Re: showing which hardware is unclaimed, Martin Mares, (Tue Apr 8, 1:35 pm)
Re: [regression] e1000e broke e1000, Martin Mares, (Tue Apr 8, 1:36 pm)
Re: [regression] e1000e broke e1000, Dan Noe, (Tue Apr 8, 1:39 pm)
Re: [E1000-devel] [regression] e1000e broke e1000, Kok, Auke, (Tue Apr 8, 1:47 pm)
Re: [regression] e1000e broke e1000, Jeff Garzik, (Tue Apr 8, 1:56 pm)
Re: [regression] e1000e broke e1000, Ingo Molnar, (Wed Apr 9, 12:12 pm)
Re: [regression] e1000e broke e1000, Jeff Garzik, (Wed Apr 9, 12:33 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Jeff Garzik, (Wed Apr 9, 12:50 pm)
Re: [regression] e1000e broke e1000, Bill Davidsen, (Wed Apr 9, 5:52 pm)
Re: [patch] e1000=y && e1000e=m regression fix, Ingo Molnar, (Thu Apr 10, 12:27 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Chris Friesen, (Thu Apr 10, 2:20 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Randy Dunlap, (Thu Apr 10, 2:44 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Philip Craig, (Thu Apr 10, 5:46 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Andi Kleen, (Fri Apr 11, 12:54 am)
Re: [regression] e1000e broke e1000, Ingo Molnar, (Fri Apr 11, 1:59 am)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Ingo Molnar, (Fri Apr 11, 4:26 am)
Re: [regression] e1000e broke e1000, Ingo Molnar, (Fri Apr 11, 4:30 am)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Christoph Hellwig, (Fri Apr 11, 4:36 am)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Ingo Molnar, (Fri Apr 11, 5:16 am)
Re: [regression] e1000e broke e1000, Chris Friesen, (Fri Apr 11, 8:40 am)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Christoph Hellwig, (Fri Apr 11, 9:45 am)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Martin Mares, (Fri Apr 11, 10:10 am)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Linus Torvalds, (Fri Apr 11, 10:34 am)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Matthew Wilcox, (Fri Apr 11, 10:53 am)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Linus Torvalds, (Fri Apr 11, 11:51 am)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Matthew Wilcox, (Fri Apr 11, 12:01 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Willy Tarreau, (Fri Apr 11, 12:25 pm)
Re: [regression] e1000e broke e1000, Willy Tarreau, (Fri Apr 11, 12:29 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Matthew Wilcox, (Fri Apr 11, 12:38 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Linus Torvalds, (Fri Apr 11, 1:21 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Krzysztof Halasa, (Fri Apr 11, 1:22 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Linus Torvalds, (Fri Apr 11, 1:29 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Daniel Barkalow, (Fri Apr 11, 3:06 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Jeff Garzik, (Fri Apr 11, 3:21 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Linus Torvalds, (Fri Apr 11, 4:00 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Daniel Barkalow, (Fri Apr 11, 4:05 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Daniel Barkalow, (Fri Apr 11, 4:15 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Jeff Garzik, (Fri Apr 11, 4:43 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Christoph Hellwig, (Sat Apr 12, 6:07 am)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Linus Torvalds, (Sun Apr 13, 2:13 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Ondrej Zary, (Sun Apr 13, 2:34 pm)
Re: [patch] e1000=y &amp;&amp; e1000e=m regression fix, Ingo Molnar, (Mon Jun 9, 12:24 pm)