login
Login
/
Register
Search
Search this site:
Forums
News
Blogs
Features
Site
Home
»
Mailing list archives
»
linux-kernel
»
2008
»
January
»
11
Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocked_ioctl
view
thread
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
[view in full thread]
From: Pavel Machek
Subject:
Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocked_ioctl
Date: Friday, January 11, 2008 - 1:33 am
> Hi Andi,
quoted text
> I grepped and tried to do what you suggested. > The first file that git grep reported was: > arch/arm/common/rtctime.c:static const struct file_operations rtc_fops = { > > So I cooked up the following patch (probably mangled, just to give you > a rough idea of what I did): > diff --git a/arch/arm/common/rtctime.c b/arch/arm/common/rtctime.c > index bf1075e..19dedb5 100644 > --- a/arch/arm/common/rtctime.c > +++ b/arch/arm/common/rtctime.c > @@ -189,13 +189,16 @@ static int rtc_ioctl(struct inode *inode, struct > file *file, unsigned int cmd, > if (ret) > break; > ret = copy_to_user(uarg, &alrm.time, sizeof(tm)); > - if (ret) > + if (ret) { > + unlock_kernel(); > ret = -EFAULT; > + } > break;
Just put unlock kernel near return ret;... -- (english)
http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
unsubscribe notice
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to
majordomo@vger.kernel.org
More majordomo info at
http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
http://www.tux.org/lkml/
Previous message: [
thread
] [
date
] [
author
]
Next message: [
thread
] [
date
] [
author
]
Messages in current thread:
[JANITOR PROPOSAL] Switch ioctl functions to ->unlocked_ioctl
, Andi Kleen
, (Tue Jan 8, 9:40 am)
Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocke ...
, Cyrill Gorcunov
, (Tue Jan 8, 10:05 am)
Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocke ...
, Alexey Dobriyan
, (Tue Jan 8, 11:52 am)
Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocke ...
, Andi Kleen
, (Tue Jan 8, 12:18 pm)
Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocke ...
, Matthew Wilcox
, (Tue Jan 8, 1:00 pm)
Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocke ...
, Paolo Ciarrocchi
, (Tue Jan 8, 1:03 pm)
Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocke ...
, Matthew Wilcox
, (Tue Jan 8, 1:16 pm)
Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocke ...
, Matthew Wilcox
, (Tue Jan 8, 1:21 pm)
Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocke ...
, Rik van Riel
, (Tue Jan 8, 1:22 pm)
Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocke ...
, Paolo Ciarrocchi
, (Tue Jan 8, 1:26 pm)
Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocke ...
, Andi Kleen
, (Tue Jan 8, 1:42 pm)
Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocke ...
, Paolo Ciarrocchi
, (Tue Jan 8, 1:45 pm)
Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocke ...
, Paolo Ciarrocchi
, (Tue Jan 8, 4:43 pm)
Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocke ...
, Kevin Winchester
, (Tue Jan 8, 4:50 pm)
Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocke ...
, Dmitri Vorobiev
, (Tue Jan 8, 4:55 pm)
Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocke ...
, Andi Kleen
, (Tue Jan 8, 5:03 pm)
Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocke ...
, Kevin Winchester
, (Tue Jan 8, 5:17 pm)
Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocke ...
, Andi Kleen
, (Tue Jan 8, 5:27 pm)
Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocke ...
, Arnd Bergmann
, (Tue Jan 8, 5:40 pm)
Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocke ...
, Andi Kleen
, (Tue Jan 8, 5:47 pm)
Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocke ...
, Arnd Bergmann
, (Tue Jan 8, 6:19 pm)
Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocke ...
, Kevin Winchester
, (Tue Jan 8, 6:31 pm)
Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocke ...
, Junio C Hamano
, (Wed Jan 9, 3:00 am)
Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocke ...
, Andre Noll
, (Wed Jan 9, 3:34 am)
Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocke ...
, Richard Knutsson
, (Wed Jan 9, 6:17 am)
Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocke ...
, Andre Noll
, (Wed Jan 9, 6:33 am)
Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocke ...
, Matt Mackall
, (Wed Jan 9, 1:12 pm)
Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocke ...
, Alasdair G Kergon
, (Wed Jan 9, 3:40 pm)
Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocke ...
, Alasdair G Kergon
, (Wed Jan 9, 3:45 pm)
Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocke ...
, Andi Kleen
, (Wed Jan 9, 3:46 pm)
Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocke ...
, Chris Friesen
, (Wed Jan 9, 3:58 pm)
Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocke ...
, Alasdair G Kergon
, (Wed Jan 9, 4:05 pm)
Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocke ...
, Vadim Lobanov
, (Wed Jan 9, 4:31 pm)
Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocke ...
, Alasdair G Kergon
, (Wed Jan 9, 5:00 pm)
Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocke ...
, Vadim Lobanov
, (Wed Jan 9, 9:59 pm)
Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocke ...
, Christoph Hellwig
, (Thu Jan 10, 1:34 am)
Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocke ...
, Rolf Eike Beer
, (Thu Jan 10, 1:52 am)
Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocke ...
, Andi Kleen
, (Thu Jan 10, 2:25 am)
Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocke ...
, Daniel Phillips
, (Thu Jan 10, 2:49 am)
Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocke ...
, Rolf Eike Beer
, (Thu Jan 10, 3:02 am)
Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocke ...
, Andi Kleen
, (Thu Jan 10, 3:06 am)
Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocke ...
, Alasdair G Kergon
, (Thu Jan 10, 4:39 am)
Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocke ...
, Daniel Phillips
, (Thu Jan 10, 3:55 pm)
Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocke ...
, Pavel Machek
, (Fri Jan 11, 1:33 am)
supervising, text processing, semantic "patching" (Re: [JA ...
, Oleg Verych
, (Thu Mar 6, 7:54 am)
Navigation
Mailing list archives
Recent posts
Popular discussions
linux-kernel
:
Jesse Barnes
Re: [stable] [BUG][PATCH] cpqphp: fix kernel NULL pointer dereference
Greg KH
[003/136] p54usb: add Zcomax XG-705A usbid
Magnus Damm
[PATCH 03/07] ARM: Use shared GIC entry macros on Realview
Oliver Neukum
Re: [Bug #13682] The webcam stopped working when upgrading from 2.6.29 to 2.6.30
Martin Schwidefsky
Re: [PATCH] optimized ktime_get[_ts] for GENERIC_TIME=y
git
:
Junio C Hamano
Re: Some advanced index playing
Jeff King
Re: confusion over the new branch and merge config
Robin Rosenberg
Re: cvs2svn conversion directly to git ready for experimentation
Linus Torvalds
git binary size...
Ævar Arnfjörð Bjarmason
Re: Challenge with Git-Bash
git-commits-head
:
Linux Kernel Mailing List
md: move allocation of ->queue from mddev_find to md_probe
Linux Kernel Mailing List
md: raid0: Represent zone->zone_offset in sectors.
Linux Kernel Mailing List
[ARM] S3C24XX: Add gpio_to_irq() facility
Linux Kern