Re: [PATCH] JBD slab cleanups

view
thread

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Christoph Hellwig

Date: Monday, September 17, 2007 - 12:34 pm

On Mon, Sep 17, 2007 at 12:29:51PM -0700, Mingming Cao wrote:
quoted text> The problem with this patch, as Andreas Dilger pointed today in ext4
> interlock call, for 1k,2k block size ext2/3/4, get_free_pages() waste
> 1/3-1/2 page space. 
> 
> What was the originally intention to set up slabs for committed_data(and
> frozen_buffer) in JBD? Why not using kmalloc?

kmalloc is using slabs :)

The intent was to avoid the wasted memory, but as we've repeated a gazillion
times wasted memory on a rather rare codepath doesn't really matter when
you just crash random storage drivers otherwise.
-
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[31/36] Large Blocksize: Core piece, clameter, (Tue Aug 28, 12:06 pm)

Re: [31/36] Large Blocksize: Core piece, Mingming Cao, (Wed Aug 29, 5:11 pm)

Re: [31/36] Large Blocksize: Core piece, Christoph Lameter, (Wed Aug 29, 5:12 pm)

[RFC 1/4] Large Blocksize support for Ext2/3/4, Mingming Cao, (Wed Aug 29, 5:47 pm)

[RFC 2/4]ext2: fix rec_len overflow with 64KB block size, Mingming Cao, (Wed Aug 29, 5:47 pm)

[RFC 3/4] ext3: fix rec_len overflow with 64KB block size, Mingming Cao, (Wed Aug 29, 5:48 pm)

[RFC 4/4]ext4: fix rec_len overflow with 64KB block size, Mingming Cao, (Wed Aug 29, 5:48 pm)

Re: [RFC 1/4] Large Blocksize support for Ext2/3/4, Christoph Lameter, (Wed Aug 29, 5:59 pm)

Re: [RFC 1/4] Large Blocksize support for Ext2/3/4, Mingming Cao, (Fri Aug 31, 5:01 pm)

[RFC 1/2] JBD: slab management support for large block(>8k), Mingming Cao, (Fri Aug 31, 5:12 pm)

[RFC 2/2] JBD: blocks reservation fix for large block support, Mingming Cao, (Fri Aug 31, 5:12 pm)

Re: [RFC 1/2] JBD: slab management support for large block ..., Christoph Hellwig, (Sat Sep 1, 11:39 am)

Re: [RFC 1/2] JBD: slab management support for large block ..., Christoph Lameter, (Sun Sep 2, 4:40 am)

Re: [RFC 1/2] JBD: slab management support for large block ..., Christoph Hellwig, (Sun Sep 2, 8:28 am)

Re: [RFC 1/2] JBD: slab management support for large block ..., Christoph Lameter, (Mon Sep 3, 12:55 am)

Re: [RFC 1/2] JBD: slab management support for large block ..., Christoph Hellwig, (Mon Sep 3, 6:40 am)

Re: [RFC 1/2] JBD: slab management support for large block ..., Christoph Lameter, (Mon Sep 3, 12:31 pm)

Re: [RFC 1/2] JBD: slab management support for large block ..., Christoph Hellwig, (Mon Sep 3, 12:33 pm)

[PATCH] JBD slab cleanups, Mingming Cao, (Fri Sep 14, 11:53 am)

Re: [PATCH] JBD slab cleanups, Christoph Lameter, (Fri Sep 14, 11:58 am)

Re: [PATCH] JBD slab cleanups, Mingming Cao, (Mon Sep 17, 12:29 pm)

Re: [PATCH] JBD slab cleanups, Christoph Hellwig, (Mon Sep 17, 12:34 pm)

Re: [PATCH] JBD slab cleanups, Badari Pulavarty, (Mon Sep 17, 3:01 pm)

Re: [PATCH] JBD slab cleanups, Mingming Cao, (Mon Sep 17, 3:57 pm)

Re: [PATCH] JBD slab cleanups, Christoph Hellwig, (Tue Sep 18, 2:04 am)

Re: [PATCH] JBD slab cleanups, Mingming Cao, (Tue Sep 18, 9:35 am)

Re: [PATCH] JBD slab cleanups, Dave Kleikamp, (Tue Sep 18, 11:04 am)

Re: [PATCH] JBD slab cleanups, Mingming Cao, (Tue Sep 18, 6:00 pm)

Re: [PATCH] JBD slab cleanups, Andrew Morton, (Tue Sep 18, 7:19 pm)

Re: [PATCH] JBD slab cleanups, Mingming Cao, (Wed Sep 19, 12:15 pm)

[PATCH] JBD: use GFP_NOFS in kmalloc, Mingming Cao, (Wed Sep 19, 12:22 pm)

Re: [PATCH] JBD slab cleanups, Dave Kleikamp, (Wed Sep 19, 12:26 pm)

Re: [PATCH] JBD slab cleanups, Dave Kleikamp, (Wed Sep 19, 12:28 pm)

Re: [PATCH] JBD slab cleanups, Andreas Dilger, (Wed Sep 19, 12:48 pm)

Re: [PATCH] JBD slab cleanups, Mingming Cao, (Wed Sep 19, 1:47 pm)

Re: [PATCH] JBD: use GFP_NOFS in kmalloc, Andrew Morton, (Wed Sep 19, 2:34 pm)

Re: [PATCH] JBD: use GFP_NOFS in kmalloc, Mingming Cao, (Wed Sep 19, 2:55 pm)

Re: [PATCH] JBD slab cleanups, Mingming Cao, (Wed Sep 19, 3:03 pm)

Re: [PATCH] JBD: use GFP_NOFS in kmalloc, Andreas Dilger, (Wed Sep 19, 9:25 pm)

[PATCH] JBD/ext34 cleanups: convert to kzalloc, Mingming Cao, (Fri Sep 21, 4:13 pm)

[PATCH] JBD2/ext4 naming cleanup, Mingming Cao, (Fri Sep 21, 4:32 pm)

Re: [PATCH] JBD/ext34 cleanups: convert to kzalloc, Andrew Morton, (Wed Sep 26, 12:54 pm)

Re: [PATCH] JBD/ext34 cleanups: convert to kzalloc, Mingming Cao, (Wed Sep 26, 2:05 pm)

[PATCH 1/2] ext4: Support large blocksize up to PAGESIZE, Mingming Cao, (Mon Oct 1, 5:34 pm)

[PATCH 2/2] ext4: Avoid rec_len overflow with 64KB block size, Mingming Cao, (Mon Oct 1, 5:35 pm)

[PATCH 1/2] ext2: Support large blocksize up to PAGESIZE, Mingming Cao, (Mon Oct 1, 5:35 pm)

[PATCH 2/2] ext2: Avoid rec_len overflow with 64KB block size, Mingming Cao, (Mon Oct 1, 5:35 pm)

[PATCH 1/2] ext3: Support large blocksize up to PAGESIZE, Mingming Cao, (Mon Oct 1, 5:36 pm)

[PATCH 2/2] ext3: Avoid rec_len overflow with 64KB block size, Mingming Cao, (Mon Oct 1, 5:36 pm)

Re: [PATCH 2/2] ext2: Avoid rec_len overflow with 64KB blo ..., Andrew Morton, (Thu Oct 4, 1:12 pm)

Re: [PATCH 2/2] ext2: Avoid rec_len overflow with 64KB blo ..., Andreas Dilger, (Thu Oct 4, 3:40 pm)

Re: [PATCH 2/2] ext2: Avoid rec_len overflow with 64KB blo ..., Andrew Morton, (Thu Oct 4, 4:11 pm)

Re: [PATCH 2/2] ext2: Avoid rec_len overflow with 64KB blo ..., Jan Kara, (Mon Oct 8, 6:02 am)

Re: [PATCH 2/2] ext2: Avoid rec_len overflow with 64KB blo ..., Andrew Morton, (Thu Oct 11, 3:14 am)

Re: [PATCH 2/2] ext2: Avoid rec_len overflow with 64KB blo ..., Jan Kara, (Thu Oct 11, 3:30 am)

Re: [PATCH 2/2] ext2: Avoid rec_len overflow with 64KB blo ..., Jan Kara, (Thu Oct 11, 4:18 am)

Re: [PATCH 2/2] ext2: Avoid rec_len overflow with 64KB blo ..., Andrew Morton, (Wed Oct 17, 9:07 pm)

Re: [PATCH 2/2] ext2: Avoid rec_len overflow with 64KB blo ..., Andrew Morton, (Wed Oct 17, 9:09 pm)

Re: [PATCH 2/2] ext2: Avoid rec_len overflow with 64KB blo ..., Christoph Lameter, (Thu Oct 18, 2:03 am)

Re: [PATCH 2/2] ext2: Avoid rec_len overflow with 64KB blo ..., Andrew Morton, (Thu Oct 18, 2:11 am)

Re: [PATCH 2/2] ext2: Avoid rec_len overflow with 64KB blo ..., Mingming Cao, (Thu Oct 18, 7:05 pm)