Re: [PATCH 4/8] i386: bitops: Kill volatile-casting of memory addresses

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Benjamin Herrenschmidt
Date: Tuesday, July 24, 2007 - 2:49 am

> The "const volatile" is so that you can pass an arbitrary pointer. The 

However... What about that:

 - This "volatile" will allow to pass pointers to volatile data to the
bitops.

 - Most users of "volatile" in the kenrel (except maybe jiffies) are
bogus

 - Thus let's remove it -as a type safety thing- to catch more of those
stupid volatile that shouldn't be ? :-)

Besides, as Nick pointed out, it prevents some valid optimizations.

Cheers,
Ben.

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0/8] i386: bitops: Cleanup, sanitize, optimize, Satyam Sharma, (Mon Jul 23, 9:05 am)
[PATCH 1/8] i386: bitops: Update/correct comments, Satyam Sharma, (Mon Jul 23, 9:05 am)
Re: [PATCH 7/8] i386: bitops: Kill needless usage of __asm ..., Jeremy Fitzhardinge, (Mon Jul 23, 9:23 am)
Re: [PATCH 7/8] i386: bitops: Kill needless usage of __asm ..., Jeremy Fitzhardinge, (Mon Jul 23, 10:39 am)
Re: [PATCH 6/8] i386: bitops: Don't mark memory as clobber ..., Jeremy Fitzhardinge, (Mon Jul 23, 10:49 am)
Re: [PATCH 7/8] i386: bitops: Kill needless usage of __asm ..., Jeremy Fitzhardinge, (Mon Jul 23, 11:28 am)
Re: [PATCH 7/8] i386: bitops: Kill needless usage of __asm ..., Jeremy Fitzhardinge, (Mon Jul 23, 1:40 pm)
Re: [PATCH 8/8] i386: bitops: smp_mb__{before, after}_clea ..., Jeremy Fitzhardinge, (Tue Jul 24, 12:48 am)
Re: [PATCH 4/8] i386: bitops: Kill volatile-casting of mem ..., Benjamin Herrenschmidt, (Tue Jul 24, 2:49 am)
Re: [PATCH 6/8] i386: bitops: Don't mark memory as clobber ..., Benjamin Herrenschmidt, (Tue Jul 24, 2:52 am)
Re: [PATCH 6/8] i386: bitops: Don't mark memory as clobber ..., Jeremy Fitzhardinge, (Tue Jul 24, 2:31 pm)
Re: [PATCH 6/8] i386: bitops: Don't mark memory as clobber ..., Benjamin Herrenschmidt, (Tue Jul 24, 2:36 pm)
Re: [PATCH 6/8] i386: bitops: Don't mark memory as clobber ..., Benjamin Herrenschmidt, (Tue Jul 24, 2:37 pm)
Re: [PATCH 6/8] i386: bitops: Don't mark memory as clobber ..., Benjamin Herrenschmidt, (Tue Jul 24, 3:32 pm)