Re: [PATCH 7/8] i386: bitops: Kill needless usage of __asm__ __volatile__

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Satyam Sharma
Date: Monday, July 23, 2007 - 9:32 am

Hi,

On Mon, 23 Jul 2007, Andi Kleen wrote:


Ah, ok, so this must be the case we'd stumbled upon recently on the
other thread. I hadn't got your fix for this, so didn't know.


The patch does look correct to me, we're only killing the use of
__volatile__ from places that don't require it (the guarantee-less
variants). Without losing it, I really don't see how the compiler
can ever combine multiple bitops, which does sound beneficial when
the caller has already implemented higher-level locking around
the usage of these operations.

Satyam
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0/8] i386: bitops: Cleanup, sanitize, optimize, Satyam Sharma, (Mon Jul 23, 9:05 am)
[PATCH 1/8] i386: bitops: Update/correct comments, Satyam Sharma, (Mon Jul 23, 9:05 am)
Re: [PATCH 7/8] i386: bitops: Kill needless usage of __asm ..., Jeremy Fitzhardinge, (Mon Jul 23, 9:23 am)
Re: [PATCH 7/8] i386: bitops: Kill needless usage of __asm ..., Satyam Sharma, (Mon Jul 23, 9:32 am)
Re: [PATCH 7/8] i386: bitops: Kill needless usage of __asm ..., Jeremy Fitzhardinge, (Mon Jul 23, 10:39 am)
Re: [PATCH 6/8] i386: bitops: Don't mark memory as clobber ..., Jeremy Fitzhardinge, (Mon Jul 23, 10:49 am)
Re: [PATCH 7/8] i386: bitops: Kill needless usage of __asm ..., Jeremy Fitzhardinge, (Mon Jul 23, 11:28 am)
Re: [PATCH 7/8] i386: bitops: Kill needless usage of __asm ..., Jeremy Fitzhardinge, (Mon Jul 23, 1:40 pm)
Re: [PATCH 8/8] i386: bitops: smp_mb__{before, after}_clea ..., Jeremy Fitzhardinge, (Tue Jul 24, 12:48 am)
Re: [PATCH 4/8] i386: bitops: Kill volatile-casting of mem ..., Benjamin Herrenschmidt, (Tue Jul 24, 2:49 am)
Re: [PATCH 6/8] i386: bitops: Don't mark memory as clobber ..., Benjamin Herrenschmidt, (Tue Jul 24, 2:52 am)
Re: [PATCH 6/8] i386: bitops: Don't mark memory as clobber ..., Jeremy Fitzhardinge, (Tue Jul 24, 2:31 pm)
Re: [PATCH 6/8] i386: bitops: Don't mark memory as clobber ..., Benjamin Herrenschmidt, (Tue Jul 24, 2:36 pm)
Re: [PATCH 6/8] i386: bitops: Don't mark memory as clobber ..., Benjamin Herrenschmidt, (Tue Jul 24, 2:37 pm)
Re: [PATCH 6/8] i386: bitops: Don't mark memory as clobber ..., Benjamin Herrenschmidt, (Tue Jul 24, 3:32 pm)
Re: [PATCH 0/8] i386: bitops: Cleanup, sanitize, optimize, Denis Vlasenko, (Mon Jul 30, 10:57 am)
Re: [PATCH 0/8] i386: bitops: Cleanup, sanitize, optimize, Satyam Sharma, (Mon Jul 30, 6:07 pm)