Re: init's children list is long and slows reaping children. | KernelTrap

Re: init's children list is long and slows reaping children.

view
thread

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Oleg Nesterov

Subject: Re: init's children list is long and slows reaping children.

Date: Friday, April 6, 2007 - 9:31 am

On 04/06, Eric W. Biederman wrote:
quoted text>
> Thinking about it I do agree with Linus that two lists sounds like the
> right solution because it ensures we always have O(1) time when
> waiting for a zombie.

Well. I bet this will be painful, and will uglify the code even more.

do_wait() has to iterate over 2 lists, __ptrace_unlink() should check
->exit_state, etc...

quoted text>                        I'd like to place the list head for the zombie
> list in the signal_struct and not in the task_struct so our
> performance continues to be O(1) when we have a threaded process.

Sure. It would be nice to move ->children into signal_struct at first.
Except this change breaks (in fact fixes) ->pdeath_signal behaviour.

quoted text> The big benefit of the zombie list over your proposed list reordering
> is that waitpid can return immediately when we don't have zombies to
> wait for, but we have lots of children.

TASK_TRACED/TASK_STOPPED ?

Oleg.

-
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

init's children list is long and slows reaping children., Robin Holt, (Thu Apr 5, 12:51 pm)

Re: init's children list is long and slows reaping children., Linus Torvalds, (Thu Apr 5, 1:57 pm)

Re: init's children list is long and slows reaping children., Chris Snook, (Thu Apr 5, 5:51 pm)

Re: init's children list is long and slows reaping children., Chris Snook, (Thu Apr 5, 6:03 pm)

Re: init's children list is long and slows reaping children., Linus Torvalds, (Thu Apr 5, 6:29 pm)

Re: init's children list is long and slows reaping children., Eric W. Biederman, (Thu Apr 5, 7:15 pm)

Re: init's children list is long and slows reaping children., Robin Holt, (Fri Apr 6, 3:43 am)

Re: init's children list is long and slows reaping children., Eric W. Biederman, (Fri Apr 6, 8:38 am)

Re: init's children list is long and slows reaping children., Oleg Nesterov, (Fri Apr 6, 9:31 am)

Re: init's children list is long and slows reaping children., Robin Holt, (Fri Apr 6, 9:41 am)

Re: init's children list is long and slows reaping children., Ingo Molnar, (Fri Apr 6, 10:32 am)

Re: init's children list is long and slows reaping children., Roland Dreier, (Fri Apr 6, 10:39 am)

Re: init's children list is long and slows reaping children., Eric W. Biederman, (Fri Apr 6, 11:02 am)

Re: init's children list is long and slows reaping children., Eric W. Biederman, (Fri Apr 6, 11:04 am)

Re: init's children list is long and slows reaping children., Christoph Hellwig, (Fri Apr 6, 11:05 am)

Re: init's children list is long and slows reaping children., Davide Libenzi, (Fri Apr 6, 11:21 am)

Re: init's children list is long and slows reaping children., Eric W. Biederman, (Fri Apr 6, 11:30 am)

Re: init's children list is long and slows reaping children., Eric W. Biederman, (Fri Apr 6, 11:56 am)

Re: init's children list is long and slows reaping children., Davide Libenzi, (Fri Apr 6, 12:16 pm)

[patch] sched: get rid of p->children use in show_task(), Ingo Molnar, (Fri Apr 6, 12:18 pm)

Re: init's children list is long and slows reaping children., Ingo Molnar, (Fri Apr 6, 12:19 pm)

Re: [patch] sched: get rid of p->children use in show_task(), Ingo Molnar, (Fri Apr 6, 12:22 pm)

Re: init's children list is long and slows reaping children., Eric W. Biederman, (Fri Apr 6, 12:39 pm)

Re: init's children list is long and slows reaping children., Davide Libenzi, (Fri Apr 6, 2:29 pm)

Re: init's children list is long and slows reaping children., Linus Torvalds, (Fri Apr 6, 2:51 pm)

Re: init's children list is long and slows reaping children., Davide Libenzi, (Fri Apr 6, 3:31 pm)

Re: init's children list is long and slows reaping children., Jeff Garzik, (Fri Apr 6, 3:38 pm)

Re: init's children list is long and slows reaping children., Linus Torvalds, (Fri Apr 6, 3:46 pm)

Re: init's children list is long and slows reaping children., Linus Torvalds, (Fri Apr 6, 3:51 pm)

Re: init's children list is long and slows reaping children., Davide Libenzi, (Fri Apr 6, 3:59 pm)

Re: init's children list is long and slows reaping children., Jeff Garzik, (Fri Apr 6, 4:37 pm)

Re: init's children list is long and slows reaping children., Ingo Molnar, (Mon Apr 9, 1:28 am)

Re: init's children list is long and slows reaping children., Chris Snook, (Mon Apr 9, 10:37 am)

Re: init's children list is long and slows reaping children., Bill Davidsen, (Mon Apr 9, 11:09 am)

Re: init's children list is long and slows reaping children., Kyle Moffett, (Mon Apr 9, 12:28 pm)

Re: init's children list is long and slows reaping children., Linus Torvalds, (Mon Apr 9, 12:51 pm)

Re: init's children list is long and slows reaping children., Eric W. Biederman, (Mon Apr 9, 1:00 pm)

Re: init's children list is long and slows reaping children., Davide Libenzi, (Mon Apr 9, 1:03 pm)

Re: init's children list is long and slows reaping children., Andrew Morton, (Mon Apr 9, 5:23 pm)

Re: init's children list is long and slows reaping children., Eric W. Biederman, (Mon Apr 9, 5:48 pm)

Re: init's children list is long and slows reaping children., Andrew Morton, (Mon Apr 9, 6:15 pm)

Re: init's children list is long and slows reaping children., Dave Jones, (Mon Apr 9, 6:59 pm)

Re: init's children list is long and slows reaping children., Andrew Morton, (Mon Apr 9, 7:30 pm)

Re: init's children list is long and slows reaping children., Linus Torvalds, (Mon Apr 9, 7:46 pm)

Re: init's children list is long and slows reaping children., Alexey Dobriyan, (Mon Apr 9, 10:07 pm)

Re: init's children list is long and slows reaping children., Dave Jones, (Mon Apr 9, 10:21 pm)

Re: init's children list is long and slows reaping children., Torsten Kaiser, (Mon Apr 9, 11:09 pm)

Re: init's children list is long and slows reaping children., Jeff Garzik, (Mon Apr 9, 11:53 pm)

Re: init's children list is long and slows reaping children., Jeff Garzik, (Tue Apr 10, 12:05 am)

Re: init's children list is long and slows reaping children., Jeff Garzik, (Tue Apr 10, 12:07 am)

Re: init's children list is long and slows reaping children., Jeff Garzik, (Tue Apr 10, 12:08 am)

Re: init's children list is long and slows reaping children., Andrew Morton, (Tue Apr 10, 12:37 am)

Re: init's children list is long and slows reaping children., Russell King, (Tue Apr 10, 12:44 am)

Re: init's children list is long and slows reaping children., Jeff Garzik, (Tue Apr 10, 1:16 am)

Re: init's children list is long and slows reaping children., Jeff Garzik, (Tue Apr 10, 1:33 am)

Re: init's children list is long and slows reaping children., Andrew Morton, (Tue Apr 10, 1:41 am)

Re: init's children list is long and slows reaping children., Jeff Garzik, (Tue Apr 10, 1:48 am)

Re: init's children list is long and slows reaping children., Ingo Molnar, (Tue Apr 10, 1:59 am)

Re: init's children list is long and slows reaping children., Jeff Garzik, (Tue Apr 10, 2:33 am)

Re: init's children list is long and slows reaping children., Robin Holt, (Tue Apr 10, 2:42 am)

Re: init's children list is long and slows reaping children., Oleg Nesterov, (Tue Apr 10, 6:38 am)

Re: init's children list is long and slows reaping children., Ingo Molnar, (Tue Apr 10, 6:48 am)

Re: init's children list is long and slows reaping children., Eric W. Biederman, (Tue Apr 10, 7:51 am)

Re: init's children list is long and slows reaping children., Eric W. Biederman, (Tue Apr 10, 8:00 am)

Re: init's children list is long and slows reaping children., Ingo Molnar, (Tue Apr 10, 8:06 am)

Re: init's children list is long and slows reaping children., Bill Davidsen, (Tue Apr 10, 8:12 am)

[PATCH] Only send pdeath_signal when getppid changes., Eric W. Biederman, (Tue Apr 10, 8:16 am)

Re: init's children list is long and slows reaping children., Eric W. Biederman, (Tue Apr 10, 8:22 am)

Re: init's children list is long and slows reaping children., Ingo Molnar, (Tue Apr 10, 8:53 am)

Re: init's children list is long and slows reaping children., Eric W. Biederman, (Tue Apr 10, 9:17 am)

Re: init's children list is long and slows reaping children., Matt Mackall, (Tue Apr 10, 9:35 am)

Re: [PATCH] Only send pdeath_signal when getppid changes., Oleg Nesterov, (Tue Apr 10, 9:37 am)

Re: init's children list is long and slows reaping children., Oleg Nesterov, (Tue Apr 10, 9:44 am)

Re: [PATCH] Only send pdeath_signal when getppid changes., Eric W. Biederman, (Tue Apr 10, 10:41 am)

Re: [PATCH] Only send pdeath_signal when getppid changes., Roland McGrath, (Tue Apr 10, 10:48 am)

Re: init's children list is long and slows reaping children., Davide Libenzi, (Tue Apr 10, 12:17 pm)

Re: init's children list is long and slows reaping children., Ingo Oeser, (Tue Apr 10, 3:20 pm)

Re: init's children list is long and slows reaping children., Ingo Oeser, (Tue Apr 10, 3:35 pm)

Re: [PATCH] Only send pdeath_signal when getppid changes., Albert Cahalan, (Tue Apr 10, 8:17 pm)

[patch] uninline remove/add_parent() APIs, Ingo Molnar, (Tue Apr 10, 11:20 pm)

Re: [patch] uninline remove/add_parent() APIs, Eric W. Biederman, (Wed Apr 11, 12:00 am)

Re: init's children list is long and slows reaping children., Nick Piggin, (Wed Apr 11, 12:28 am)

Re: init's children list is long and slows reaping children., Bill Davidsen, (Wed Apr 11, 12:55 pm)

Re: init's children list is long and slows reaping children., Eric W. Biederman, (Wed Apr 11, 1:17 pm)

Re: init's children list is long and slows reaping children., Oleg Nesterov, (Wed Apr 11, 1:19 pm)

Re: init's children list is long and slows reaping children., Bill Davidsen, (Wed Apr 11, 2:24 pm)

Re: [patch] uninline remove/add_parent() APIs, Andrew Morton, (Wed Apr 11, 3:06 pm)

Re: [patch] uninline remove/add_parent() APIs, Eric W. Biederman, (Thu Apr 12, 3:45 am)

Re: [patch] uninline remove/add_parent() APIs, Roland McGrath, (Thu Apr 12, 3:50 pm)