Re: [PATCH 2/5] Use macros instead of TASK_ flags

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Ingo Molnar

Subject: Re: [PATCH 2/5] Use macros instead of TASK_ flags

Date: Wednesday, December 5, 2007 - 5:56 am

* Matthew Wilcox <matthew@wil.cx> wrote:

quoted text> +#define is_task_stopped(task)	((task->state & TASK_STOPPED) != 0)
> +#define is_task_stopped_or_traced(task)	\
> +			((task->state & (TASK_STOPPED | TASK_TRACED)) != 0)
> +#define is_task_loadavg(task)	((task->state & TASK_UNINTERRUPTIBLE) != 0)

1) please change 'is' and 'task' around so that it reads nicer:

   if (task_is_stopped(t))

instead of the tongue-twister:

   if (is_task_stopped(t))

2) please change task_is_loadavg() to something more sensible - i didnt 
know what it meant when i first saw it in -mm's sched.c. 
task_is_uninterruptible() would be the logical choice ...

	Ingo

--
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH 1/5] Use wake_up_locked() in eventpoll, Matthew Wilcox, (Wed Oct 24, 5:24 am)

[PATCH 2/5] Use macros instead of TASK_ flags, Matthew Wilcox, (Wed Oct 24, 5:24 am)

[PATCH 3/5] Add TASK_WAKEKILL, Matthew Wilcox, (Wed Oct 24, 5:24 am)

[PATCH 4/5] Add lock_page_killable, Matthew Wilcox, (Wed Oct 24, 5:24 am)

[PATCH 5/5] Make wait_on_retry_sync_kiocb killable, Matthew Wilcox, (Wed Oct 24, 5:24 am)

Re: [PATCH 2/5] Use macros instead of TASK_ flags, Andrew Morton, (Wed Oct 24, 8:31 pm)

Re: [PATCH 5/5] Make wait_on_retry_sync_kiocb killable, Andrew Morton, (Wed Oct 24, 8:43 pm)

Re: [PATCH 4/5] Add lock_page_killable, Andrew Morton, (Wed Oct 24, 9:11 pm)

Re: [PATCH 4/5] Add lock_page_killable, Nick Piggin, (Wed Oct 24, 9:13 pm)

Re: [PATCH 5/5] Make wait_on_retry_sync_kiocb killable, Zach Brown, (Thu Oct 25, 11:31 am)

Re: [PATCH 2/5] Use macros instead of TASK_ flags, Andrew Morton, (Fri Oct 26, 11:45 am)

Re: [PATCH 2/5] Use macros instead of TASK_ flags, Alexey Dobriyan, (Fri Oct 26, 1:39 pm)

Re: [PATCH 2/5] Use macros instead of TASK_ flags, Matthew Wilcox, (Fri Oct 26, 5:33 pm)

Re: [PATCH 2/5] Use macros instead of TASK_ flags, Ingo Molnar, (Wed Dec 5, 5:56 am)

Re: [PATCH 2/5] Use macros instead of TASK_ flags, Matthew Wilcox, (Thu Dec 6, 7:42 am)