Re: compat_sys_times() bogus until jiffies >= 0.

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Paul Mackerras
Date: Thursday, November 8, 2007 - 1:53 am

David Miller writes:


We could special-case that and turn it into 0.  That would introduce a
0.01 second blip, which would be better than a 41 second window for
bad behaviour like we have at the moment.

It's also possible that many applications already don't check for
errors.  For example, glibc deliberately doesn't check for errors when
it calls __times in the clock() implementation.  There is a comment in
sysdeps/unix/sysv/linux/clock.c that says this:

  /* We don't check for errors here.  The only error the kernel
     returns is EFAULT if the value cannot be written to the struct we
     pass a pointer to.  Otherwise the kernel returns an `unsigned
     long' value which is the number of jiffies since system start.
     But this number can be negative (when read as `long') when the
     system is up for some time.  Ignoring errors should therefore
     have no negative impacts but solve the problem.  */
  __times (&buf);

Paul.

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
compat_sys_times() bogus until jiffies >= 0., David Brown, (Wed Nov 7, 3:47 pm)
Re: compat_sys_times() bogus until jiffies >= 0., Andrew Morton, (Wed Nov 7, 4:28 pm)
Re: compat_sys_times() bogus until jiffies >= 0., Andrew Morton, (Wed Nov 7, 5:18 pm)
Re: compat_sys_times() bogus until jiffies >= 0., David Miller, (Wed Nov 7, 5:50 pm)
Re: compat_sys_times() bogus until jiffies >= 0., Andreas Schwab, (Wed Nov 7, 5:54 pm)
Re: compat_sys_times() bogus until jiffies >= 0., Andrew Morton, (Wed Nov 7, 6:13 pm)
Re: compat_sys_times() bogus until jiffies >= 0., Andrew Morton, (Wed Nov 7, 6:17 pm)
Re: compat_sys_times() bogus until jiffies >= 0., Paul Mackerras, (Wed Nov 7, 6:53 pm)
Re: compat_sys_times() bogus until jiffies >= 0., David Miller, (Wed Nov 7, 7:09 pm)
Re: compat_sys_times() bogus until jiffies >= 0., Andrew Morton, (Wed Nov 7, 8:07 pm)
Re: compat_sys_times() bogus until jiffies >= 0., David Miller, (Wed Nov 7, 8:13 pm)
Re: compat_sys_times() bogus until jiffies >= 0., Paul Mackerras, (Wed Nov 7, 9:59 pm)
Re: compat_sys_times() bogus until jiffies >= 0., Paul Mackerras, (Wed Nov 7, 10:15 pm)
Re: compat_sys_times() bogus until jiffies >= 0., Andrew Morton, (Wed Nov 7, 10:20 pm)
Re: compat_sys_times() bogus until jiffies >= 0., Paul Mackerras, (Wed Nov 7, 10:36 pm)
Re: compat_sys_times() bogus until jiffies >= 0., David Brown, (Wed Nov 7, 11:00 pm)
Re: compat_sys_times() bogus until jiffies >= 0., Andrew Morton, (Wed Nov 7, 11:12 pm)
Re: compat_sys_times() bogus until jiffies >= 0., David Miller, (Wed Nov 7, 11:22 pm)
Re: compat_sys_times() bogus until jiffies >= 0., David Miller, (Wed Nov 7, 11:24 pm)
Re: compat_sys_times() bogus until jiffies >= 0., David Miller, (Wed Nov 7, 11:25 pm)
Re: compat_sys_times() bogus until jiffies >= 0., Andrew Morton, (Thu Nov 8, 12:09 am)
Re: compat_sys_times() bogus until jiffies >= 0., David Miller, (Thu Nov 8, 12:14 am)
Re: compat_sys_times() bogus until jiffies >= 0., Paul Mackerras, (Thu Nov 8, 1:53 am)
Re: compat_sys_times() bogus until jiffies >= 0., Andreas Schwab, (Thu Nov 8, 3:20 am)
Re: compat_sys_times() bogus until jiffies >= 0., Chris Friesen, (Thu Nov 8, 7:42 am)
Re: compat_sys_times() bogus until jiffies >= 0., Denys Vlasenko, (Thu Nov 8, 12:25 pm)
Re: compat_sys_times() bogus until jiffies >= 0., Denys Vlasenko, (Thu Nov 8, 12:27 pm)
Re: compat_sys_times() bogus until jiffies >= 0., Ulrich Drepper, (Fri Nov 9, 11:20 am)
Re: compat_sys_times() bogus until jiffies >= 0., Michael Kerrisk, (Thu Dec 20, 4:36 am)
Re: compat_sys_times() bogus until jiffies >= 0., David Miller, (Thu Dec 20, 4:51 am)
Re: compat_sys_times() bogus until jiffies >= 0., Andi Kleen, (Fri Dec 21, 5:42 pm)
Re: compat_sys_times() bogus until jiffies >= 0., David Miller, (Fri Dec 21, 6:41 pm)
Re: compat_sys_times() bogus until jiffies >= 0., Andi Kleen, (Fri Dec 21, 6:49 pm)
Re: compat_sys_times() bogus until jiffies >= 0., Andi Kleen, (Fri Dec 21, 6:53 pm)
Re: compat_sys_times() bogus until jiffies >= 0., David Miller, (Fri Dec 21, 9:36 pm)
Re: compat_sys_times() bogus until jiffies >= 0., Andi Kleen, (Sat Dec 22, 5:47 am)