Re: [PATCH 1/3] fix setsid() for sub-namespace /sbin/init

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Eric W. Biederman
Date: Monday, November 26, 2007 - 12:16 pm

Oleg Nesterov <oleg@tv-sign.ru> writes:


We can do even better.  We can remove the misguided code from
copy_process(CLONE_NEWPID) that populates the PIDTYPE_PGID/SID links
and generally does set setsid by hand, and the code from kernel_init
that call set_special_pid(), allowing us to remove the special case
entirely.

The set_special_pid() in kernel_init() and the special case check 
is actually a work around for the fact that earlier we could not
use 0 in the pid hash table.  Now that we can use init_struct_pid
directly we don't need the special case at all.

Eric
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 1/3] fix setsid() for sub-namespace /sbin/init, Oleg Nesterov, (Mon Nov 26, 7:25 am)
Re: [PATCH 1/3] fix setsid() for sub-namespace /sbin/init, Oleg Nesterov, (Mon Nov 26, 7:43 am)
Re: [PATCH 1/3] fix setsid() for sub-namespace /sbin/init, Pavel Emelyanov, (Mon Nov 26, 8:00 am)
Re: [PATCH 1/3] fix setsid() for sub-namespace /sbin/init, Eric W. Biederman, (Mon Nov 26, 12:16 pm)
Re: [PATCH 1/3] fix setsid() for sub-namespace /sbin/init, Oleg Nesterov, (Mon Nov 26, 1:11 pm)
Re: [PATCH 1/3] fix setsid() for sub-namespace /sbin/init, Eric W. Biederman, (Mon Nov 26, 2:40 pm)
Re: [PATCH 1/3] fix setsid() for sub-namespace /sbin/init, Oleg Nesterov, (Mon Nov 26, 3:46 pm)