[PATCH 43/54] kobject: convert arm/mach-omap1/pm.c to kobj_attr interface

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Greg Kroah-Hartman
Date: Friday, November 2, 2007 - 4:59 pm

This makes the code a bit simpler and and gets us one step closer to
deleting the deprecated subsys_attr code.

Cc: Kay Sievers <kay.sievers@vrfy.org>
Cc: Cliff Brake <cbrake@accelent.com>
Cc: Dirk Behme <dirk.behme@de.bosch.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
 arch/arm/mach-omap1/pm.c |   22 ++++++++--------------
 1 files changed, 8 insertions(+), 14 deletions(-)

diff --git a/arch/arm/mach-omap1/pm.c b/arch/arm/mach-omap1/pm.c
index 402113c..63edafb 100644
--- a/arch/arm/mach-omap1/pm.c
+++ b/arch/arm/mach-omap1/pm.c
@@ -69,14 +69,14 @@ static unsigned int mpui1610_sleep_save[MPUI1610_SLEEP_SAVE_SIZE];
 
 static unsigned short enable_dyn_sleep = 1;
 
-static ssize_t omap_pm_sleep_while_idle_show(struct kset *kset, char *buf)
+static ssize_t idle_show(struct kobject *kobj, struct kobj_attribute *attr,
+			 char *buf)
 {
 	return sprintf(buf, "%hu\n", enable_dyn_sleep);
 }
 
-static ssize_t omap_pm_sleep_while_idle_store(struct kset *kset,
-					      const char * buf,
-					      size_t n)
+static ssize_t idle_store(struct kobject *kobj, struct kobj_attribute *attr,
+			  const char * buf, size_t n)
 {
 	unsigned short value;
 	if (sscanf(buf, "%hu", &value) != 1 ||
@@ -88,14 +88,8 @@ static ssize_t omap_pm_sleep_while_idle_store(struct kset *kset,
 	return n;
 }
 
-static struct subsys_attribute sleep_while_idle_attr = {
-	.attr   = {
-		.name = __stringify(sleep_while_idle),
-		.mode = 0644,
-	},
-	.show   = omap_pm_sleep_while_idle_show,
-	.store  = omap_pm_sleep_while_idle_store,
-};
+static struct kobj_attribute sleep_while_idle_attr =
+	__ATTR(sleep_while_idle, 0644, idle_show, idle_store);
 
 static void (*omap_sram_idle)(void) = NULL;
 static void (*omap_sram_suspend)(unsigned long r0, unsigned long r1) = NULL;
@@ -725,9 +719,9 @@ static int __init omap_pm_init(void)
 	omap_pm_init_proc();
 #endif
 
-	error = subsys_create_file(power_kset, &sleep_while_idle_attr);
+	error = sysfs_create_file(&power_kset->kobj, &sleep_while_idle_attr);
 	if (error)
-		printk(KERN_ERR "subsys_create_file failed: %d\n", error);
+		printk(KERN_ERR "sysfs_create_file failed: %d\n", error);
 
 	if (cpu_is_omap16xx()) {
 		/* configure LOW_PWR pin */
-- 
1.5.3.4

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 01/54] ecryptfs: clean up attribute mess, Greg Kroah-Hartman, (Fri Nov 2, 4:58 pm)
[PATCH 02/54] KOBJECT: remove struct kobj_type from struct ..., Greg Kroah-Hartman, (Fri Nov 2, 4:58 pm)
[PATCH 03/54] KOBJECT: remove kobj_set_kset_s as no one is ..., Greg Kroah-Hartman, (Fri Nov 2, 4:58 pm)
[PATCH 04/54] kset: add kset_create_and_register function, Greg Kroah-Hartman, (Fri Nov 2, 4:58 pm)
[PATCH 05/54] kset: convert fuse to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 4:58 pm)
[PATCH 06/54] kset: convert securityfs to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 4:58 pm)
[PATCH 07/54] kset: convert debugfs to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 4:58 pm)
[PATCH 08/54] kset: convert configfs to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 4:58 pm)
[PATCH 09/54] kset: convert ecryptfs to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 4:58 pm)
[PATCH 10/54] kset: convert main fs kset to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 4:58 pm)
[PATCH 11/54] kset: convert gfs2 to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 4:58 pm)
[PATCH 12/54] kset: convert gfs2 dlm to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 4:58 pm)
[PATCH 13/54] kset: convert dlm to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 4:58 pm)
[PATCH 14/54] kset: convert pci hotplug to use kset_create ..., Greg Kroah-Hartman, (Fri Nov 2, 4:58 pm)
[PATCH 15/54] kset: remove decl_subsys_name, Greg Kroah-Hartman, (Fri Nov 2, 4:58 pm)
[PATCH 16/54] kset: convert kernel_subsys to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 4:58 pm)
[PATCH 17/54] kset: convert drivers/base/bus.c kset_create ..., Greg Kroah-Hartman, (Fri Nov 2, 4:58 pm)
[PATCH 18/54] kset: convert drivers/base/class.c kset_crea ..., Greg Kroah-Hartman, (Fri Nov 2, 4:58 pm)
[PATCH 19/54] kset: convert drivers/base/firmware.c kset_c ..., Greg Kroah-Hartman, (Fri Nov 2, 4:58 pm)
[PATCH 20/54] kset: convert /sys/devices to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 4:58 pm)
[PATCH 21/54] kset: convert /sys/hypervisor to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 4:58 pm)
[PATCH 22/54] kset: convert /sys/devices/system to use kse ..., Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 23/54] kset: convert slub to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 24/54] kset: move /sys/slab to /sys/kernel/slab, Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 25/54] kset: convert /sys/module to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 26/54] kset: convert /sys/power to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 27/54] kset: convert s390 hypervisor kset to use ks ..., Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 30/54] driver core: remove owner field from struct ..., Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 31/54] driver core: add way to get to bus kset, Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 32/54] driver core: add way to get to bus device klist, Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 33/54] driver core: remove fields from struct bus_type, Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 34/54] Driver Core: add kobj_attribute handling, Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 35/54] Driver Core: switch all dynamic ksets to kob ..., Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 36/54] fix struct user_info export's sysfs interaction, Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 37/54] ecryptfs: remove version_str file from sysfs, Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 38/54] efivars: remove new_var and del_var files fr ..., Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 39/54] kobject: convert efivars to kobj_attr interface, Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 40/54] firmware: export firmware_kset so that peopl ..., Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 41/54] kset: convert efivars to use kset_create for ..., Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 42/54] kset: convert efivars to use kset_create for ..., Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 43/54] kobject: convert arm/mach-omap1/pm.c to kobj ..., Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 44/54] kobject: convert pseries/power.c to kobj_att ..., Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 45/54] kobject: convert s390 ipl.c to kobj_attr int ..., Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 46/54] kset: convert s390 ipl.c to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 47/54] kobject: convert parisc/pdc_stable to kobj_a ..., Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 48/54] kset: convert parisc/pdc_stable.c to use kse ..., Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 49/54] Driver Core: kill subsys_attribute and defau ..., Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 50/54] kset: convert edd to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 51/54] kset: convert acpi to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 52/54] firmware: remove firmware_(un)register(), Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 53/54] kset: convert ocfs2 to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 54/54] kset: remove decl_subsys macro, Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
Re: [RFC] kobject and kset core changes and cleanups, Andrew Morton, (Mon Nov 5, 11:25 pm)
Re: [RFC] kobject and kset core changes and cleanups, Andrew Morton, (Tue Nov 6, 12:11 am)
Re: [RFC] kobject and kset core changes and cleanups, Andrew Morton, (Tue Nov 6, 1:04 am)
Re: [RFC] kobject and kset core changes and cleanups, Stephane Eranian, (Tue Nov 6, 1:14 am)
Re: [RFC] kobject and kset core changes and cleanups, Stephane Eranian, (Tue Nov 6, 2:33 pm)