[PATCH 37/54] ecryptfs: remove version_str file from sysfs

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Greg Kroah-Hartman
Date: Friday, November 2, 2007 - 4:59 pm

This file violates the one-value-per-file sysfs rule.

If you all want it added back, please do something like a per-feature
file to show what is present and what isn't.

Cc: Kay Sievers <kay.sievers@vrfy.org>
Cc: Mike Halcrow <mhalcrow@us.ibm.com>
Cc: Phillip Hellewell <phillip@hellewell.homeip.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
 fs/ecryptfs/main.c |   43 -------------------------------------------
 1 files changed, 0 insertions(+), 43 deletions(-)

diff --git a/fs/ecryptfs/main.c b/fs/ecryptfs/main.c
index 828fb99..286ade1 100644
--- a/fs/ecryptfs/main.c
+++ b/fs/ecryptfs/main.c
@@ -740,51 +740,8 @@ static ssize_t version_show(struct kobject *kobj,
 
 static struct kobj_attribute version_attr = __ATTR_RO(version);
 
-static struct ecryptfs_version_str_map_elem {
-	u32 flag;
-	char *str;
-} ecryptfs_version_str_map[] = {
-	{ECRYPTFS_VERSIONING_PASSPHRASE, "passphrase"},
-	{ECRYPTFS_VERSIONING_PUBKEY, "pubkey"},
-	{ECRYPTFS_VERSIONING_PLAINTEXT_PASSTHROUGH, "plaintext passthrough"},
-	{ECRYPTFS_VERSIONING_POLICY, "policy"},
-	{ECRYPTFS_VERSIONING_XATTR, "metadata in extended attribute"},
-	{ECRYPTFS_VERSIONING_MULTKEY, "multiple keys per file"}
-};
-
-static ssize_t version_str_show(struct kobject *kobj,
-				struct kobj_attribute *attr, char *buff)
-{
-	int i;
-	int remaining = PAGE_SIZE;
-	int total_written = 0;
-
-	buff[0] = '\0';
-	for (i = 0; i < ARRAY_SIZE(ecryptfs_version_str_map); i++) {
-		int entry_size;
-
-		if (!(ECRYPTFS_VERSIONING_MASK
-		      & ecryptfs_version_str_map[i].flag))
-			continue;
-		entry_size = strlen(ecryptfs_version_str_map[i].str);
-		if ((entry_size + 2) > remaining)
-			goto out;
-		memcpy(buff, ecryptfs_version_str_map[i].str, entry_size);
-		buff[entry_size++] = '\n';
-		buff[entry_size] = '\0';
-		buff += entry_size;
-		total_written += entry_size;
-		remaining -= entry_size;
-	}
-out:
-	return total_written;
-}
-
-static struct kobj_attribute version_attr_str = __ATTR_RO(version_str);
-
 static struct attribute *attributes[] = {
 	&version_attr.attr,
-	&version_attr_str.attr,
 	NULL,
 };
 
-- 
1.5.3.4

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 01/54] ecryptfs: clean up attribute mess, Greg Kroah-Hartman, (Fri Nov 2, 4:58 pm)
[PATCH 02/54] KOBJECT: remove struct kobj_type from struct ..., Greg Kroah-Hartman, (Fri Nov 2, 4:58 pm)
[PATCH 03/54] KOBJECT: remove kobj_set_kset_s as no one is ..., Greg Kroah-Hartman, (Fri Nov 2, 4:58 pm)
[PATCH 04/54] kset: add kset_create_and_register function, Greg Kroah-Hartman, (Fri Nov 2, 4:58 pm)
[PATCH 05/54] kset: convert fuse to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 4:58 pm)
[PATCH 06/54] kset: convert securityfs to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 4:58 pm)
[PATCH 07/54] kset: convert debugfs to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 4:58 pm)
[PATCH 08/54] kset: convert configfs to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 4:58 pm)
[PATCH 09/54] kset: convert ecryptfs to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 4:58 pm)
[PATCH 10/54] kset: convert main fs kset to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 4:58 pm)
[PATCH 11/54] kset: convert gfs2 to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 4:58 pm)
[PATCH 12/54] kset: convert gfs2 dlm to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 4:58 pm)
[PATCH 13/54] kset: convert dlm to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 4:58 pm)
[PATCH 14/54] kset: convert pci hotplug to use kset_create ..., Greg Kroah-Hartman, (Fri Nov 2, 4:58 pm)
[PATCH 15/54] kset: remove decl_subsys_name, Greg Kroah-Hartman, (Fri Nov 2, 4:58 pm)
[PATCH 16/54] kset: convert kernel_subsys to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 4:58 pm)
[PATCH 17/54] kset: convert drivers/base/bus.c kset_create ..., Greg Kroah-Hartman, (Fri Nov 2, 4:58 pm)
[PATCH 18/54] kset: convert drivers/base/class.c kset_crea ..., Greg Kroah-Hartman, (Fri Nov 2, 4:58 pm)
[PATCH 19/54] kset: convert drivers/base/firmware.c kset_c ..., Greg Kroah-Hartman, (Fri Nov 2, 4:58 pm)
[PATCH 20/54] kset: convert /sys/devices to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 4:58 pm)
[PATCH 21/54] kset: convert /sys/hypervisor to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 4:58 pm)
[PATCH 22/54] kset: convert /sys/devices/system to use kse ..., Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 23/54] kset: convert slub to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 24/54] kset: move /sys/slab to /sys/kernel/slab, Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 25/54] kset: convert /sys/module to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 26/54] kset: convert /sys/power to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 27/54] kset: convert s390 hypervisor kset to use ks ..., Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 30/54] driver core: remove owner field from struct ..., Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 31/54] driver core: add way to get to bus kset, Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 32/54] driver core: add way to get to bus device klist, Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 33/54] driver core: remove fields from struct bus_type, Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 34/54] Driver Core: add kobj_attribute handling, Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 35/54] Driver Core: switch all dynamic ksets to kob ..., Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 36/54] fix struct user_info export's sysfs interaction, Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 37/54] ecryptfs: remove version_str file from sysfs, Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 38/54] efivars: remove new_var and del_var files fr ..., Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 39/54] kobject: convert efivars to kobj_attr interface, Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 40/54] firmware: export firmware_kset so that peopl ..., Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 41/54] kset: convert efivars to use kset_create for ..., Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 42/54] kset: convert efivars to use kset_create for ..., Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 43/54] kobject: convert arm/mach-omap1/pm.c to kobj ..., Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 44/54] kobject: convert pseries/power.c to kobj_att ..., Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 45/54] kobject: convert s390 ipl.c to kobj_attr int ..., Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 46/54] kset: convert s390 ipl.c to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 47/54] kobject: convert parisc/pdc_stable to kobj_a ..., Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 48/54] kset: convert parisc/pdc_stable.c to use kse ..., Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 49/54] Driver Core: kill subsys_attribute and defau ..., Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 50/54] kset: convert edd to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 51/54] kset: convert acpi to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 52/54] firmware: remove firmware_(un)register(), Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 53/54] kset: convert ocfs2 to use kset_create, Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
[PATCH 54/54] kset: remove decl_subsys macro, Greg Kroah-Hartman, (Fri Nov 2, 4:59 pm)
Re: [RFC] kobject and kset core changes and cleanups, Andrew Morton, (Mon Nov 5, 11:25 pm)
Re: [RFC] kobject and kset core changes and cleanups, Andrew Morton, (Tue Nov 6, 12:11 am)
Re: [RFC] kobject and kset core changes and cleanups, Andrew Morton, (Tue Nov 6, 1:04 am)
Re: [RFC] kobject and kset core changes and cleanups, Stephane Eranian, (Tue Nov 6, 1:14 am)
Re: [RFC] kobject and kset core changes and cleanups, Stephane Eranian, (Tue Nov 6, 2:33 pm)