On Thu, 4 Oct 2007 12:38:05 +0200
Jens Axboe <jens.axboe@oracle.com> wrote:

quoted text
> On Thu, Oct 04 2007, Pierre Ossman wrote:
> >=20
> > Is that a yes or a no? You said that the ->page field was involved
> > in
>=20
> It's a conditional yes, re-read it :-)
>=20

I didn't get the memo about what chained sg entries entail.

quoted text
> > list chaining, so does or doesn't it have to be initialized before a
> > call to sg_init_one()?
>=20
> That's not the problem. It has to be initialized before calling
> blk_rq_map_sg(). sg_init_one() will zero the entire sg entry, and that
> breaks if that particular sg entry is part of a larger sg table AND
> that sg entry happens to be the chain element.
>=20

Ok, then it shouldn't affect my world at least.

Rgds
Pierre

PS. Did someone forget to do a review of all blk_rq_map_sg() callers
before committing the chained list stuff? ;)