Home » Mailing list archives » linux-kernel » 2007 » October » 4

[PATCH 29/51] [GFS2] panic after can't parse mount arguments

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: swhiteho
Subject: [PATCH 29/51] [GFS2] panic after can't parse mount arguments
Date: Thursday, October 4, 2007 - 1:49 am

From: Abhijith Das <adas@redhat.com>

When you try to mount gfs2 with -o garbage, the mount fails and the gfs2
superblock is deallocated and becomes NULL. The vfs comes around later
on and calls gfs2_kill_sb. At this point the hidden gfs2 superblock
pointer (sb->s_fs_info) is NULL and dereferencing it through
gfs2_meta_syncfs causes the panic. (the other function call to
gfs2_delete_debugfs_file() succeeds because this function already checks
for a NULL pointer)

Signed-off-by: Abhijith Das <adas@redhat.com>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>

diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c
index 9e0e9be..314c113 100644
--- a/fs/gfs2/ops_fstype.c
+++ b/fs/gfs2/ops_fstype.c
@@ -887,8 +887,10 @@ error:
 
 static void gfs2_kill_sb(struct super_block *sb)
 {
-	gfs2_delete_debugfs_file(sb->s_fs_info);
-	gfs2_meta_syncfs(sb->s_fs_info);
+	if (sb->s_fs_info) {
+		gfs2_delete_debugfs_file(sb->s_fs_info);
+		gfs2_meta_syncfs(sb->s_fs_info);
+	}
 	kill_block_super(sb);
 }
 
-- 
1.5.1.2

-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[GFS2/DLM] Pre-pull patch posting, swhiteho, (Thu Oct 4, 1:48 am)
[PATCH 01/51] [GFS2] Fix two races relating to glock callbacks, swhiteho, (Thu Oct 4, 1:48 am)
[PATCH 02/51] [GFS2] Fix calculation of demote state, swhiteho, (Thu Oct 4, 1:48 am)
[PATCH 03/51] [GFS2] Clean up duplicate includes in fs/gfs2/, swhiteho, (Thu Oct 4, 1:48 am)
[PATCH 04/51] [GFS2] GFS2 not checking pointer on create w ..., swhiteho, (Thu Oct 4, 1:48 am)
[PATCH 05/51] [GFS2] Fix an oops in glock dumping, swhiteho, (Thu Oct 4, 1:48 am)
[PATCH 06/51] [GFS2] Move some code inside the log lock, swhiteho, (Thu Oct 4, 1:48 am)
[PATCH 07/51] [GFS2] Revert part of earlier log.c changes, swhiteho, (Thu Oct 4, 1:49 am)
[PATCH 08/51] [GFS2] Prevent infinite loop in try_rgrp_unl ..., swhiteho, (Thu Oct 4, 1:49 am)
[PATCH 09/51] [GFS2] use an temp variable to reduce a spin ..., swhiteho, (Thu Oct 4, 1:49 am)
[PATCH 10/51] [GFS2] Detach buf data during in-place writeback, swhiteho, (Thu Oct 4, 1:49 am)
[PATCH 11/51] [GFS2] mark struct *_operations const, swhiteho, (Thu Oct 4, 1:49 am)
[PATCH 12/51] [GFS2] use the declaration of gfs2_dops in t ..., swhiteho, (Thu Oct 4, 1:49 am)
[PATCH 13/51] [GFS2] Reduce number of gfs2_scand processes ..., swhiteho, (Thu Oct 4, 1:49 am)
[PATCH 14/51] [GFS2] invalid metadata block - REVISED, swhiteho, (Thu Oct 4, 1:49 am)
[PATCH 15/51] [GFS2] Ensure journal file cache is flushed ..., swhiteho, (Thu Oct 4, 1:49 am)
[PATCH 16/51] [GFS2] use list_for_each_entry instead, swhiteho, (Thu Oct 4, 1:49 am)
[PATCH 17/51] [GFS2] unneeded typecast, swhiteho, (Thu Oct 4, 1:49 am)
[PATCH 18/51] [GFS2] better code for translating characters, swhiteho, (Thu Oct 4, 1:49 am)
[PATCH 19/51] [GFS2] Force unstuff of hidden quota inode, swhiteho, (Thu Oct 4, 1:49 am)
[PATCH 20/51] [GFS2] fixed a NULL pointer assignment BUG, swhiteho, (Thu Oct 4, 1:49 am)
[PATCH 21/51] [GFS2] Fix quota do_list operation hang, swhiteho, (Thu Oct 4, 1:49 am)
[PATCH 22/51] [GFS2] Clean up invalidatepage/releasepage, swhiteho, (Thu Oct 4, 1:49 am)
[PATCH 23/51] [GFS2] Add a missing gfs2_trans_add_bh(), swhiteho, (Thu Oct 4, 1:49 am)
[PATCH 24/51] [GFS2] Add NULL entry to token table, swhiteho, (Thu Oct 4, 1:49 am)
[PATCH 25/51] [GFS2] Reduce truncate IO traffic, swhiteho, (Thu Oct 4, 1:49 am)
[PATCH 26/51] [DLM] Fix lowcomms socket closing, swhiteho, (Thu Oct 4, 1:49 am)
[PATCH 27/51] [GFS2] Wendy's dump lockname in hex &amp; fix gl ..., swhiteho, (Thu Oct 4, 1:49 am)
[PATCH 28/51] [GFS2] Patch to protect sd_log_num_jdata, swhiteho, (Thu Oct 4, 1:49 am)
[PATCH 29/51] [GFS2] panic after can't parse mount arguments, swhiteho, (Thu Oct 4, 1:49 am)
[PATCH 30/51] [GFS2] delay glock demote for a minimum hold ..., swhiteho, (Thu Oct 4, 1:49 am)
[GFS2/DLM] Pull request, Steven Whitehouse, (Fri Oct 12, 12:47 am)