Re: [PATCH 4/5] Add lock_page_killable

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Andrew Morton

Subject: Re: [PATCH 4/5] Add lock_page_killable

Date: Wednesday, October 24, 2007 - 9:11 pm

On Wed, 24 Oct 2007 08:24:57 -0400 Matthew Wilcox <matthew@wil.cx> wrote:

quoted text> and associated infrastructure such as sync_page_killable and
> fatal_signal_pending.  Use lock_page_killable in do_generic_mapping_read()
> to allow us to kill `cat' of a file on an NFS-mounted filesystem.

whoa, big change.

What exactly are the semantics here?  If the process has actually been
killed (ie: we know that userspace won't be running again) then we break
out of a lock_page() and allow the process to exit?  ie: it's basically
invisible to userspace?

If so, it sounds OK.  I guess.  We're still screwed if the process is doing
a synchronous write and lots of other scenarios.

How well has this been tested?

Have the NFS guys had a think about it?

Why does it return -EIO from read() and not -EINTR?
-
unsubscribe noticeTo unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH 1/5] Use wake_up_locked() in eventpoll, Matthew Wilcox, (Wed Oct 24, 5:24 am)

[PATCH 2/5] Use macros instead of TASK_ flags, Matthew Wilcox, (Wed Oct 24, 5:24 am)

[PATCH 3/5] Add TASK_WAKEKILL, Matthew Wilcox, (Wed Oct 24, 5:24 am)

[PATCH 4/5] Add lock_page_killable, Matthew Wilcox, (Wed Oct 24, 5:24 am)

[PATCH 5/5] Make wait_on_retry_sync_kiocb killable, Matthew Wilcox, (Wed Oct 24, 5:24 am)

Re: [PATCH 2/5] Use macros instead of TASK_ flags, Andrew Morton, (Wed Oct 24, 8:31 pm)

Re: [PATCH 5/5] Make wait_on_retry_sync_kiocb killable, Andrew Morton, (Wed Oct 24, 8:43 pm)

Re: [PATCH 4/5] Add lock_page_killable, Andrew Morton, (Wed Oct 24, 9:11 pm)

Re: [PATCH 4/5] Add lock_page_killable, Nick Piggin, (Wed Oct 24, 9:13 pm)

Re: [PATCH 5/5] Make wait_on_retry_sync_kiocb killable, Zach Brown, (Thu Oct 25, 11:31 am)

Re: [PATCH 2/5] Use macros instead of TASK_ flags, Andrew Morton, (Fri Oct 26, 11:45 am)

Re: [PATCH 2/5] Use macros instead of TASK_ flags, Alexey Dobriyan, (Fri Oct 26, 1:39 pm)

Re: [PATCH 2/5] Use macros instead of TASK_ flags, Matthew Wilcox, (Fri Oct 26, 5:33 pm)

Re: [PATCH 2/5] Use macros instead of TASK_ flags, Ingo Molnar, (Wed Dec 5, 5:56 am)

Re: [PATCH 2/5] Use macros instead of TASK_ flags, Matthew Wilcox