Re: [GIT PATCH] Fix asm-avr32/dma-mapping.h breakage

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Robert P. J. Day
Date: Wednesday, October 24, 2007 - 5:44 am

On Wed, 24 Oct 2007, Adrian Bunk wrote:







more to the point, what the above shows is that the headers aren't
well defined.  one would think that a header file whose name is
"scatterlist.h" should provide content related solely to that name.

if there's different content, such as the "sg helpers" mentioned
above, then those should require a different header file inclusion.
it makes no sense to suggest that one should include
<asm/scatterlist.h> if you need *only* that content, but to include
<linux/scatterlist.h> if you need stuff *in addition to* the
scatterlist content.  that's just begging for confusion.

rday
-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://crashcourse.ca
========================================================================
-
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[GIT PATCH] Fix asm-avr32/dma-mapping.h breakage, Haavard Skinnemoen, (Wed Oct 24, 4:22 am)
Re: [GIT PATCH] Fix asm-avr32/dma-mapping.h breakage, Jens Axboe, (Wed Oct 24, 4:24 am)
Re: [GIT PATCH] Fix asm-avr32/dma-mapping.h breakage, Sam Ravnborg, (Wed Oct 24, 4:29 am)
Re: [GIT PATCH] Fix asm-avr32/dma-mapping.h breakage, Jens Axboe, (Wed Oct 24, 4:58 am)
Re: [GIT PATCH] Fix asm-avr32/dma-mapping.h breakage, Robert P. J. Day, (Wed Oct 24, 5:15 am)
Re: [GIT PATCH] Fix asm-avr32/dma-mapping.h breakage, Jens Axboe, (Wed Oct 24, 5:21 am)
Re: [GIT PATCH] Fix asm-avr32/dma-mapping.h breakage, Adrian Bunk, (Wed Oct 24, 5:41 am)
Re: [GIT PATCH] Fix asm-avr32/dma-mapping.h breakage, Robert P. J. Day, (Wed Oct 24, 5:44 am)
Re: [GIT PATCH] Fix asm-avr32/dma-mapping.h breakage, Jens Axboe, (Wed Oct 24, 5:45 am)