linux-kernel mailing list

FromSubjectsort iconDate
Joe Barr
Serial port blues
I'm forwarding this post by the author of a great little program for digital amateur radio on Linux, because I'm curious whether or not the problem he is seeing can be resolved outside the kernel. All comments welcome on/off list. Thanks, Joe Barr K1GPL -- It's a strange world when proprietary software is not worth stealing, but free software is.
Jan 19, 2:37 pm 2007
Hoang-Nam Nguyen
[PATCH 2.6.20 2/2] ehca: ehca_irq.c: fix mismatched spin ...
Hello Roland! This is a patch for ehca_irq.c that fixes an unproper use of spin_unlock in irq handler. Thanks Nam Signed-off-by Hoang-Nam Nguyen <hnguyen@de.ibm.com> --- ehca_irq.c | 2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/ehca/ehca_irq.c b/drivers/infiniband/hw/ehca/ehca_irq.c index e7209af..93788d8 100644 --- a/drivers/infiniband/hw/ehca/ehca_irq.c +++ b/drivers/infiniband/hw/ehca/ehca_irq.c @@ -440,7 +440,7 @@ void ...
Jan 19, 2:51 pm 2007
Hoang-Nam Nguyen
[PATCH 2.6.20 1/2] ehca: ehca_cq.c: fix unproper use of ...
Hello Roland! This is a patch for ehca_cq.c that fixes unproper use of yield within spinlock context. Thanks Nam Signed-off-by Hoang-Nam Nguyen <hnguyen@de.ibm.com> --- ehca_cq.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/ehca/ehca_cq.c b/drivers/infiniband/hw/ehca/ehca_cq.c index 93995b6..6074c89 100644 --- a/drivers/infiniband/hw/ehca/ehca_cq.c +++ b/drivers/infiniband/hw/ehca/ehca_cq.c @@ -344,8 +344,11 @@ int ...
Jan 19, 2:50 pm 2007
Hoang-Nam Nguyen
[PATCH 2.6.20 0/2] ehca: fix yield and spinlock conflicts
Hello Roland! Here is patch set for ehca with the following bug fixes: * Fix unproper use of yield within spinlock context * Fix mismatched spin_unlock in irq handler Thanks Nam ehca_cq.c | 5 ++++- ehca_irq.c | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) -
Jan 19, 2:49 pm 2007
Adam Kropelin
Re: intel 82571EB gigabit fails to see link on 2.6.20-rc ...
On 2.6.19 the link status is working (follows cable plug/unplug), but no tx or rx packets get thru. Attempts to transmit occasionally result in tx timed out errors in dmesg, but I cannot seem to generate these at will. On 2.6.20-rc5, the link status does not work (link is always down), and as expected no tx or rx. No tx timed out errors this time, presumably because it thinks the link is down. Note that both the switch and the LEDs on the NIC indicate a good 1000 Mbps link. dmesg, ...
Jan 19, 4:15 pm 2007
Auke Kok
Re: intel 82571EB gigabit fails to see link on 2.6.20-rc ...
at least your interrupts look sane. I see you are using MSI, but no interrupts arrive at that won't work. You either need to start with 2.6.20-rc5 (and pull the changes pending merge in netdev-2.6 from Jeff Garzik), or start with 2.6.20-rc4-mm1 and manually apply that patch I sent out on monday. A different combination of either of these two will not work, as they are completely different drivers. can you include `ethtool ethX` output of the link down message and `ethtool -d ethX` as ...
Jan 19, 4:37 pm 2007
Alexey Dobriyan
[PATCH] Recognize video=gx1fb:... option
Juergen Beisert reported that the following option doesn't work for him video=gx1fb:1024x768-16@60 though sisfb was able to parse similar option correctly. Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com> --- drivers/video/geode/gx1fb_core.c | 29 ++++++++++++++++++++++++++++- 1 file changed, 28 insertions(+), 1 deletion(-) --- a/drivers/video/geode/gx1fb_core.c +++ b/drivers/video/geode/gx1fb_core.c @@ -401,6 +401,30 @@ static void gx1fb_remove(struct pci_dev ...
Jan 19, 2:10 pm 2007
Bartlomiej Zolnierki ...
Re: [PATCH 8/15] ide: disable DMA in ->ide_dma_check for ...
I generally tend do cleanups as a groundwork for the real fixes and separate cleanups and fixes to have good base for dealing with regressions. Often all changes (cleanups/fixes) could be included in one patch but then I would have had harsh times when debugging the regressions. It matters a lot if you hit an unknown (or known but the documentation is covered by NDA) hardware bug - you can concentrate on a small patch changing the way in which hardware is accessed instead of that big patch ...
Jan 19, 2:43 pm 2007
Sergei Shtylyov
Re: [PATCH 8/15] ide: disable DMA in ->ide_dma_check for ...
Hello. Erm, I had doubts about it (having in mind that all that code is more of a cleanups than fixes). Maybe it'd be a good idea to separate the fix and Yeah, you if you pass 255, it won't work (so, drive->autotune must be broken). But the driver itself have the wrong idea of 5 meaning auto-tune, so Ugh... don't expect patches form me soon though. My first priority is the Hm, ide_config_drive_speed() is called by both tuneproc() method and MBR, Sergei -
Jan 19, 12:35 pm 2007
Bartlomiej Zolnierki ...
Re: [PATCH 8/15] ide: disable DMA in ->ide_dma_check for ...
Yes, it seems that there are actually two bugs here: * the maximum allowed PIO mode should be PIO4 not PIO5 * for auto-tuning ("pio" == 255) it incorrectly sets PIO0 It is side-effect of basing atiixp on piix driver. Fixing it will allow PIO1 to be used (good) because atiixp_dma_2_pio() always downgrades PIO1 to PIO0 Using ->tuneproc() will also set the PIO mode on the drive Yep, but it seems to be even more complicated since config_art_rwp_pio() is a mess^2 - chipset is ...
Jan 19, 12:11 pm 2007
Jiri Kosina
Re: [patch] hid: put usb_interface instead of usb_device ...
Looks OK to me. I have queued it in HID tree - I am going to push this upstream in a few days. -- Jiri Kosina -
Jan 19, 11:14 am 2007
Anssi Hannula
[patch] hid: put usb_interface instead of usb_device int ...
The commit 4916b3a57fc94664677d439b911b8aaf86c7ec23 introduced a hid regression between 2.6.19 and 2.6.20-rc1. The device put in input_dev->cdev is now of type usb_device instead of usb_interface. No ID_MODEL, ID_VENDOR, ID_REVISION, ID_TYPE etc etc. Fix this by assigning the intf->dev into hid->dev, and fixing all the users. Signed-off-by: Anssi Hannula <anssi.hannula@gmail.com> --- I recommend this fix to go to the stable tree before 2.6.20 is released. diff -Nurp -x ...
Jan 19, 10:28 am 2007
Steven Rostedt
Re: Regarding kernel opps after patchng lngo's RT_PREEMPT
[ I believe you wanted LKML and not majordomo, also CC'd Ingo since he's the maintainer of the -rt patch ] Could you try 2.6.20-rc5-rt7. It's hard to debug a kernel that old. Is there any reason you are not using the latest? -- Steve Sorry, but I'm forwarding it to LKML ;) -
Jan 19, 10:41 am 2007
Christoph Lameter
Re: [RPC][PATCH 2.6.20-rc5] limit total vfs page cache
The reclaimer is passed a control structure that can be used to disable The traditional reclaim works fine if told what to do. Introducing another LRU list to do reclaim is a significant change to the VM, creates lots of overhead etc. -
Jan 19, 12:01 pm 2007
Greg KH
Re: Odd USB problem on THOMSON PDP95FM
I suggest posting this to the linux-usb-devel mailing list, and including your kernel version, and enable CONFIG_USB_STORAGE_DEBUG to see the debugging error messages from the usb-storage driver to help us out. thanks, greg k-h -
Jan 19, 12:59 pm 2007
Marco Ferra
Odd USB problem on THOMSON PDP95FM
Hi kernel developers I don't know if this is the proper list but I have a very odd problem and it's driving me nuts for the past two days. I have a portable mp3 player named: usb-storage: waiting for device to settle before scanning Vendor: THOMSON Model: PDP95FM Series Rev: 0100 Type: Direct-Access ANSI SCSI revision: 04 usb-storage: device scan complete SCSI device sda: 244288 2048-byte hdwr sectors (500 MB) sda: Write Protect is off sda: Mode Sense: 3e ...
Jan 19, 11:55 am 2007
Benjamin Romer
[PATCH 2.6.19.2 1/1] kexec: update IO-APIC dest field to ...
On the Unisys ES7000/ONE system, we encountered a problem where performing a kexec reboot or dump on any cell other than cell 0 causes the system timer to stop working, resulting in a hang during timer calibration in the new kernel. We traced the problem to one line of code in disable_IO_APIC(), which needs to restore the timer's IO-APIC configuration before rebooting. The code is currently using the 4-bit physical destination field, rather than using the 8-bit logical destination field, and ...
Jan 19, 10:12 am 2007
Christoph Lameter Jan 19, 11:27 am 2007
Alexey Dobriyan
Re: [PATCH] include linux/fs.h in linux/cdev.h for struc ...
It is not for "struct inode", but to a pointer to struct inode! You don't need full-blown header for pointer. -
Jan 19, 1:04 pm 2007
Noah Watkins
[PATCH] include linux/fs.h in linux/cdev.h for struct inode
--- include/linux/cdev.h | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/include/linux/cdev.h b/include/linux/cdev.h index f309b00..b53e2a0 100644 --- a/include/linux/cdev.h +++ b/include/linux/cdev.h @@ -5,6 +5,7 @@ #include <linux/kobject.h> #include <linux/kdev_t.h> #include <linux/list.h> +#include <linux/fs.h> struct cdev { struct kobject kobj; -- 1.4.4.1 -
Jan 19, 11:54 am 2007
Randy Dunlap
Re: [PATCH] include linux/fs.h in linux/cdev.h for struc ...
You can just do this forward declaration instead: struct inode; since no struct members are used/needed. This cuts down on #include spider webs & nests. --- ~Randy -
Jan 19, 12:12 pm 2007
Jan Engelhardt
Re: [PATCH] include linux/fs.h in linux/cdev.h for struc ...
NAK. Better is this: Add missing struct predeclarations, otherwise we may get x.c:2: warning:
Jan 19, 3:26 pm 2007
Arjan van de Ven
Re: Threading...
this is odd; even in FC3 getpid() is supposed to return the process ID you should fix the app to use something like pthread_self() instead... (or the highly unportable gettid() but that would just be horrible) -- if you want to mail me at work (you don't), use arjan (at) linux.intel.com Test the interaction between Linux and your BIOS via http://www.linuxfirmwarekit.org -
Jan 19, 11:55 am 2007
Brian McGrew
Re: Threading...
----- And on FC5 I am using pthread_self but my problem isn't simply with pthread_self, it's with the scheduling. On FC3 both threads run simultaneously in almost symmetric parallel. On FC5 one thread don't pick up and start until the previous one is done. On FC3, using getpid for the thread I could use set_afinity to force each thread to its own processor and with FC5 I can't; so I've got one idle processor all the time. -brian Brian McGrew { brian@visionpro.com || ...
Jan 19, 12:01 pm 2007
Brian McGrew
Threading...
I have a very interesting question about something that we're seeing happening with threading between Fedora Core 3 and Fedora Core 5. Running on Dell PowerEdge 1800 Hardware with a Xeon processor with hyper-threading turned on. Both systems are using a 2.6.16.16 kernel (MVP al la special). We have a multithreaded application that starts two worker threads. On Fedora Core 3 both of these we use getpid() to get the PID of the thread and then use set_afinity to assign each thread to it's own ...
Jan 19, 11:43 am 2007
Arjan van de Ven
Re: Threading...
maybe your kernel has a broken scheduler loadbalancing? you really again you can use gettid() or pthread_self() in that call (but remember it's a bitmask not a number); but really you shouldn't have to do this. Try a kernel which has a non-broken load balancer? -- if you want to mail me at work (you don't), use arjan (at) linux.intel.com Test the interaction between Linux and your BIOS via http://www.linuxfirmwarekit.org -
Jan 19, 12:23 pm 2007
Bill Davidsen
Re: Threading...
This sounds so unlikely I hesitate to mention it, but you are not, by any chance, running pthreads on one and nptl on the other, are you? -- bill davidsen <davidsen@tmr.com> CTO TMR Associates, Inc Doing interesting things with small computers since 1979 -
Jan 19, 2:26 pm 2007
Bill Davidsen
Re: Probably wrong place to ask
I do that with CF and memory stick, what kernel, distribution, etc? I would suspect something in hotplug not noticing. I presume you have tried this from cold boot, so any issues with unplugging and plugging another flash are removed. -- bill davidsen <davidsen@tmr.com> CTO TMR Associates, Inc Doing interesting things with small computers since 1979 -
Jan 19, 2:22 pm 2007
Gene Heskett
Re: Probably wrong place to ask
No I didn't try that. See the other ignore me message for the answer. Thanks Bill. -- Cheers, Gene "There are four boxes to be used in defense of liberty: soap, ballot, jury, and ammo. Please use in that order." -Ed Howdershelt (Author) Yahoo.com and AOL/TW attorneys please note, additions to the above message by Gene Heskett are: Copyright 2007 by Maurice Eugene Heskett, all rights reserved. -
Jan 19, 3:53 pm 2007
Gene Heskett
Probably wrong place to ask
Greetings all; I have a card reader plugged into a usb port. I recognizes a 512meg pny cf card just fine, but wwhen I plug in a 256meg Lexar cf, the led comes on, but there is no reaction from linux. /dev/sda is not created, nothing. Is this a kernel config problem, or is this particular cf known to be a bad bird? -- Cheers, Gene "There are four boxes to be used in defense of liberty: soap, ballot, jury, and ammo. Please use in that order." -Ed Howdershelt (Author) Yahoo.com and ...
Jan 19, 12:57 pm 2007
Gene Heskett
Re: Probably wrong place to ask
Ignore me, I opened the second one I'd bought at the same time and it worked as expected. Bad card in the blisterpack. -- Cheers, Gene "There are four boxes to be used in defense of liberty: soap, ballot, jury, and ammo. Please use in that order." -Ed Howdershelt (Author) Yahoo.com and AOL/TW attorneys please note, additions to the above message by Gene Heskett are: Copyright 2007 by Maurice Eugene Heskett, all rights reserved. -
Jan 19, 3:52 pm 2007
Zan Lynx
linux-2.6.20-rc4-mm1 Reiser4 filesystem freeze and corruption
I have been running 2.6.20-rc2-mm1 without problems, but both rc3-mm1 and rc4-mm1 have been giving me these freezes. They were happening inside X and without external console it was impossible to get anything, plus I was reluctant to test it since the freeze sometimes requires a full fsck.reiser4 --build-fs to recover the filesystem. But I finally got some output in a console session. I wasn't able to get it all, I made some notes of what I think the problem is. I may try again later once I ...
Jan 19, 10:58 am 2007
Edward Shishkin
Re: linux-2.6.20-rc4-mm1 Reiser4 filesystem freeze and c ...
I didn't investigate it in details yet, other file systems also freeze for me: -
Jan 19, 11:53 am 2007
dann frazier
Re: [PATCH 9/12] repost: cciss: add busy_configuring flag
hey Jens, Just a poke since I haven't seen this change go into your block tree. Is it still in-plan? -- dann frazier -
Jan 19, 10:42 am 2007
Robert P. J. Day
[PATCH] Stop making "inline" imply forced inlining.
Remove the macros that define simple "inlining" to mean forced inlining, since you can (and *should*) get that effect with the CONFIG_FORCED_INLINING kernel config variable instead. Signed-off-by: Robert P. J. Day <rpjday@mindspring.com> --- this change was compile tested on x86 with "make allyesconfig", followed by turning off forced inlining. now the alpha folks can simplify their compiler.h file. :-) diff --git a/include/linux/compiler-gcc.h ...
Jan 19, 9:56 am 2007
Adrian Bunk
Re: [PATCH] Stop making "inline" imply forced inlining.
NAK. I don't see any place in the kernel where we need a non-forced inline. We have tons of inline's in C files that should simply be removed - Oh, and your patch would have been broken for gcc < 4. cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed -
Jan 19, 10:25 am 2007
Robert P. J. Day
Re: [PATCH] Stop making "inline" imply forced inlining.
that's not the point. the point is that, as it stands now, the build is *broken* in three ways. first, it's broken because declaring something simply as "inline" *forces* it to be inlined, which flies in the face of historical convention and is more than a little misleading. second, it's broken because both the use of "__attribute__((always_inline))" all over the place and the CONFIG_FORCED_INLINING kernel config option imply that you indeed have a choice, when you clearly *don't*. quite ...
Jan 19, 10:39 am 2007
Adrian Bunk
Re: [PATCH] Stop making "inline" imply forced inlining.
In the kernel it's what you should expect since it's defined this way It's the definition of a broken option. Not Q.E.D. due to "rightly or wrongly". It could be because Alpha uses "extern inline" and with it's old semantice I'd understand that always_inline might be a problem - but is there actually any place where Alpha uses "extern inline" with this Can you give at least one concrete example of actually broken code? The only implication I know it has caused is increased code ...
Jan 19, 11:40 am 2007
Roland Dreier
Re: [Fwd: Re: [PATCH 1/10] cxgb3 - main header files]
> Jeff has pulled in the Chelsio Ethernet driver. If you are ready to > merge in the RDMA driver, you can pull it from Yes, I saw that... OK, I'll get serious about reviewing the RDMA stuff. -
Jan 19, 10:07 am 2007
Steve Wise
[Fwd: Re: [PATCH 1/10] cxgb3 - main header files]
Hey Roland, Jeff has pulled in the Chelsio Ethernet driver. If you are ready to merge in the RDMA driver, you can pull it from git://staging.openfabrics.org/~swise/cxgb3.git for-roland Thanks, Steve. -------- Forwarded Message -------- From: Jeff Garzik <jeff@garzik.org> To: Divy Le Ray <divy@chelsio.com> Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, swise@opengridcomputing.com Subject: Re: [PATCH 1/10] cxgb3 - main header files Date: Thu, 18 Jan 2007 22:05:02 ...
Jan 19, 7:28 am 2007
Alexey Dobriyan
[PATCH] Don't map random pages if swapoff errors
From: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru> If read failed we cannot map not-uptodate page to user space. Actually, we are in serious troubles, we do not even know what process to kill. So, the only variant remains: to stop swapoff() and allow someone to kill processes to zap invalid pages. Signed-off-by: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru> Signed-off-by: Alexey Dobriyan <adobriyan@openvz.org> --- mm/swapfile.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) --- ...
Jan 19, 9:30 am 2007
Alexey Kuznetsov
Re: [PATCH] Don't map random pages if swapoff errors
Yes, from this viewpoint more reasonable approach would be to untie corresponding ptes from swap entry and mark them as invalid to trigger fault on access. Not even tried simply because it is definitely not that thing, which we needed. We used this for process migration and for that purpose we really need to know when swapoff() fails ASAP to abort migration, to kill processes which got invalid pages and to resume original copy. Obviously, delayed fault is absolutely inappropriate for this ...
Jan 19, 12:16 pm 2007
Hugh Dickins
Re: [PATCH] Don't map random pages if swapoff errors
True, though we don't really want to kill anything yet: the process may never need that page again. Better to let it continue until it exits, or hits Kirill's check in do_swap_page. But sure, that's not Simple as it is, no, I don't like this patch at all. Getting an error there is all the more reason to proceed with the swapoff, not to give up and break out of it. Let me think a little. CC'ed Richard, since he's also interested in bad swap, and this reminds me to look at his patches ...
Jan 19, 11:08 am 2007
Ed L. Cashin
Re: Re: bio pages with zero page reference count
So it sounds like you've been advocating a general discussion of this issue for a few years now. To summarize the issue: 1) users of the block layer assume that it's fine to associate pages that have a zero reference count with a bio before requesting I/O, 2) intermediaries like iscsi, aoe, and drbd, associate the pages with the frags of skbuffs, but 3) when the network layer has to linearize the skbuff for a network device that doesn't support scatter ...
Jan 19, 9:21 am 2007
Eric W. Biederman
Re: PATCH: Update disable_IO_APIC to use 8-bit destinati ...
When imported into git the leading description of the patch becomes the changelog comments. What you send the first time that got this thread started was great. Eric -
Jan 19, 8:55 am 2007
Udo van den Heuvel
USB extension (repeater) cable
Hello, I just tried my shiny new usb extension cable (repeater): Jan 19 16:01:17 epia kernel: usb 5-1: new high speed USB device using ehci_hcd and address 60 Jan 19 16:01:17 epia kernel: usb 5-1: configuration #1 chosen from 1 choice Jan 19 16:01:17 epia kernel: hub 5-1:1.0: USB hub found Jan 19 16:01:17 epia kernel: hub 5-1:1.0: 4 ports detected Jan 19 16:01:18 epia kernel: hub 5-1:1.0: Cannot enable port 1. Maybe the USB cable is bad? Jan 19 16:01:22 epia last message repeated 3 ...
Jan 19, 8:40 am 2007
Robert P. J. Day
Re: can someone explain "inline" once and for all?
yes, that option was implemented in a half-assed sort of way. if you look at compiler-gcc4.h, at first glance the preprocessing looks like it's doing the right thing for that config option: ================================== #include <linux/compiler-gcc.h> #ifdef CONFIG_FORCED_INLINING # undef inline # undef __inline__ # undef __inline # define inline inline __attribute__((always_inline)) # define __inline__ __inline__ ...
Jan 19, 7:53 am 2007
asgard
question about identiry map(x86)
Hi, all. On early boot stage linux maps only 8M(arch/i386/kernel/head.S). It creates identity map and kernel map like this: 0x00000000 - 0x007FFFFF -> 0x00000000 -> 0x007FFFFF /* identity map */ 0xC0000000 - 0xC07FFFFF -> 0x00000000 -> 0x007FFFFF /* kernel map */ On early boot stage identity map is needed for jumping to 0xC0000000. Intel manual says, that after such jumping identity map can be deleted. (arch/i386/mm/init.c) Linux deletes early boot identity map, but when it maps 1G(all ...
Jan 19, 8:02 am 2007
Bahadir Balban
Enabling IO/MEM through pci bridge
Hi, On some ARM platform with multiple pci bridges, I had to add the below patch in order to enable transactions through the bridges to devices behind. I'm sure there are other platforms with similar pci setup so why wouldn't it work without it? Thanks, Bahadir Enable bus transactions behind bridges. From: Bahadir Balban <bahadir.balban@arm.com> When transactions (MEM/IO) are enabled for a device, this patch ensures also the same transactions are enabled for the bridge that they sit ...
Jan 19, 8:02 am 2007
Prakash Punnoor
Re: [linux-usb-devel] 2.6.20-rc4: usb somehow broken
Hi, I found quickly booted into a 2.6.19-rc5 kjernel which was lying around her= e=20 and here CONFIG_USB_SUSPEND doesn't make any problems with my scanner... gunzip /proc/config.gz -c|grep USB|grep -v ...
Jan 19, 7:00 am 2007
Adrian Bunk
Re: can someone explain "inline" once and for all?
With the current implementation in the kernel (and considering that CONFIG_FORCED_INLINING was implemented in a way that it never had any effect), __always_inline and inline are currently equivalent. __always_inline is mostly an annotation that really bad things might happen if the code doesn't get inlined. But I'm not sure whether such a distinction is required at all - the rule of thumb should be that static functions in headers should be inline (otherwise, they belong into a C ...
Jan 19, 7:13 am 2007
Robert P. J. Day
Re: can someone explain "inline" once and for all?
right, and that last part explains that snippet i previously posted from include/asm-alpha/compiler.h ======================== #ifdef __KERNEL__ /* Some idiots over in <linux/compiler.h> thought inline should imply always_inline. This breaks stuff. We'll include this file whenever we run into such problems. */ ======================== which is a result of this from include/linux/compiler.h: ======================== #define inline inline ...
Jan 19, 7:44 am 2007
Adrian Bunk
Re: can someone explain "inline" once and for all?
I had already removed most of the "extern inline"s in the kernel since they give warnings with -Wmissing-prototypes (which I'd like to enable long-term in the kernel since it helps discovering a class of nasty runtime errors). As far as I can see, all we need is "static inline" with the semantics "force inlining" for functions in header files and perhaps a handful of functions in C files (if any). cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out ...
Jan 19, 10:36 am 2007
Alexandre Oliva
Re: can someone explain "inline" once and for all?
inline, __inline and __inline__ are equivalent as far as GCC is I suspect you're thinking of a different issue. In C99, static inline means the same as in GNU89, non-static non-extern inline means 'use this definition, that does not define objects with static storage nor references identifiers with internal linkage, for inlining or for a local definition, but make calls to it fast and don't generate any out-of-line definition', and extern inline means 'compile this code into a global ...
Jan 19, 10:15 am 2007
Pekka Enberg
Re: can someone explain "inline" once and for all?
AFAIK __always_inline is the only reliable way to force inlining where it matters for correctness (for example, when playing tricks with __builtin_return_address like we do in the slab). Anything else is just a hint to the compiler that might be ignored if the optimizer thinks it knows better. -
Jan 19, 6:01 am 2007
Andreas Schwab
Re: can someone explain "inline" once and for all?
The kernel does not use strict C89, it uses GNUC89. Andreas. -- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." -
Jan 19, 6:58 am 2007
Andreas Schwab
Re: can someone explain "inline" once and for all?
No, it doesn't (there is no C99 compatible inline in gcc before 4.3). It has to do with the fact that inline is not a keyword in C89, so you need to use a different spelling when you want to stay compatible with strict C89. Andreas. -- Andreas Schwab, SuSE Labs, schwab@suse.de SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." -
Jan 19, 6:37 am 2007
Robert P. J. Day
Re: can someone explain "inline" once and for all?
ok, so based on that and a bit more surfing, i see that either "__inline" or "__inline__" are acceptable variants in gcc, and there is no distinction between them, is that right? but in terms of strict C89 compatibility, it would seem to be a bit late for that given: $ grep -r "static inline " . no? rday -
Jan 19, 6:48 am 2007
Robert P. J. Day
can someone explain "inline" once and for all?
apologies if this is an inappropriately trivial question but this has been bugging me for a while. what is the deal with "inline"? first, there appear to be three possible ways of specifying an inline routine in the kernel source: $ grep -r "static inline " . $ grep -r "static __inline__ " . $ grep -r "static __inline " . i vaguely recall that this has something to do with a distinction between C99 inline and gcc inline and trying to avoid a clash between the two, but i'm not ...
Jan 19, 4:56 am 2007
Robert P. J. Day
Re: can someone explain "inline" once and for all?
oh, *that* part i knew. what i don't understand is the difference between "inline", "__inline" and "__inline__". you can see in include/linux/compiler-gcc4.h: #ifdef CONFIG_FORCED_INLINING # undef inline # undef __inline__ # undef __inline # define inline inline __attribute__((always_inline)) # define __inline__ __inline__ __attribute__((always_inline)) # define __inline __inline __attribute__((always_inline)) #endif ...
Jan 19, 6:19 am 2007
Robert P. J. Day
Re: can someone explain "inline" once and for all?
in that case, why did you just waste my time and all that bandwidth by writing in your previous post: "... so you need to use a different spelling when you want to stay compatible with strict C89." please do me a favour and don't post another reply until you go back and actually read my original question. rday -
Jan 19, 7:00 am 2007
Seshadri, Harinarayanan
[RFC] [PATCH] Power S3 Resume Optimization Patch. Reques ...
[RFC][PATCH] Power S3 Resume optimisation=20 Here is a simple patch for optimising the S3 resume. With this patch the resume time is 0.85. Given the fact that device initialisation on the resume takes almost 70% of time, By executing the whole "device_resume()" function on a seperate kernel thread, the resume gets completed( ie. the user can precieve) by ~0.85 sec. To avoid any possible race condition while processing the IO request and to make sure all the io request are queued till the ...
Jan 19, 1:08 am 2007
Pavel Machek
Re: [RFC] [PATCH] Power S3 Resume Optimization Patch. Re ...
And you noticed that, so you fixed obvious problems on block devices. Add mdelay(1 hour) here. Then try to use your wifi card and your tv Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -
Jan 19, 2:29 am 2007
Oleg Nesterov
[RFC, PATCH] workqueue: rework threads/hotplug management
(to apply this patch, handle-cpu_lock_acquire-and-cpu_lock_release-in-workqueue_cpu_callback.patch should be dropped, it is not needed any longer). With this patch workqueue_mutex is used only to protect workqueues list, all workqueue operations can run in parallel with cpuhotplug callback path. take_over_work(), migrate_sequence, CPU_LOCK_ACQUIRE/RELEASE go away. CPU_DEAD just sets cwq->should_stop and returns. After that cwq->thread runs unbound until it flushes cwq->worklist, then exits. ...
Jan 18, 8:11 pm 2007
Rob Landley
Do SIG_DFL handlers have SA_RESTART?
Do the default signal handlers for Linux behave as if they were installed with SA_RESTART, or not? (I tried querying 'em with sigaction but the defaults all have sa_flags 0.) I remember years ago hitting a bug where ctrl-z followed by fg would cause pipelined processes to drop data, and would like to avoid that without having to wrap every darn syscall and check for -EINTR. I _think_ that I just have to feed SA_RESTART to the signals I register handlers for myself, but I'd like to ...
Jan 18, 7:17 pm 2007
Sukadev Bhattiprolu
Re: [BUG] 2.6.20-rc4-mm1: Panic in e1000_write_vfta_82543()
Auke Kok [auke-jan.h.kok@intel.com] wrote: | Sukadev Bhattiprolu wrote: | >I get following panic on 2.6.20-rc4-mm1 on a 2-cpu AMD Opteron system. | > | >Same basic config file seems to work with 2.6.20-rc2-mm1 on this same | >system. Have not tried -rc3-mm1 yet. | > | >Attached are config file and "lspci -vv" output. Let me know if you need | >more info. | > | >Suka | > | >--- | > | >[ 168.925840] Freeing unused kernel memory: 320k freed | > * INIT: version 2.86 booting | > * Starting ...
Jan 18, 7:21 pm 2007
Sukadev Bhattiprolu
[BUG] 2.6.20-rc4-mm1: Panic in e1000_write_vfta_82543()
I get following panic on 2.6.20-rc4-mm1 on a 2-cpu AMD Opteron system. Same basic config file seems to work with 2.6.20-rc2-mm1 on this same system. Have not tried -rc3-mm1 yet. Attached are config file and "lspci -vv" output. Let me know if you need more info. Suka --- [ 168.925840] Freeing unused kernel memory: 320k freed * INIT: version 2.86 booting * Starting basic networking... [ ok ] * Starting kernel event manager... ...
Jan 18, 6:17 pm 2007
Auke Kok
Re: [BUG] 2.6.20-rc4-mm1: Panic in e1000_write_vfta_82543()
Hi, I believe this is one of the bugs that is fixed in the patch that I sent monday. Please try again with the patch applied to your tree and re-test. Thanks. I didn't see Andrew merge the patch yet. see: http://lkml.org/lkml/2007/1/16/226 I can mail the patch if you can't find it. Just ping me privately. Cheers, Auke -
Jan 18, 6:55 pm 2007
Olof Johansson
[PATCH] sata_mv HighPoint 2310 support (88SX7042)
Hi, With the following patch, my HighPoint 2310 with a Marvell 88SX7042 on it seems to work OK. The controller only has 4 ports, with MV_FLAG_DUAL_HC it seems to init 8 ports and fails miserably at probe time. There are no other devices mapped to that chip, maybe it was just incorrectly specified in the first place? Signed-off-by: Olof Johansson <olof@lixom.net> Index: linux-2.6/drivers/ata/sata_mv.c =================================================================== --- ...
Jan 18, 5:39 pm 2007
Robert Hancock
Re: How to flush the disk write cache from userspace
I think we really should have support for doing cache flushes automatically on fsync, etc. User space code should not have to worry about this problem, it's pretty silly that for example MySQL has to advise people to use hdparm -W 0 to disable the write cache on their IDE drives in order to get proper data integrity guarantees - and disabling the cache on IDE without command queueing really slaughters the performance, unnecessarily in this case. There may be some cases where the ...
Jan 18, 5:35 pm 2007
H. Peter Anvin
Re: [PATCH] rdmsr_on_cpu, wrmsr_on_cpu
Don't assume they're going to be "weird." Intel, in particular, is notorious in forgetting what they have already documented as architectural. -hpa -
Jan 18, 5:45 pm 2007
Bartlomiej Zolnierki ...
[PATCH 8/15] ide: disable DMA in ->ide_dma_check for "no ...
[PATCH] ide: disable DMA in ->ide_dma_check for "no IORDY" case If DMA is unsupported ->ide_dma_check should disable DMA. Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> --- drivers/ide/pci/aec62xx.c | 8 +++----- drivers/ide/pci/atiixp.c | 5 ++--- drivers/ide/pci/cmd64x.c | 8 +++----- drivers/ide/pci/cs5535.c | 5 ++--- drivers/ide/pci/hpt34x.c | 8 +++----- drivers/ide/pci/hpt366.c | 8 +++----- ...
Jan 18, 5:31 pm 2007
Bartlomiej Zolnierki ...
[PATCH 3/15] it8213: fix build and ->ultra_mask
[PATCH] it8213: fix build and ->ultra_mask * PCI_DEVICE_ID_ITE_8213 is only defined in -mm kernels, so just use PCI Device ID (0x8213) directly * fix ->ultra_mask to indicate UDMA6 support Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> --- drivers/ide/pci/it8213.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: b/drivers/ide/pci/it8213.c =================================================================== --- a/drivers/ide/pci/it8213.c +++ ...
Jan 18, 5:31 pm 2007
Bartlomiej Zolnierki ...
[PATCH 10/15] ide: add ide_set_dma() helper
[PATCH] ide: add ide_set_dma() helper * add ide_set_dma() helper and make ide_hwif_t.ide_dma_check return -1 when DMA needs to be disabled (== need to call ->ide_dma_off_quietly) 0 when DMA needs to be enabled (== need to call ->ide_dma_on) 1 when DMA setting shouldn't be changed * fix IDE code to use ide_set_dma() instead if using ->ide_dma_check directly Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> --- drivers/ide/arm/icside.c | 5 +---- ...
Jan 18, 5:32 pm 2007
Bartlomiej Zolnierki ...
[PATCH 14/15] ide: rework the code for selecting the bes ...
[PATCH] ide: rework the code for selecting the best DMA transfer mode Depends on the "ide: fix UDMA/MWDMA/SWDMA masks" patch. * add ide_hwif_t.filter_udma_mask hook for filtering UDMA mask (use it in alim15x3, hpt366, siimage and serverworks drivers) * add ide_max_dma_mode() for finding best DMA mode for the device (loosely based on some older libata-core.c code) * convert ide_dma_speed() users to use ide_max_dma_mode() * make ide_rate_filter() take "ide_drive_t *drive" as an argument ...
Jan 18, 5:32 pm 2007
Bartlomiej Zolnierki ...
[PATCH 1/15] ACPI support for IDE devices
[PATCH] ACPI support for IDE devices This patch implements ACPI integration for generic IDE devices. The ACPI spec mandates that some methods are called during suspend and resume. And consequently there most modern Laptops cannot resume properly without it. According to the spec, we should call '_GTM' (Get Timing) upon suspend to store the current IDE adapter settings. Upon resume we should call '_STM' (Set Timing) to initialize the adapter with the stored settings; afterwards '_GTF' (Get ...
Jan 18, 5:31 pm 2007
Bartlomiej Zolnierki ...
[PATCH 5/15] hpt34x: hpt34x_tune_chipset() (->speedproc) fix
[PATCH] hpt34x: hpt34x_tune_chipset() (->speedproc) fix * remember to clear reg2 bits for the current device before setting mode * remove no longer needed hpt34x_clear_chipset() Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> --- drivers/ide/pci/hpt34x.c | 17 +---------------- 1 file changed, 1 insertion(+), 16 deletions(-) Index: b/drivers/ide/pci/hpt34x.c =================================================================== --- a/drivers/ide/pci/hpt34x.c +++ ...
Jan 18, 5:31 pm 2007
Bartlomiej Zolnierki ...
[PATCH 13/15] ide: fix UDMA/MWDMA/SWDMA masks
[PATCH] ide: fix UDMA/MWDMA/SWDMA masks * use 0x00 instead of 0x80 to disable ->{ultra,mwdma,swdma}_mask * add udma_mask field to ide_pci_device_t and use it to initialize ->ultra_mask in aec62xx, pdc202xx_new and pdc202xx_old drivers * fix UDMA masks to match with chipset specific *_ratemask() (alim15x3, hpt366, serverworks and siimage drivers need UDMA mask filtering method - done in the next patch) Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> --- ...
Jan 18, 5:32 pm 2007
Bartlomiej Zolnierki ...
[PATCH 7/15] piix: cleanup
[PATCH] piix: cleanup * disable DMA masks if no_piix_dma is set and remove now not needed no_piix_dma_check from piix_config_drive_for_dma() * there is no need to read register 0x55 in init_hwif_piix() * move cable detection code to piix_cable_detect() * remove unreachable 82371MX code from init_hwif_piix() Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> --- drivers/ide/pci/piix.c | 28 ++++++++++++++++------------ 1 file changed, 16 insertions(+), 12 ...
Jan 18, 5:31 pm 2007
Bartlomiej Zolnierki ...
[PATCH 4/15] ide: convert ide_hwif_t.mmio into flag
[PATCH] ide: convert ide_hwif_t.mmio into flag All users of ->mmio == 1 are gone so convert ->mmio into flag. Noticed by Alan Cox. Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> --- drivers/ide/arm/icside.c | 2 +- drivers/ide/arm/rapide.c | 2 +- drivers/ide/cris/ide-cris.c | 2 +- drivers/ide/h8300/ide-h8300.c | 2 +- drivers/ide/ide-dma.c | 8 ++++---- drivers/ide/ide.c | 5 ++--- drivers/ide/legacy/buddha.c | 2 ...
Jan 18, 5:31 pm 2007
Bartlomiej Zolnierki ...
[PATCH 6/15] atiixp/jmicron/triflex: fix PIO fallback
[PATCH] atiixp/jmicron/triflex: fix PIO fallback * atiixp: if DMA can't be used atiixp_config_drive_for_dma() should return 0, atiixp_dma_check() will tune the correct PIO mode anyway * jmicron: if DMA can't be used config_chipset_for_dma() should return 0, micron_config_drive_for_dma() will tune the correct PIO mode anyway config_jmicron_chipset_for_pio(drive, !speed) doesn't program device transfer mode for speed != 0 (only wastes some CPU cycles on ide_get_best_pio_mode() call) ...
Jan 18, 5:31 pm 2007
Bartlomiej Zolnierki ...
[PATCH 11/15] ide: make ide_hwif_t.ide_dma_{host_off,off ...
[PATCH] ide: make ide_hwif_t.ide_dma_{host_off,off_quietly} void * since ide_hwif_t.ide_dma_{host_off,off_quietly} always return '0' make these functions void and while at it drop "ide_" prefix * fix comment for __ide_dma_off_quietly() * make __ide_dma_{host_off,off_quietly,off}() void and drop "__" prefix Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> --- drivers/ide/arm/icside.c | 10 ++++------ drivers/ide/cris/ide-cris.c | 14 ++++++-------- ...
Jan 18, 5:32 pm 2007
Bartlomiej Zolnierki ...
[PATCH 15/15] ide: add ide_tune_dma() helper
[PATCH] ide: add ide_tune_dma() helper After reworking the code responsible for selecting the best DMA transfer mode it is now possible to add generic ide_tune_dma() helper. Convert some IDE PCI host drivers to use it (the ones left need more work). Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> --- drivers/ide/ide-dma.c | 20 ++++++++++++++++++++ drivers/ide/pci/aec62xx.c | 13 +------------ drivers/ide/pci/atiixp.c | 22 +--------------------- ...
Jan 18, 5:32 pm 2007
Bartlomiej Zolnierki ...
[PATCH 9/15] sgiioc4: fix sgiioc4_ide_dma_check() to ena ...
[PATCH] sgiioc4: fix sgiioc4_ide_dma_check() to enable/disable DMA properly * use sgiioc4_ide_dma_{on,off_quietly}() instead of changing drive->using_dma directly * fix warning message * add FIXME Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> --- drivers/ide/pci/sgiioc4.c | 26 +++++++++++--------------- 1 file changed, 11 insertions(+), 15 deletions(-) Index: b/drivers/ide/pci/sgiioc4.c =================================================================== --- ...
Jan 18, 5:32 pm 2007
Bartlomiej Zolnierki ...
[PATCH 2/15] via82cxxx/pata_via: correct PCI_DEVICE_ID_V ...
[PATCH] via82cxxx/pata_via: correct PCI_DEVICE_ID_VIA_SATA_EIDE ID and add support for CX700 and 8237S This patch: * Corrects the wrong device ID of PCI_DEVICE_ID_VIA_SATA_EIDE from 0x0581 to 0x5324. * Adds VIA CX700 and VT8237S support in drivers/ide/pci/via82cxxx.c * Adds VIA VT8237S support in drivers/ata/pata_via.c Signed-off-by: Josepch Chan <josephchan@via.com.tw> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> --- drivers/ata/pata_via.c | 1 + ...
Jan 18, 5:31 pm 2007
Bartlomiej Zolnierki ...
[PATCH 0/15] IDE quilt tree updated
Hi, I've just updated IDE quilt tree: http://kernel.org/pub/linux/kernel/people/bart/pata-2.6/patches/ New patches: * IDE driver for Delkin/Lexar/ASKA/Workbit/etc. CardBus CF adapters (Mark Lord <mlord@pobox.com>) * ACPI support for IDE devices (Hannes Reinecke <hare@suse.de>) * ide: unregister ide-pnp driver on unload (Tejun Heo <htejun@gmail.com>) * via82cxxx/pata_via: correct PCI_DEVICE_ID_VIA_SATA_EIDE ID and add support for CX700 and 8237S (Josepch Chan ...
Jan 18, 5:30 pm 2007
Sergei Shtylyov
Re: [PATCH 8/15] ide: disable DMA in ->ide_dma_check for ...
Hello. I've looked thru the code, and found more issues with the PIO fallback This function looks like it's working (thouugh having the wrong limit of PIO5 on auto-tuning) but is unnecassary complex. Heh, the driver is certainly a rip-off form hpt366.c. What a doubtful It's simply stupid to convert PIO mode to PIO mode. The whole idea is Well, well, the tuneproc() method can't ahndle auto-tunuing here (255)... And it also doesn't set up drive's own speed. The ...
Jan 19, 9:26 am 2007
Bartlomiej Zolnierki ...
[PATCH 12/15] ide: make ide_hwif_t.ide_dma_host_on void
[PATCH] ide: make ide_hwif_t.ide_dma_host_on void * since ide_hwif_t.ide_dma_host_on is called either when drive->using_dma == 1 or when return value is discarded make it void, also drop "ide_" prefix * make __ide_dma_host_on() void and drop "__" prefix Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> --- drivers/ide/arm/icside.c | 8 ++++---- drivers/ide/cris/ide-cris.c | 2 +- drivers/ide/ide-dma.c | 17 +++++++---------- drivers/ide/ide-iops.c ...
Jan 18, 5:32 pm 2007
Robert Hancock
Re: SATA exceptions with 2.6.20-rc5
I heard from Larry Walton who was apparently seeing this problem as well. He tried my recent "sata_nv: cleanup ADMA error handling v2" patch and originally thought it fixed the problem, but it turned out to only make it happen less often. I wouldn't expect that patch to have an effect on this problem. If it seems to reduce the frequency that would tend to be further evidence of some kind of timing-related issue where the code change just happens to make a difference. I'll see if I ...
Jan 18, 5:09 pm 2007
Björn
Re: SATA exceptions with 2.6.20-rc5
That would imply that disabling adma via a module parameter should make the issue go away, right? I'll try to have a test run with adma disabled over night then. Thanks, Björn -
Jan 18, 5:52 pm 2007
Robert Hancock
Re: EDAC chipkill messages
Sounds like you're having some memory ECC errors.. some Memtest86, etc. runs may be in order. You may be able to figure out from this info what DIMM is having the problem. -- Robert Hancock Saskatoon, SK, Canada To email, remove "nospam" from hancockr@nospamshaw.ca Home Page: http://www.roberthancock.com/ -
Jan 18, 5:12 pm 2007
Orion Poplawski
Re: EDAC chipkill messages
That was my assumption as well, but was hoping someone could decode the above information and point me to the problem chip. I ran Memtest86 overnight but found no problems, but don't know if it needs to run in a particular ECC mode. This is a dual proc 275 system with 4 1GB DIMMs. Guessing that MC1 is the controller on the second CPU. Would row 1 be the second DIMM? -
Jan 19, 9:45 am 2007
Doug Thompson
Re: EDAC chipkill messages
No that would be the FIRST DIMM, on Channel 0 Each DIMM has 2 ChipSelect Rows (CSROW) Each csrow covers two channels across, therefore on a 4 socket memory array, there are CSROWS 0 and 1 on the first DIMM row and CSROWS 2 and 3 on the second DIMM row. WWWWWWWWW XXXXXXXXXXX YYYYYYYYY ZZZZZZZZZZZ The W and the Y DIMMs are channel 0 The X and the Z DIMMs are channel 1 csrows 0 and 1 would cross over Y and Z DIMMs csrows 2 and 3 would cross over W and X DIMMs The mapping ...
Jan 19, 12:34 pm 2007
Adrian Bunk
Linux 2.6.16.38-rc2
Security fixes since 2.6.16.37: - CVE-2006-4814: Fix incorrect user space access locking in mincore() - CVE-2006-5173: i386: save/restore eflags in context switch - CVE-2006-5749: Call init_timer() for ISDN PPP CCP reset state timer - CVE-2006-5755: x86_64: Don't leak NT bit into next task - CVE-2006-5757/CVE-2006-6060: grow_buffers() infinite loop fix - CVE-2006-5823: corrupted cramfs filesystems cause kernel oops - CVE-2006-6053: handle ext3 directory corruption better - CVE-2006-6054: ext2: ...
Jan 18, 5:08 pm 2007
Jan Engelhardt
Re: [ANNOUNCE] System Inactivity Monitor v1.0
I still don't get why this is called "SIN" in the Kconfig and code texts though the acronym for System Inactivity Monitor would be "SIM". -`J' -- -
Jan 19, 3:21 pm 2007
Pavel Machek
Re: [ANNOUNCE] System Inactivity Monitor v1.0
While functionality is extremely interesting.... does it really have Heh. We'll waste power trying to save it. If you have to hook it into kernel, can you at least do it properly? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -
Jan 19, 3:11 am 2007
Scott Preece
Re: [ANNOUNCE] System Inactivity Monitor v1.0
Hi, attached is a patch for your gentable file, rewriting some of the user prompts to make them more readable. Regards, scott
Jan 19, 10:45 am 2007
Bill Davidsen
Re: [ANNOUNCE] System Inactivity Monitor v1.0
Any idea how much power this saves? And for the vast rest of us who do run X, this seems to parallel the work of a well-tuned screensaver. -- bill davidsen <davidsen@tmr.com> CTO TMR Associates, Inc Doing interesting things with small computers since 1979 -
Jan 19, 2:18 pm 2007
Alessandro Di Marco
Re: [ANNOUNCE] System Inactivity Monitor v1.0
Arjan van de Ven <arjan@infradead.org> writes: On Thu, 2007-01-18 at 20:29 +0100, Alessandro Di Marco wrote: > Hi all, >=20 > this is a new 2.6.20 module implementing a user inactivity trigger. Ba= sically > it acts as an event sniffer, issuing an ACPI event when no user activi= ty is > detected for more than a certain amount of time. This event can be suc= cessively > grabbed and managed by an user-level daemon such as acpid, blanking th= e screen, > dimming the ...
Jan 19, 7:49 am 2007
Scott Preece
Re: [ANNOUNCE] System Inactivity Monitor v1.0
--- The code calls it "System Inactivity Notifier". scott -
Jan 19, 3:30 pm 2007
Arjan van de Ven
Re: [ANNOUNCE] System Inactivity Monitor v1.0
Hi, why did you chose an ACPI event? I'd expect a uevent (which dbus captures etc) to be a more logical choice.. Greetings, Arjan van de Ven -
Jan 19, 12:38 am 2007
Randy Dunlap
Re: [PATCH] Documentation/rbtree.txt
Hi, Please use kernel CodingStyle in the kernel Documentation/ directory. That would mean /*...*/ comments instead of // and expanding the if/else lines to have their statements on separate Thanks. --- ~Randy -
Jan 19, 3:41 pm 2007
Martin Schwidefsky
Re: [PATCH 1/2] Consolidate bust_spinlocks()
Yes, this should be fine now. -- blue skies, Martin. Martin Schwidefsky Linux for zSeries Development & Services IBM Deutschland Entwicklung GmbH "Reality continues to ruin my life." - Calvin. -
Jan 19, 2:27 am 2007
Andi Kleen
Re: [PATCH] rdmsr_on_cpu, wrmsr_on_cpu
I can't see any Hypervisors ever allowing those weird MSRs, so for paravirtualization it is probably better to just disable then. -Andi -
Jan 18, 5:40 pm 2007
Al Borchers
Re: kernel cmdline: root=/dev/sdb1,/dev/sda1 "fallback"?
I will look do it, but I will be out next week so it may take a while. -
Jan 18, 9:12 pm 2007
Benjamin Romer
Re: PATCH: Update disable_IO_APIC to use 8-bit destinati ...
Thanks for the pointers! I've bookmarked them for future reference, and sent a new patch that follows the guidelines. :) -- Ben -
Jan 19, 10:14 am 2007
Randy Dunlap
Re: PATCH: Update disable_IO_APIC to use 8-bit destinati ...
We use a source code management system for changelogs. (git) Patch comments (changelog info) go in the email at the top of the patch. See Documentation/SubmittingPatches and http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt and http://linux.yyz.us/patch-format.html for more info. --- ~Randy -
Jan 19, 8:43 am 2007
Vivek Goyal
Re: PATCH: Update disable_IO_APIC to use 8-bit destinati ...
On Thu, Jan 18, 2007 at 02:13:39PM -0500, Benjamin Romer wrote: This patch looks good to me. You might want to provide some description too for changelog. Thanks Vivek -
Jan 18, 8:49 pm 2007
Benjamin Romer
Re: PATCH: Update disable_IO_APIC to use 8-bit destinati ...
A simple description would look something like: - Updated 4-bit IO-APIC physical dest field to 8-bit dest field for xAPIC; fixes ES7000/ONE kexec timer hang Is there a changelog file in the kernel for kexec somewhere, or does this belong in the source file's comments somewhere? I can fix up the patch as soon as I know where the right spot for the description is. :) -- Ben -
Jan 19, 8:11 am 2007
Christoph Lameter
Re: Possible ways of dealing with OOM conditions.
Sslab deals with those issues the right way. We have per processor queues that attempt to keep the cache hot state. A special shared queue exists between neighboring processors to facilitate exchange of objects between then. -
Jan 19, 10:54 am 2007
Evgeniy Polyakov
Re: Possible ways of dealing with OOM conditions.
I meant that pretty anyone can be those user, who can just add a bit You only covered ipv4/v6 and arp, maybe some route updates. But it is very possible, that some allocations are missed like multicast/broadcast. Selecting only special pathes out of the whole possible network alocations tends to create a situation, when something You still can drop them, the main point is that network allocations do No. If system allows to have such a condition, then something is broken. It must be ...
Jan 19, 3:56 pm 2007
Peter Zijlstra
Re: Possible ways of dealing with OOM conditions.
Swap is usually enabled at startup, but sure, if you want you can mess All users of the NVidiot crap deserve all the pain they get. How so? I cover pretty much every allocation needed to process an skb by setting PF_MEMALLOC - the only drawback there is that the reserve might not actually be large enough because it covers more allocations that were considered. (thats one of the TODO items, validate the reserve But the network can create OOM conditions for itself just fine. Consider ...
Jan 19, 5:53 am 2007
Pekka Enberg Jan 19, 5:04 am 2007
Michael Halcrow
Re: [PATCH 2/5 (try 2)] eCryptfs: convert kmap() to kmap ...
Replace kmap() with kmap_atomic(). Reduce the amount of time that mappings are held. Signed-off-by: Michael Halcrow <mhalcrow@us.ibm.com> Signed-off-by: Trevor Highland <tshighla@us.ibm.com> --- fs/ecryptfs/crypto.c | 8 +-- fs/ecryptfs/ecryptfs_kernel.h | 4 - fs/ecryptfs/mmap.c | 121 ++++++++++++----------------------------- 3 files changed, 39 insertions(+), 94 deletions(-) ff2dcd23fe6bd000049987b2bf98ada70755f114 diff --git a/fs/ecryptfs/crypto.c ...
Jan 19, 1:35 pm 2007
Kirill Korotaev
Re: [Devel] [PATCH] Print number of oopses in Sysrq-P output
please fix the comment as well. oops number is very helpful in dealing with people reports. Very often the first Oops is required to get understanding of the real problem, so further oops can be ignored and the first one requested if the problem is reproducable. -
Jan 19, 4:36 am 2007
Andrew Morton
Re: NTFS
Hard. google(ext3 reservations) is a starting point. -
Jan 18, 5:17 pm 2007
Atsushi Nemoto
Re: [PATCH] Make CARDBUS_MEM_SIZE and CARDBUS_IO_SIZE cu ...
OK, here is a revised patch which uses pci= option instead of config parameters. Subject: [PATCH] Make CARDBUS_MEM_SIZE and CARDBUS_IO_SIZE customizable CARDBUS_MEM_SIZE was increased to 64MB on 2.6.20-rc2, but larger size might result in allocation failure for the reserving itself on some platforms (for example typical 32bit MIPS). Make it (and CARDBUS_IO_SIZE too) customizable by "pci=" option for such platforms. Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp> --- ...
Jan 18, 8:19 pm 2007
Atsushi Nemoto
Re: [PATCH] Make CARDBUS_MEM_SIZE and CARDBUS_IO_SIZE cu ...
Sorry, this patch would cause build failure if setup-bus.c was not built into kernel. Revised again. Subject: [PATCH] Make CARDBUS_MEM_SIZE and CARDBUS_IO_SIZE customizable CARDBUS_MEM_SIZE was increased to 64MB on 2.6.20-rc2, but larger size might result in allocation failure for the reserving itself on some platforms (for example typical 32bit MIPS). Make it (and CARDBUS_IO_SIZE too) customizable by "pci=" option for such platforms. Signed-off-by: Atsushi Nemoto ...
Jan 18, 8:57 pm 2007
Arjan van de Ven
Re: unable to mmap /dev/kmem
they're not the same; for a long time, /dev/mem on actual memory returned zeros... so you couldn't use it for rootkits ;) config option is fine I suppose... I assume distros will be smart enough to turn it off ;) -- if you want to mail me at work (you don't), use arjan (at) linux.intel.com Test the interaction between Linux and your BIOS via http://www.linuxfirmwarekit.org -
Jan 19, 10:27 am 2007
Arjan van de Ven
Re: unable to mmap /dev/kmem
... and maybe we should just kill /dev/kmem entirely... it seems mostly used by rootkits but very few other things, if any at all... -- if you want to mail me at work (you don't), use arjan (at) linux.intel.com Test the interaction between Linux and your BIOS via http://www.linuxfirmwarekit.org -
Jan 19, 9:57 am 2007
Hugh Dickins
Re: unable to mmap /dev/kmem
Whoops, I should never have said "never". Checking further back, I found that in 2.4, and prior to 2.6.12, mmap_kmem was simply #defined to mmap_mem, and so you would then have had to subtract PAGE_OFFSET (well, on i386 at least) from the kernel virtual address to get it to work. Andi fixed that in 2.6.12. I agree with his fix: the same data should appear at the same offset whether you use mmap or read, which was not so before his patch (nor after Franck's). Though I do wonder whether it ...
Jan 19, 9:33 am 2007
Nadia Derbey
Re: unable to mmap /dev/kmem
Ok, I'll do that, thanks! Regards, Nadia -
Jan 18, 11:26 pm 2007
Hugh Dickins
Re: unable to mmap /dev/kmem
We fixed (or "fixed") the mmap of them both, not to give zeroes on !PageReserved pages; but read and write were never so restricted. (Oh, I've said "never" again - expect I'll be humiliated shortly.) Can't rootkits work as just about as easily through read & write? Hugh -
Jan 19, 10:52 am 2007
Franck Bui-Huu
Re: unable to mmap /dev/kmem
Hi, I've been confused by 'vma->vm_pgoff' meaning. I assumed that it was an offset relatif to the start of the kernel address space (PAGE_OFFSET) as the commit message I submitted explains. So doing: fd = open("/dev/kmem", O_RDONLY); kmem = mmap(NULL, size, PROT_READ, MAP_PRIVATE, fd, 4 * 4096); actually asks for a kernel space mapping which start 4 pages after the begining of the kernel memory space. So yes, if the 'offset' expected by 'mmap(/dev/kmem, ..., offset)' usage is ...
Jan 19, 4:31 am 2007
Hugh Dickins
Re: unable to mmap /dev/kmem
It was discourteous of me not to CC you: I thought you might say that ;) Though so long as /dev/mem support remains, /dev/kmem might as well? And be kept as a CONFIG_ option under DEBUG_KERNEL thereafter? Hugh -
Jan 19, 10:12 am 2007
Hugh Dickins
Re: unable to mmap /dev/kmem
I agree that the name "kmem" lends itself to that interpretation (and the 2.4 through 2.6.11 history shows that's not a wild idea); but read and write of /dev/kmem have always used the kernel virtual Apology surely accepted, it's a confusing area (inevitably: in a driver for mem, the distinction between addresses and offsets become blurred). But please note, the worst of it was, that your patch comment gave no hint that you were knowingly changing its behaviour on the "main" architectures: ...
Jan 19, 10:02 am 2007
Nadia Derbey
Re: unable to mmap /dev/kmem
I find this feature very interesting from a testing perspective. Now, since I don't like the idea of being the only one that uses a feature (not maintained - may be even to be removed?) may be you could advice me on a more broadly used way to get the value of a non exported kernel variable from inside a test running in user mode? should I use /dev/mem instead? But in that case, I should do the virtual to physical conversion myself, right? Regards, Nadia -
Jan 19, 2:10 am 2007
Andi Kleen
Re: unable to mmap /dev/kmem
> But personally I'd prefer it to remain. Similar. I also got some tools who use it to read kernel variables and doing the V->P conversion in user space would be tedious and unreliable (e.g. for vmalloc) -Andi -
Jan 19, 2:57 pm 2007
Bernhard Walle
Re: [patch 03/26] Dynamic kernel command-line - arm
Are 1024 bytes of a bigger kernel image really a problem? And even, normally kernel images are compressed, and compressing 1024 zeros can be compressed very well. I think saving memory is more important than saving disk space. I know that most ARM device use flash disk, but also most ARM devices have limited RAM. Regards, Bernhard
Jan 19, 5:38 am 2007
OGAWA Hirofumi
Re: PROBLEM: writting files > 100 MB in FAT32
The disk seems flash disk, and this entry may be on the middle of erasing block. The flash disk might be unplugged before flushing dirty -- OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> -
Jan 19, 9:11 am 2007
Condor
Re: PROBLEM: writting files > 100 MB in FAT32
Jan 16 14:56:13 elrond kernel: usb-storage: device found at 4 Jan 16 14:56:13 elrond kernel: usb-storage: waiting for device to settle before scanning Jan 16 14:56:18 elrond kernel: sda: Mode Sense: 00 00 00 00 Jan 16 14:56:18 elrond kernel: sda: Mode Sense: 00 00 00 00 Jan 16 14:56:18 elrond kernel: sda: assuming drive cache: write through Jan 16 14:56:40 elrond kernel: FAT: Filesystem panic (dev sda1) Jan 16 14:56:40 elrond kernel: invalid access to FAT (entry 0x0fffcf03) Jan 16 14:56:40 ...
Jan 19, 5:32 am 2007
Zhang, Yanmin
Re: Questions on PCI express AER support in HBA driver
This is just to enable the error reporting of the device. One of the important parts of AER is error recovery. When an AER error happens, device will send an error message to root port. Then, root port will notify kernel by interrupt. Kernel will print out error message, and do error recovery to recover the related devices. Such recovery need device drivers to provide a couple of callbacks. Documentation/pci-error-recovery.txt Usually, 3 callbacks are enough while error_detected is must. ...
Jan 18, 7:30 pm 2007
Adrian Bunk
Re: Kernel headers - linux-atm userspace build broken by ...
No, linux/types.h But what bothers me more about if_arp.h is that it is one of the headers using "struct sockaddr" in userspace, but as far as I can see we aren't exporting it in any header. This seems to work since glibc is providing the struct, but this looks cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. ...
Jan 19, 7:37 am 2007
Juergen Pfeiffer
Re: long disable of Softirqs in br_forward_delay_timer_e ...
Hi I found the reason for the long disabling of Soft-Irqs: In-between the spin_lock_bh() and spin_unlock_bh() was a printk() going to serial console with 19200baud. So it took easily 30mS for console-output. No i start klogd an the log Messages go to a file in tmpfs in a short time. Juergen Pfeiffer, Seskion GmbH Karlsruher Str. 11/1 70771 ...
Jan 19, 2:35 am 2007
Aubrey Li
Re: [RPC][PATCH 2.6.20-rc5] limit total vfs page cache
So you mean the existing reclaimer has the same issue, doesn't it? In your and Roy's patch, balance_pagecache() routine is called on file backed access. So you still want to add this checking? or change the current reclaimer completely? -Aubrey -
Jan 19, 9:05 am 2007
Vaidyanathan Srinivasan
Re: [RPC][PATCH 2.6.20-rc5] limit total vfs page cache
Hi Aubrey, I used your patch on my PPC64 box and I do not get expected behavior. As you had requested, I am attaching zoneinfo and meminfo dumps: # cat /proc/sys/vm/pagecache_ratio 50 # cat /proc/meminfo MemTotal: 1014600 kB << 1GB Ram MemFree: 960336 kB << Expect to see around 500MB free after Buffers: 8348 kB issue of DD command Cached: 8624 kB SwapCached: 8 kB Active: 20908 kB Inactive: 5680 kB SwapTotal: ...
Jan 19, 7:44 am 2007
Vaidyanathan Srinivasan
Re: [RPC][PATCH 2.6.20-rc5] limit total vfs page cache
Well, the existing reclaimer will do the right job if the kernel really runs out of memory and need to recover pages for new allocations. The pages to be removed will be the coldest page in the system. However now with the introduction of pagecache limit, we are artificially creating a memory scarcity and forcing the reclaimer to throw away some pages while we actually have free usable RAM. In this context the choice of pages picked by the present reclaimer may not be the best ...
Jan 19, 11:49 am 2007
Vaidyanathan Srinivasan
Re: [RPC][PATCH 2.6.20-rc5] limit total vfs page cache
Hi Aubrey, The idea of creating separate flag for pagecache in page_alloc is interesting. The good part is that you flag watermark low and the zone reclaimer will do the rest of the job. However when the zone reclaimer starts to reclaim pages, it will remove all cold pages and not specifically pagecache pages. This may affect performance of applications. One possible solution to this reclaim is to use scan control fields and ask the shrink_page_list() and shrink_active_list() ...
Jan 19, 7:52 am 2007
Christoph Lameter
Re: [RPC][PATCH 2.6.20-rc5] limit total vfs page cache
Pagecache ratio is the ratio of memory to be left over? Would it not be better to twist this around and to be able to specify how much of the memory of a node may be used by the pagecache? Why limit the size of the pagecache? Some kind of rationale would be useful. Maybe it was there in earlier incarnations of the patch that I did not see? It should be kept with it. The calculation of the multiplication / division is usually not done in the hot allocation path. See f.e. how ...
Jan 19, 11:21 am 2007
Aubrey Li
Re: [RPC][PATCH 2.6.20-rc5] limit total vfs page cache
Although I have no PPC64 box in hand, I think the logic should be the same. get_page_from_freelist() is called 5 times in __alloc_pages(). 1) alloc_flags = ALLOC_WMARK_LOW | ALLOC_PAGECACHE; 2) alloc_flags = ALLOC_WMARK_MIN | ALLOC_PAGECACHE; We should have the same result on the first two times get_page_from_freelist(). 3) if (((p->flags & PF_MEMALLOC) || unlikely(test_thread_flag(TIF_MEMDIE))) && !in_interrupt()) alloc_flags = ALLOC_NO_WATERMARKS The case on my platform will never ...
Jan 19, 8:40 am 2007
Grant Grundler
Re: [RFC] pci_bus conversion to struct device
Other per bus attributes might be address routing, VGA routing enabled, Fast-back-to-back enabled. PCI-X bridges and PCI-e bridges might also advertise data related to MMRBC and similar onboard buffer mgt behaviors. ISTR, IBM PCI-X bridge works better with 512 "block" (data xfer size) than larger sizes becuase it internally allocates buffer space in 512B chunks. It would be useful to know along with downstream device MMRBC. Not sure this all has to come from /sys though. grant -
Jan 18, 11:58 pm 2007
Trond Myklebust
Re: [PATCH] nfs: fix congestion control
That would be good as a default, but I've been thinking that we could perhaps also add a sysctl in /proc/sys/fs/nfs in order to make it a tunable? Cheers, Trond -
Jan 19, 11:26 am 2007
Trond Myklebust
Re: [PATCH] nfs: fix congestion control
Yep. Since we don't care too much about metadata updates on the swap file (the file size should never change), we could perhaps make the swapper write out the pages with DATA_SYNC rather than the full -
Jan 19, 9:51 am 2007
Peter Zijlstra
Re: [PATCH] nfs: fix congestion control
Eeuh, right. Glad to have you around to remind how puny my boxens Right, perhaps cap this to a max of 256M. That would allow 128 2M RPC transfers, much more would not be needed I guess. Trond? -
Jan 19, 10:57 am 2007
Christoph Lameter
Re: [PATCH] nfs: fix congestion control
Well this all depends on the memory available to the running process. If the process is just allowed to allocate from a subset of memory Hmmm... lets say we have the worst case of an 8TB IA64 system with 1k nodes of 8G each. On Ia64 the number of pages is 8TB/16KB pagesize = 512 million pages. Thus nfs_congestion_size is 724064 pages which is 11.1Gbytes? If we now restrict a cpuset to a single node then have a nfs_congestion_size of 11.1G vs an available memory on a node of 8G. -
Jan 19, 10:20 am 2007
Peter Zijlstra
Re: [PATCH] nfs: fix congestion control
balance_dirty_pages() wbc.sync_mode = WB_SYNC_NONE; writeback_inodes() sync_sb_inodes() __writeback_single_inode() __sync_single_inode() write_inode() nfs_write_inode() Ah, yes, I see. That ought to work. /me goes verify he didn't mess it up himself... -
Jan 19, 2:33 am 2007
Christoph Lameter
Re: [PATCH] nfs: fix congestion control
Sorry about that but it was unavoidable if we want to get to reasonable limits that will work in all situations. -
Jan 19, 11:02 am 2007
Peter Zijlstra
Re: [PATCH] nfs: fix congestion control
Ah, yeah, forgot to refresh the patch one last time before sending out :-(. -
Jan 19, 10:54 am 2007
Peter Zijlstra
Re: [PATCH] nfs: fix congestion control
And of course I did. This seems to work. The problem I had was that throttle_vm_writeout() got stuck on commit pages. But that can be solved with a much much simpler and better solution. Force all swap traffic to be |FLUSH_STABLE, unstable swap space doesn't make sense anyway :-) So with that out of the way I now have this --- Subject: nfs: fix congestion control The current NFS client congestion logic is severly broken, it marks the backing device congested during each ...
Jan 19, 6:07 am 2007
Evgeniy Polyakov
Re: [take33 10/10] kevent: Kevent based AIO (aio_sendfil ...
No, socket locking is not solution at all here. But the same applies to header - it will be copied into socket queue, then socket will be unlocked and populated VFS data will be put into that queue too, but there is a window between socket unlock after header copy and file data copy. If we will hold socket lock after header is copied, it is possible to lock it for too long - bad sectors on disk, I bet those people worked with different Unix systems, which have much slower syscalls, so they ...
Jan 19, 2:23 am 2007
Suparna Bhattacharya
Re: [take33 10/10] kevent: Kevent based AIO (aio_sendfil ...
That is what I used to think as well. However ... The problem as I understand it now is not about bunching data together, but of ensuring some sort of atomicity between the header and the data, when there can be multiple outstanding aio requests on the same socket - i.e ensuring strict ordering without other data coming in between, when data to be sent is not already in cache, and in the meantime another sendfile or aio write requests comes in for the same socket. Without having to lock the ...
Jan 18, 11:27 pm 2007
Willy Tarreau Jan 18, 10:15 pm 2007
dann frazier
Re: problems with latest smbfs changes on 2.4.34 and sec ...
Wow - sorry about that, that's certainly a cut & paste error. But the I really don't know the correct answer to that, I was merely copying the 2.6 flags. [Still working on getting a 2.4 smbfs test system up...] -- dann frazier -
Jan 18, 6:00 pm 2007
Matheus Izvekov
Re: BUG: linux 2.6.19 unable to enable acpi
printk("ACPI: retry %d\n") -> printk("ACPI: retry %d\n", retry) ;) ill try this again soon. -
Jan 19, 11:03 am 2007
Len Brown
Re: BUG: linux 2.6.19 unable to enable acpi
I guess I'm losing my mind, because when I read this code, there are only two ways out of the while(retry) loop. Either return with success, or retry is 0. So how the heck is retry printed as 142?! did you notice any delay between the last two lines of printout above? please boot with "acpi_dbg_layer=2" "acpi_dbg_level=0xffffffff" so that we can see each read and write of the hardware look like. Success is measured here by looking for SCI_EN being set to indicate that we successfully ...
Jan 19, 1:36 am 2007
Matheus Izvekov
Re: BUG: linux 2.6.19 unable to enable acpi
Ok, here is what i got: hwacpi-0207 [C031D380] [04] hw_get_mode : ----Entry hwregs-0273 [C031D380] [05] get_register : ----Entry hwregs-0487 [C031D380] [06] hw_register_read : ----Entry hwregs-0810 [C031D380] [06] hw_low_level_read : Read: 00000000 width 16 from 0000000000000404 (SystemIO) hwregs-0575 [C031D380] [06] hw_register_read : ----Exit- AE_OK hwregs-0300 [C031D380] [05] get_register : Read value 00000000 register 3 ...
Jan 19, 4:10 pm 2007
Mike Isely
Re: [PATCH 2.6.20-rc5 2/4] pvrusb2: Use ARRAY_SIZE macro
Ahmed: I've pulled your patch into my driver source and will propagate it up appropriately as part of the next batch of pvrusb2 changes to come out of the v4l-dvb repository. -Mike -- | Mike Isely | PGP fingerprint Spammers Die!! | | 03 54 43 4D 75 E5 CC 92 | isely @ pobox (dot) com | 71 16 01 E2 B5 F5 C1 E8 | | -
Jan 18, 11:05 pm 2007
Helge Hafting
Re: [DISCUSS] memory allocation method
Yes, that is one of the nice things about 64-bit machines. No special cases - you sure can get 30GB if your machine is equipped with that much. Or you can get that much virtual memory if you have enough swap . . . Helge Hafting -
Jan 19, 3:41 am 2007
Rick Brown
Re: [DISCUSS] memory allocation method
ONe BIG vmalloc has huge, huge chances of failure. -
Jan 19, 4:42 am 2007
chunkeey
Re: SATA exceptions with 2.6.20-rc5
Not for me. I'm still have the same trouble, but less (maybe about every hour, instead of every 5 minutes). futhermore, I found a patch cocktail-2.6.20-rc3.patch: http://tinyurl.com/2gza8q, which improves the situation too! Now, the funny thing is that I've two SATA HDDs, but only 1 causes all the headaches. The affected drive is a: sda - @ata3.0 - WDC WD2500KS-00M 02.0 ATA-7, max UDMA/133, 488395055 sectors: LBA48 "ata3.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 ...
Jan 19, 12:51 pm 2007
Alistair John Strachan
Re: SATA exceptions with 2.6.20-rc5
Setting this option fixes the problem for me. I suggest that ADMA defaults off in 2.6.20, if there's still time to do that. -- Cheers, Alistair. Final year Computer Science undergraduate. 1F2 55 South Clerk Street, Edinburgh, UK. -
Jan 19, 8:05 am 2007
Alistair John Strachan
Re: SATA exceptions with 2.6.20-rc5
I have exactly the same problem on -rc5 and it causes all I/O to stall periodically if I do _anything_ I/O intensive. On my box, I have 4 sata_nv handled SATA ports, with two pairs of different drives (two Maxtor, two WD) and it happens randomly on both. So it's absolutely nothing to do with the drive make/model. I'll try Jeff's suggestion of disabling ADMA now, but I think something more radical than this workaround should make it into 2.6.20 final, otherwise a lot of people are going ...
Jan 19, 7:53 am 2007
Jeremy Fitzhardinge
Re: [patch 17/20] XEN-paravirt: Add Xen grant table support
Sorry, forgot to update the diffstat for this one: drivers/xen/Makefile | 1 drivers/xen/core/Makefile | 1 drivers/xen/core/grant_table.c | 445 ++++++++++++++++++++++++++++++++++++++++ include/xen/grant_table.h | 107 +++++++++ 4 files changed, 554 insertions(+) J -
Jan 18, 9:07 pm 2007
Jeremy Fitzhardinge
Re: [patch 16/20] XEN-paravirt: Add the Xen virtual cons ...
I think the exact placement of these files needs a bit of work. I don't much care about xen/ vs paravirt/xen vs paravirt-xen/, but placement of headers needs a bit more thought. lhype, er, lguest and vmi are in kernel/, but I think it would be nice to put them near Xen. J -
Jan 18, 9:11 pm 2007
Christoph Hellwig
Re: [Cbe-oss-dev] [PATCH] Cell SPU task notification
I'll hopefull commit these patches this weekend, I'm at a conference currently so not really able to do a lot of work. If you need to make more progress until than just apply the hunk that introduces sched_flags There is no difference in impact between marking a function non-static and adding a trivial wrapper around it, only that the latter creates more bloat. So I don't think there's a good argument against this. -
Jan 18, 8:19 pm 2007
David Woodhouse
Re: 2.6.20-rc5: known regressions with patches (v2)
Linus, please pull from git://git.infradead.org/mtd-2.6.git This fixes the above bug along with a few others. It does also contain a small amount of new code which has been waiting for a while (including the driver for the CAFÉ NAND controller which we use on OLPC.). My apologies for missing the merge window and first asking you to pull this a few hours after 2.6.20-rc1 was cut; I'd been waiting for the bitrev stuff to land, and had waited too long. Adrian Bunk (3): [MTD] SSFDC ...
Jan 18, 6:43 pm 2007
Helge Hafting
Re: How can I create or read/write a file in linux devic ...
To which the response is something like "This is impossible/illegal/unsupported so it can't be done." Fortunately, civilized countries have laws against being fired for being unable to do the impossible. Well, nothing is really impossible. Tell the boss about the man-hours needed to implement a kernel file API from scratch, and then forking the kernel in order to maintain this community-rejected abomination Another way is to cheat. The boss asks the impossible, so make a workaround in the ...
Jan 19, 3:35 am 2007
Adrian Bunk
[-mm patch] drivers/mtd/ubi/: possible cleanups
This patch contains the following possible cleanups: - make needlessly global code static - remove the following unused variable: - debug.c: alloc_prints Signed-off-by: Adrian Bunk <bunk@stusta.de> --- BTW: Do you really need that many different CONFIG_MTD_UBI_DEBUG_* options? drivers/mtd/ubi/cdev.c | 4 +- drivers/mtd/ubi/debug.c | 57 ++++++++++++++++++---------------------- 2 files changed, 28 insertions(+), 33 deletions(-) --- ...
Jan 19, 11:40 am 2007
Alberto Alonso
Re: Ext3 mounted as ext2 but journal still in effect.
Thank you all for all your input. The tune2fs option was eventually used and we run into other problems. I think Andries was right in that the initrd was interfering, that's where we run into issues after the tune2fs. I was trying to avoid the tune2fs as it involves booting into a live CD and brings the system down to where I can't access it over the network (it is a 4 hour drive). At the end we had to replace the drive and recreate all file systems. If it ever happens again I will pay ...
Jan 18, 8:23 pm 2007
Sergei Shtylyov
Re: [PATCH 1/19] ide: update MAINTAINERS entry
Hello. BTW, if I'm (or somebody else) sending patches with IDE driver *fixes*, should these be against that quilt tree (containing largely reworked IDE code), against fresh Linus' tree (or some recent -rc), or against recent -mm tree? WBR, Sergei -
Jan 19, 8:46 am 2007
Andrew Morton Jan 19, 2:30 pm 2007
Michael Reed
Re: [patch] optimize o_direct on block device - v3
Hi Andrew, Thanks again for finding the fix to the problem I reported. Can you tell me when I might expect this fix to show up in 2.6.20-rc? Thanks, Mike -
Jan 19, 11:14 am 2007
Oliver Neukum
Re: [linux-usb-devel] 2.6.20-rc4: usb somehow broken
Hi, I need "lsusb -v" for your device. Regards Oliver -
Jan 19, 4:29 am 2007
Prakash Punnoor
Re: [linux-usb-devel] 2.6.20-rc4: usb somehow broken
--Boundary-01=_qnMsFdijl38wsgH Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Here you go. =2D-=20 (=C2=B0=3D =3D=C2=B0) //\ Prakash Punnoor /\\ V_/ \_V --Boundary-01=_qnMsFdijl38wsgH Content-Type: application/x-bzip2; name="lsusb.txt.bz2" Content-Transfer-Encoding: base64 Content-Disposition: ...
Jan 19, 6:38 am 2007
Jeff Garzik Jan 18, 8:01 pm 2007
Jeff Garzik
Re: [PATCH 4/4] atl1: Ancillary C files for Attansic L1 driver
PCI posting (need to read a register before delaying to guarantee flush; standard technique is to use random bytes, not a fixed address like this, when MAC address is otherwise unavailable. consider what happens -
Jan 18, 8:00 pm 2007
Jeff Garzik
Re: [PATCH 1/10] cxgb3 - main header files
applied to netdev-2.6.git#upstream I'm really counting on Chelsio to actively maintain this driver, unlike the abandonware you guys first submitted. Jeff -
Jan 18, 8:05 pm 2007
Guennadi Liakhovetski
Re: [patch 3/3] clockevent driver for arm/pxa2xx
This doesn't work for me in various nasty ways. Please, check for a minimum delay or loop to get ahead of time. See code in the "old" timer ISR. See how it unconditionally adds at least 10 ticks... Thanks Guennadi --- Guennadi Liakhovetski -
Jan 19, 12:13 pm 2007
Thomas Gleixner
Re: [patch 3/3] clockevent driver for arm/pxa2xx
I added support for match register based devices and you want to do something like this: static int hpet_next_event(unsigned long delta, struct clock_event_device *evt) { unsigned long cnt; cnt = hpet_readl(HPET_COUNTER); cnt += delta; hpet_writel(cnt, HPET_T0_CMP); return ((long)(hpet_readl(HPET_COUNTER) - cnt ) > 0); } The generic code takes care of the already expired event. tglx -
Jan 19, 12:33 pm 2007
Kawai, Hidehiro
Re: [PATCH] binfmt_elf: core dump masking support
For example, consider the following case: a process forks many children and system administrator wants to allow only one of these processes to dump shared memory. This is accomplished as follows: $ echo 1 > /proc/self/coremask $ ./some_program (fork children) $ echo 0 > /proc/<a child's pid>/coremask With the /proc/<pid>/ interface, we don't need to modify the user program. In contrast, with the ulimit or setrlimit interface, the administrator can't do it without modifying the ...
Jan 18, 5:40 pm 2007
Pavel Machek
Re: [PATCH] binfmt_elf: core dump masking support
Yep, otoh process coremask setting can change while it is running, that is not expected. Hmm, it can also change while it is dumping core, are you sure it is not racy? (run echo 1 > coremask, echo 0 > coremask in a loop while dumping core. Do you have enough locking to make it work as expected?) Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -
Jan 18, 5:45 pm 2007
Jeff Garzik Jan 18, 8:05 pm 2007
Pierre Ossman
Re: mmc: correct semantics of the mmc_host_remove
That shouldn't be possible. Are you using the block queue fixes I wrote? Otherwise you will get problems like this. Basically, when you call mmc_host_remove(), it will remove all card devices. That shouldn't complete until all card drivers have released control of the card. At that point there is no one else accessing the device. If you see something else, then we have a bug somewhere. Rgds -- -- Pierre Ossman Linux kernel, MMC maintainer http://www.kernel.org ...
Jan 19, 1:47 am 2007
Alex Dubov
mmc: correct semantics of the mmc_host_remove
Greetings. It appears to me that under certain circumstances mmc layer will issue requests to the host after mmc_host_remove returns. This happens, for example, in tifm_sd driver because mmc_host may be removed mid-transfer, as the socket shall be freed for possible reuse by different media type. Currently, the only solution is to sleep a little somewhere after mmc_remove_host but before mmc_free_host. I think the correct way to handle the situation is to ensure that mmc_host is never accessed ...
Jan 18, 6:50 pm 2007
previous daytodaynext day
January 18, 2007January 19, 2007January 20, 2007