On Sunday 03 June 2007, J=C3=B6rn Engel wrote:

quoted text
> Unchanged:
> o error handling
>=20
=2E..
quoted text
> Won't happen (unless I get convinced to do otherwise):
> o Change LOGFS_BUG() and LOGFS_BUG_ON() to inline functions
>   These are macros for very much the same reasons BUG() and BUG_ON() =
are.

I wonder how many of your LOGFS_BUG{,_ON} still remain after the
error handling is in place to deal with broken file system contents.
Ideally, I'd say the current LOGFS_BUG() should be replaced with
a function that prints about the kind of error it has hit (rate-limited=
),
potentially calls logfs_crash_dump(), and remounts the medium read-only=
,
but _not_ call BUG().

	Arnd <><
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel=
" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html