[REGRESSION] git var GIT_EDITOR fails without tty

view
thread

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?=

Subject: [REGRESSION] git var GIT_EDITOR fails without tty

Date: Monday, March 22, 2010 - 7:59 am

Hello,

since b4479f074760a788dd4e353b8c86a7d735afc53e git send-email (and
others) use git var GIT_EDITOR.  This is OK as such but it breaks the
post-receive hooks that I use on several repositories.

When called they don't have a tty, and this makes git var fail:

	user@host:~$ ssh localhost "git var GIT_EDITOR"
	fatal: Terminal is dumb, but EDITOR unset

IMHO git send-email should only call $(git var GIT_EDITOR) when it
actually needs it.

(Note I'm using the Debian packaged version of git.  I don't think this
problem is Debian specific, I didn't check though.)

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[REGRESSION] git var GIT_EDITOR fails without tty, Uwe =?iso-8859-1?Q?K ..., (Mon Mar 22, 7:59 am)

[PATCH] send-email: lazily assign editor variable, Michael J Gruber, (Mon Mar 22, 9:12 am)

Re: [PATCH] send-email: lazily assign editor variable, Uwe =?iso-8859-1?Q?K ..., (Mon Mar 22, 9:41 am)

[PATCH] send-email: do not check for editor until needed, Jonathan Nieder, (Mon Mar 22, 4:25 pm)

Re: [PATCH] send-email: lazily assign editor variable, Jonathan Nieder, (Mon Mar 22, 5:58 pm)

RE: [PATCH] send-email: do not check for editor until needed, Peter Kjellerstedt, (Tue Mar 23, 2:15 am)

Re: [PATCH] send-email: lazily assign editor variable, Michael J Gruber, (Tue Mar 23, 3:56 am)

Re: [PATCH] send-email: do not check for editor until needed, Jonathan Nieder, (Tue Mar 23, 12:25 pm)

Re: [PATCH] send-email: lazily assign editor variable, Junio C Hamano, (Wed Mar 24, 10:52 am)

Re: [PATCH] send-email: lazily assign editor variable, Jonathan Nieder, (Wed Mar 24, 10:17 pm)

Re: [PATCH] send-email: lazily assign editor variable, Michael J Gruber, (Thu Mar 25, 1:03 am)

Re: [PATCH] send-email: lazily assign editor variable, Junio C Hamano, (Fri Mar 26, 12:32 pm)

Re: [PATCH] send-email: lazily assign editor variable, Jonathan Nieder, (Fri Mar 26, 2:45 pm)