Re: [PATCH v2] git-send-email.perl: fix In-Reply-To for second and subsequent patches | KernelTrap

Re: [PATCH v2] git-send-email.perl: fix In-Reply-To for second and subsequent patches

view
thread

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

[view in full thread]

From: Jonathan Nieder

Subject: Re: [PATCH v2] git-send-email.perl: fix In-Reply-To for second and subsequent patches

Date: Friday, November 5, 2010 - 2:41 pm

Hi Antonio,

Antonio Ospite wrote:
quoted text> Junio C Hamano <gitster@pobox.com> wrote:

quoted text>> You are breaking the && chain here.
>
> Some other tests do that as well, the last line is a command by
> itself not and-chained with the git-send-email invocation. I guess the
> logic behind this is that the test succeeds if the _last_ command
> succeeds. If this is wrong then some other tests are affected too.

Yes, breaking the && chain is never a good thing.

See:

 - t/README: "Chain your test assertions"
 - v1.5.4~20 (t9001: add missing && operators, 2008-01-21)
 - git log --grep=&&

Hope that helps,
Jonathan
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH] git-send-email.perl: fix In-Reply-To for second an ..., Antonio Ospite, (Thu Oct 14, 2:38 am)

Re: [PATCH] git-send-email.perl: fix In-Reply-To for secon ..., Jonathan Nieder, (Thu Oct 14, 11:22 am)

Re: [PATCH] git-send-email.perl: fix In-Reply-To for secon ..., Antonio Ospite, (Fri Oct 15, 12:56 am)

[PATCH v2] git-send-email.perl: fix In-Reply-To for second ..., Antonio Ospite, (Tue Oct 19, 2:52 am)

Re: [PATCH v2] git-send-email.perl: fix In-Reply-To for se ..., Junio C Hamano, (Tue Oct 19, 11:26 am)

Re: [PATCH v2] git-send-email.perl: fix In-Reply-To for se ..., Junio C Hamano, (Tue Oct 19, 11:45 am)

Re: [PATCH v2] git-send-email.perl: fix In-Reply-To for se ..., Antonio Ospite, (Tue Oct 19, 3:45 pm)

Re: [PATCH v2] git-send-email.perl: fix In-Reply-To for se ..., Antonio Ospite, (Tue Oct 26, 6:50 am)

[PATCH v3] git-send-email.perl: make initial In-Reply-To a ..., Antonio Ospite, (Fri Nov 5, 1:59 pm)

Re: [PATCH v2] git-send-email.perl: fix In-Reply-To for se ..., Jonathan Nieder, (Fri Nov 5, 2:41 pm)

Re: [PATCH v3] git-send-email.perl: make initial In-Reply- ..., Matthieu Moy, (Fri Nov 5, 3:36 pm)

Re: [PATCH v2] git-send-email.perl: fix In-Reply-To for se ..., Antonio Ospite, (Mon Nov 8, 4:03 am)

Re: [PATCH v3] git-send-email.perl: make initial In-Reply- ..., Junio C Hamano, (Tue Nov 9, 2:23 pm)

Re: [PATCH v3] git-send-email.perl: make initial In-Reply- ..., Antonio Ospite, (Wed Nov 10, 4:45 am)

Re: [PATCH v3] git-send-email.perl: make initial In-Reply- ..., Junio C Ha