Re: [PATCHv3] git apply: option to ignore whitespace differences

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Junio C Hamano
Date: Wednesday, July 29, 2009 - 12:09 am

Giuseppe Bilotta <giuseppe.bilotta@gmail.com> writes:


Doing so will be actively wrong.

In the case of "whitespace=fix", it is justifiable to update ws broken
context lines while applying a ws corrected patch to a ws broken target,
and it also is justifiable not to update context lines while applying a ws
broken patch to a ws corrected target, because it is clear which one has
the correct whitespace layout (i.e. output of ws_fix_copy() by definition
is the correct outcome).  But in your example, it is not clear if the
layout using 4 spaces is correct or the one with a tab.  The tool should
refrain from guessing in such a case.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCHv3] git apply: option to ignore whitespace differences, Giuseppe Bilotta, (Tue Jul 28, 2:00 pm)
Re: [PATCHv3] git apply: option to ignore whitespace diffe ..., Giuseppe Bilotta, (Tue Jul 28, 11:33 pm)
Re: [PATCHv3] git apply: option to ignore whitespace diffe ..., Junio C Hamano, (Wed Jul 29, 12:09 am)