Home » Mailing list archives » git » 2009 » July » 25

[JGIT PATCH 05/19] Use type specific sets when creating a new RepositoryConfig

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
[view in full thread]
From: Shawn O. Pearce
Subject: [JGIT PATCH 05/19] Use type specific sets when creating a new RepositoryConfig
Date: Saturday, July 25, 2009 - 11:52 am

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
 .../src/org/spearce/jgit/lib/Repository.java       |    5 ++---
 .../src/org/spearce/jgit/lib/RepositoryConfig.java |    4 ++--
 2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/Repository.java b/org.spearce.jgit/src/org/spearce/jgit/lib/Repository.java
index 1076fe1..98a276b 100644
--- a/org.spearce.jgit/src/org/spearce/jgit/lib/Repository.java
+++ b/org.spearce.jgit/src/org/spearce/jgit/lib/Repository.java
@@ -166,9 +166,8 @@ public void create(boolean bare) throws IOException {
 
 		RepositoryConfig cfg = getConfig();
 		cfg.create();
-		if (bare) {
-			cfg.setString("core", null, "bare", "true");
-		}
+		if (bare)
+			cfg.setBoolean("core", null, "bare", true);
 		cfg.save();
 	}
 
diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/RepositoryConfig.java b/org.spearce.jgit/src/org/spearce/jgit/lib/RepositoryConfig.java
index 85e8738..c80db00 100644
--- a/org.spearce.jgit/src/org/spearce/jgit/lib/RepositoryConfig.java
+++ b/org.spearce.jgit/src/org/spearce/jgit/lib/RepositoryConfig.java
@@ -203,8 +203,8 @@ private String getUserEmailInternal(String gitVariableKey) {
 	public void create() {
 		clear();
 		setFileRead(true);
-		setString("core", null, "repositoryformatversion", "0");
-		setString("core", null, "filemode", "true");
+		setInt("core", null, "repositoryformatversion", 0);
+		setBoolean("core", null, "filemode", true);
 
 		core = new CoreConfig(this);
 		transfer = new TransferConfig(this);
-- 
1.6.4.rc2.216.g769fa

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
Messages in current thread:
[JGIT PATCH 04/19] Allow a RemoteConfig to use the more ge ..., Shawn O. Pearce, (Sat Jul 25, 11:52 am)
[JGIT PATCH 05/19] Use type specific sets when creating a ..., Shawn O. Pearce, (Sat Jul 25, 11:52 am)
[JGIT PATCH 06/19] Move SystemReader out of RepositoryConfig, Shawn O. Pearce, (Sat Jul 25, 11:52 am)
[JGIT PATCH 07/19] Correct user config to be of type FileB ..., Shawn O. Pearce, (Sat Jul 25, 11:52 am)
[JGIT PATCH 08/19] Extract the test specific SystemReader ..., Shawn O. Pearce, (Sat Jul 25, 11:52 am)
[JGIT PATCH 09/19] Refactor Config hierarchy to make IO mo ..., Shawn O. Pearce, (Sat Jul 25, 11:52 am)
[JGIT PATCH 10/19] Test for the config file when creating ..., Shawn O. Pearce, (Sat Jul 25, 11:52 am)
[JGIT PATCH 11/19] Remove the map lookup for values in Config, Shawn O. Pearce, (Sat Jul 25, 11:52 am)
[JGIT PATCH 12/19] Return base values first from Config.ge ..., Shawn O. Pearce, (Sat Jul 25, 11:52 am)
[JGIT PATCH 13/19] Make Config thread safe by using copy-o ..., Shawn O. Pearce, (Sat Jul 25, 11:52 am)
[JGIT PATCH 14/19] Support cached application models in a ..., Shawn O. Pearce, (Sat Jul 25, 11:52 am)
[JGIT PATCH 15/19] Cache Config subsection names when requ ..., Shawn O. Pearce, (Sat Jul 25, 11:52 am)
[JGIT PATCH 16/19] Refactor author/committer lookup to use ..., Shawn O. Pearce, (Sat Jul 25, 11:52 am)
[JGIT PATCH 17/19] Move repository config creation fully i ..., Shawn O. Pearce, (Sat Jul 25, 11:53 am)
[JGIT PATCH 18/19] Use Config SectionParser cache to store ..., Shawn O. Pearce, (Sat Jul 25, 11:53 am)
[JGIT PATCH 19/19] Use Config cache for fetch and receive ..., Shawn O. Pearce, (Sat Jul 25, 11:53 am)
Re: [JGIT PATCH 09/19] Refactor Config hierarchy to make I ..., Robin Rosenberg, (Sat Jul 25, 3:54 pm)
Re: [JGIT PATCH 09/19] Refactor Config hierarchy to make I ..., Shawn O. Pearce, (Sat Jul 25, 3:55 pm)
Re: [JGIT PATCH 09/19] Refactor Config hierarchy to make I ..., Robin Rosenberg, (Sat Jul 25, 4:34 pm)
Re: [JGIT PATCH 09/19] Refactor Config hierarchy to make I ..., Shawn O. Pearce, (Sat Jul 25, 4:38 pm)