Re: [PATCH 1/2] Make section_name_match start on '[', and return the length on success

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Alex Vandiver

Subject: Re: [PATCH 1/2] Make section_name_match start on '[', and return the length on success

Date: Saturday, July 25, 2009 - 10:18 am

At Sat Jul 25 10:09:56 -0400 2009, Johannes Schindelin wrote:
quoted text> Is this not unnecessary, given that we  only call that function when we 
> know that buf[0] == '[':

Yes.  However, given that I had changed the calling convention for the
code, (it used to be passed the string starting just _inside_ the
'['), I wanted to make the new calling convention clearer, and catch
any places that were using the old convention.

I'm happy to submit a new version without it, if you wish.

quoted text> I was a bit surprised that "offset" is not used further in your patch, but 
> I saw that 2/2 uses it.

Yeah, this hunk should probably have gone in 2/2 instead.
 - Alex
-- 
Networking -- only one letter away from not working
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH 1/2] Make section_name_match start on '[', and retu ..., Alex Vandiver, (Fri Jul 24, 2:21 pm)

[PATCH 2/2] After renaming a section, print any trailing v ..., Alex Vandiver, (Fri Jul 24, 2:21 pm)

Re: [PATCH 2/2] After renaming a section, print any traili ..., Nanako Shiraishi, (Fri Jul 24, 3:11 pm)

Re: [PATCH 2/2] After renaming a section, print any traili ..., Alex Vandiver, (Fri Jul 24, 3:26 pm)

Re: [PATCH 2/2] After renaming a section, print any traili ..., Junio C Hamano, (Fri Jul 24, 4:39 pm)

[No subject], Nanako Shiraishi, (Fri Jul 24, 5:28 pm)

Re: [PATCH 1/2] Make section_name_match start on '[', and ..., Johannes Schindelin, (Sat Jul 25, 7:09 am)

Re: [PATCH 2/2] After renaming a section, print any traili ..., Johannes Schindelin, (Sat Jul 25, 7:10 am)

Re: [PATCH 1/2] Make section_name_match start on '[', and ..., Alex Vandiver, (Sat Jul 25, 10:18 am)

Re: [PATCH 1/2] Make section_name_match start on '[', and ..., Junio C Hamano, (Sat Jul 25, 10:39 am)

Re: [PATCH 1/2] Make section_name_match start on '[', and ..., Johannes Schindelin, (Sat Jul 25, 10:41 am)

[PATCH] Make git config fail on variables with no section, ..., Alex Vandiver, (Sun Jul 26, 9:18 am)

Re: [PATCH] Make git config fail on variables with no sect ..., Johannes Schindelin, (Sun Jul 26, 9:49 am)

Re: [PATCH] Make git config fail on variables with no sect ..., Alex Vandiver, (Sun Jul 26, 12:32 pm)