Re: [PATCH 4/4] remote: new show output style

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Marc Branchaud
Date: Friday, February 20, 2009 - 3:34 pm

Jay Soffian wrote:

All valid points.  But, dang it, I really think intelligently adding that extra space the right thing to do.

It wouldn't be all that tedious -- you could detect the need for the extra space in config_read_branches() the first time type is set to REBASE, no?


Quite right.  Julian made the point better than I: it's fairly idiomatic.  I think it's reasonable to assume that many users of the English version of git aren't native English speakers.

Plus it throws the alignment with "rebases" lines way off...


Fair enough.

Thanks again!

		M.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
[PATCH 0/4] Improve "remote show" output, Jay Soffian, (Wed Feb 18, 10:14 pm)
[PATCH 3/4] string-list: add for_each_string_list(), Jay Soffian, (Wed Feb 18, 10:14 pm)
[PATCH 4/4] remote: new show output style, Jay Soffian, (Wed Feb 18, 10:14 pm)
Re: [PATCH 4/4] remote: new show output style, Marc Branchaud, (Thu Feb 19, 9:03 am)
Re: [PATCH 4/4] remote: new show output style, Sverre Rabbelier, (Thu Feb 19, 9:16 am)
Re: [PATCH 4/4] remote: new show output style, Rostislav Svoboda, (Thu Feb 19, 9:17 am)
Re: [PATCH 4/4] remote: new show output style, Marc Branchaud, (Thu Feb 19, 9:31 am)
Re: [PATCH 4/4] remote: new show output style, Sverre Rabbelier, (Thu Feb 19, 9:33 am)
Re: [PATCH 4/4] remote: new show output style, Jay Soffian, (Thu Feb 19, 10:57 am)
Re: [PATCH 4/4] remote: new show output style, Jay Soffian, (Thu Feb 19, 10:59 am)
Re: [PATCH 4/4] remote: new show output style, Julian Phillips, (Thu Feb 19, 11:58 am)
Re: [PATCH 4/4] remote: new show output style, Johannes Sixt, (Thu Feb 19, 12:29 pm)
Re: [PATCH 4/4] remote: new show output style, Jay Soffian, (Thu Feb 19, 12:51 pm)
Re: [PATCH 4/4] remote: new show output style, Marc Branchaud, (Fri Feb 20, 3:34 pm)
Re: [PATCH 4/4] remote: new show output style, Jay Soffian, (Fri Feb 20, 3:55 pm)