Re: [PATCH v2 2/2] system_path(): simplify using strip_path_suffix(), and add suffix "git"

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

From: Johannes Schindelin

Subject: Re: [PATCH v2 2/2] system_path(): simplify using strip_path_suffix(), and add suffix "git"

Date: Thursday, February 19, 2009 - 1:48 pm

Hi,

On Thu, 19 Feb 2009, Johannes Sixt wrote:

quoted text> Johannes Schindelin schrieb:
> > The real change is to add the suffix "git", so that a runtime prefix will
> > be computed correctly even when the executable was called in /git/ as is
> > the case in msysGit (Windows insists to search the current directory
> > before the PATH when looking for an executable).
> 
> msysgit is important enough to be supported by upstream git, in particular
> since it is *the* user of RUNTIME_PREFIX, so that this special-casing is
> warranted. Therefore:
> 
> Acked-by: Johannes Sixt <j6t@kdbg.org>

Thanks.

Note, however, that IMHO RUNTIME_PREFIX would be good for non-Windows, 
too, as it would make Git relocatable.

Ciao,
Dscho

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:

[PATCH 0/2] RUNTIME_PREFIX enhancements, Johannes Schindelin, (Wed Feb 18, 8:10 am)

[PATCH 1/2] Introduce the function strip_path_suffix(), Johannes Schindelin, (Wed Feb 18, 8:11 am)

[PATCH 2/2] system_path(): simplify using strip_path_suffi ..., Johannes Schindelin, (Wed Feb 18, 8:11 am)

Re: [PATCH 0/2] RUNTIME_PREFIX enhancements, Johannes Sixt, (Wed Feb 18, 12:38 pm)

Re: [PATCH 1/2] Introduce the function strip_path_suffix(), Johannes Sixt, (Wed Feb 18, 12:39 pm)

Re: [PATCH 0/2] RUNTIME_PREFIX enhancements, Johannes Schindelin, (Wed Feb 18, 2:11 pm)

Re: [PATCH 1/2] Introduce the function strip_path_suffix(), Johannes Schindelin, (Wed Feb 18, 2:13 pm)

Re: [PATCH 1/2] Introduce the function strip_path_suffix(), Johannes Sixt, (Wed Feb 18, 3:27 pm)

Re: [PATCH 0/2] RUNTIME_PREFIX enhancements, Johannes Sixt, (Wed Feb 18, 3:52 pm)

Re: [PATCH 1/2] Introduce the function strip_path_suffix(), Johannes Schindelin, (Wed Feb 18, 4:18 pm)

Re: [PATCH 0/2] RUNTIME_PREFIX enhancements, Johannes Schindelin, (Wed Feb 18, 4:19 pm)

[PATCH v2 0/2] RUNTIME_PREFIX enhancements, Johannes Schindelin, (Thu Feb 19, 12:10 pm)

[PATCH v2 1/2] Introduce the function strip_path_suffix(), Johannes Schindelin, (Thu Feb 19, 12:10 pm)

[PATCH v2 2/2] system_path(): simplify using strip_path_su ..., Johannes Schindelin, (Thu Feb 19, 12:10 pm)

Re: [PATCH v2 1/2] Introduce the function strip_path_suffix(), Johannes Schindelin, (Thu Feb 19, 1:12 pm)

Re: [PATCH v2 1/2] Introduce the function strip_path_suffix(), Johannes Sixt, (Thu Feb 19, 1:26 pm)