ALSA: hda - Enable beep on Realtek codecs with PCI SSID override

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linux Kernel Mailing List
Date: Thursday, July 8, 2010 - 8:59 am

Gitweb:     http://git.kernel.org/linus/f189efcd1cc06b75fe18642c9751d26aa5ed2b54
Commit:     f189efcd1cc06b75fe18642c9751d26aa5ed2b54
Parent:     3bfea98ff73d377ffce0d4c7f938b7ef958cdb35
Author:     Takashi Iwai <tiwai@suse.de>
AuthorDate: Mon Jul 5 17:28:17 2010 +0200
Committer:  Takashi Iwai <tiwai@suse.de>
CommitDate: Mon Jul 5 17:28:17 2010 +0200

    ALSA: hda - Enable beep on Realtek codecs with PCI SSID override
    
    When the PCI SSID gives an overriding SKU assno, PC-beep bit isn't
    detected (since it's located over 16bit), resulting in no PC beep.
    Also, many devices seem ignoring the requirement by Realtek's spec
    for SSID numbers, and it also confuses the PC beep detection.
    
    This patch assumes the PC beep is available on every machine with
    PCI SSID override.  It's a regression fix from 2.6.34.
    
    Reference: Kernel bug 16251
    	http://bugzilla.kernel.org/show_bug.cgi?id=16251
    
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 sound/pci/hda/patch_realtek.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 32299ee..ff614dd 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -1268,8 +1268,10 @@ static int alc_auto_parse_customize_define(struct hda_codec *codec)
 	struct alc_spec *spec = codec->spec;
 
 	ass = codec->subsystem_id & 0xffff;
-	if (ass != codec->bus->pci->subsystem_device && (ass & 1))
+	if (ass != codec->bus->pci->subsystem_device && (ass & 1)) {
+		spec->cdefine.enable_pcbeep = 1; /* assume always enabled */
 		goto do_sku;
+	}
 
 	nid = 0x1d;
 	if (codec->vendor_id == 0x10ec0260)
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
ALSA: hda - Enable beep on Realtek codecs with PCI SSID ov ..., Linux Kernel Mailing ..., (Thu Jul 8, 8:59 am)