PCI hotplug: acpiphp: remove superfluous _HPP/_HPX evaluation

Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]
From: Linux Kernel Mailing List
Date: Wednesday, September 16, 2009 - 8:00 am

Gitweb:     http://git.kernel.org/linus/dffb4bb560ed73937a52c68c304b232c743b49f7
Commit:     dffb4bb560ed73937a52c68c304b232c743b49f7
Parent:     4b77b0a2ba27d64f58f16d8d4d48d8319dda36ff
Author:     Bjorn Helgaas <bjorn.helgaas@hp.com>
AuthorDate: Mon Sep 14 16:35:05 2009 -0600
Committer:  Jesse Barnes <jbarnes@virtuousgeek.org>
CommitDate: Mon Sep 14 17:38:19 2009 -0700

    PCI hotplug: acpiphp: remove superfluous _HPP/_HPX evaluation
    
    decode_hpp() looks up hotplug PCI parameters from ACPI and saves them
    in the acpiphp_bridge structure.  These parameters (in bridge->hpp) are
    only used by the acpiphp_set_hpp_values() -> program_hpp() path.  In
    that path, we always call decode_hpp() before program_hpp(), so there's
    no need to do it in init_bridge_misc().
    
    Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
    Reviewed-by: Alex Chiang <achiang@hp.com>
    Reviewed-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
    Acked-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
    Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
---
 drivers/pci/hotplug/acpiphp_glue.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/drivers/pci/hotplug/acpiphp_glue.c b/drivers/pci/hotplug/acpiphp_glue.c
index 680c336..e062337 100644
--- a/drivers/pci/hotplug/acpiphp_glue.c
+++ b/drivers/pci/hotplug/acpiphp_glue.c
@@ -300,9 +300,6 @@ static void init_bridge_misc(struct acpiphp_bridge *bridge)
 {
 	acpi_status status;
 
-	/* decode ACPI 2.0 _HPP (hot plug parameters) */
-	decode_hpp(bridge);
-
 	/* must be added to the list prior to calling register_slot */
 	list_add(&bridge->list, &bridge_list);
 
--
To unsubscribe from this list: send the line "unsubscribe git-commits-head" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Previous message: [thread] [date] [author]
Next message: [thread] [date] [author]

Messages in current thread:
PCI hotplug: acpiphp: remove superfluous _HPP/_HPX evaluation, Linux Kernel Mailing ..., (Wed Sep 16, 8:00 am)