Home » Mailing list archives » freebsd-current » 2008 » December » 8

Re: svn commit: r185482 - head/sys/dev/ath/ath_rate/sample

Previous thread: em(4) not sending/receiving data in recent current ? by Phil Regnauld on Sunday, December 7, 2008 - 3:30 pm. (7 messages)

Next thread: panic: _rw_wlock_hard: recursing but non-recursive rw radix node head by Paul B. Mahol on Monday, December 8, 2008 - 7:58 am. (4 messages)
[view original message]
From: Vladimir Grebenschikov
Subject: Re: svn commit: r185482 - head/sys/dev/ath/ath_rate/sample
Date: Monday, December 8, 2008 - 5:27 am

Looks like, after that commit, I can't use if_ath loaded as module any
more:

# kldload /boot/kernel/ath_rate.ko
kldload: can't load /boot/kernel/ath_rate.ko: No such file or directory
# dmesg | tail -n1 
link_elf: symbol ath_hal_computetxtime undefined
#

Yes, I've read UPDATING entry 20081130.
But I have no ath_hal entry in my kernel config, 
I've loaded ath as KLDs.

How to fix that problem ?


-- 
Vladimir B. Grebenschikov
vova@fbsd.ru
_______________________________________________
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"

[ message continues ]
[view original message]
From: Jille Timmermans
Subject: Re: svn commit: r185482 - head/sys/dev/ath/ath_rate/sample
Date: Monday, December 8, 2008 - 5:33 am

I have the same problem if I load it with kernel modules.
If I compile it into my kernel (with ath, ath_hal and that option (can't 
remember it for now)) my system paniced during boot.
I can't get a coredump, but I will try getting a stacktrace with ddb 
tonight.

My Atheros (2413 iirc) wasn't usable before the import (did some 
printf's during boot, but I couldn't get ath0 showing up in ifconfig)
I am willing to help debugging if needed.

-- Jille
_______________________________________________
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"

[ message continues ]
[view original message]
From: Vladimir Grebenschikov
Subject: Re: svn commit: r185482 - head/sys/dev/ath/ath_rate/sample
Date: Monday, December 8, 2008 - 5:40 am

On Mon, 2008-12-08 at 13:33 +0100, Jille Timmermans wrote:

after
cd /sys/modules/ath_rate_amrr
make all
make install
kldload /boot/kernel/ath_rate .ko

It works now, but why three directories in sys/modules tree make
same .ko object:

# fgrep ath /sys/modules/Makefile
	ath \
	ath_rate_amrr \
	ath_rate_onoe \
	ath_rate_sample \
# fgrep KMOD /sys/modules/ath_rate*/Makefile
/sys/modules/ath_rate_amrr/Makefile:KMOD=	ath_rate
/sys/modules/ath_rate_onoe/Makefile:KMOD=	ath_rate
/sys/modules/ath_rate_sample/Makefile:KMOD=	ath_rate
#

-- 
Vladimir B. Grebenschikov
vova@fbsd.ru
_______________________________________________
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"

[ message continues ]
[view original message]
From: Sam Leffler
Subject: Re: svn commit: r185482 - head/sys/dev/ath/ath_rate/sample
Date: Monday, December 8, 2008 - 3:40 pm

ath's rate control module is bound using symbols so only one of these 
modules can ever be used at a time.  A module dependency is used to 
auto-load the rate control module hence the fixed name.

At the time this code was written it was felt the overhead to use 
indirect function calls and the like was too significant.  Now folks may 
not care in which case you could use some sort of registration-style 
mechanism to allow runtime selection of the rate control algorithm.  Fee 
free to supply patches.

OTOH sample is so vastly superior to the other 2 algorithms that I 
almost removed the others recently.

    Sam


_______________________________________________
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"

[ message continues ]
[view original message]
From: Sam Leffler
Subject: Re: svn commit: r185482 - head/sys/dev/ath/ath_rate/sample
Date: Monday, December 8, 2008 - 3:36 pm

Where is the PR?

    Sam

_______________________________________________
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"

[ message continues ]
[view original message]
From: Sam Leffler
Subject: Re: svn commit: r185482 - head/sys/dev/ath/ath_rate/sample
Date: Monday, December 8, 2008 - 3:36 pm

Try the attached change.

    Sam


[ message continues ]
[view original message]
From: Sam Leffler
Subject: Re: svn commit: r185482 - head/sys/dev/ath/ath_rate/sample
Date: Monday, December 8, 2008 - 8:48 pm

Never mind this; you'll have to build ath into the kernel until I can 
sort out how to fix the module(s).

    Sam

_______________________________________________
freebsd-current@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"

[ message continues ]
Previous thread: em(4) not sending/receiving data in recent current ? by Phil Regnauld on Sunday, December 7, 2008 - 3:30 pm. (7 messages)

Next thread: panic: _rw_wlock_hard: recursing but non-recursive rw radix node head by Paul B. Mahol on Monday, December 8, 2008 - 7:58 am. (4 messages)